mbox

igb: Update to 5.3.2.2

Message ID 1439657166-26864-1-git-send-email-matthias.fischer@ipfire.org
State Deferred
Headers

Message

Matthias Fischer Aug. 16, 2015, 2:46 a.m. UTC 
  Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org>
---
 lfs/igb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Arne Fitzenreiter Aug. 16, 2015, 3:54 p.m. UTC | #1 
Is the MultiQueue mode working with this version?

Currently we not use the igb lfs because the older Version from 
backports works with MultiQueue.
Matthias Fischer Aug. 16, 2015, 5:25 p.m. UTC | #2 
Hi,

On 16.08.2015 07:54, Arne Fitzenreiter wrote:
> Is the MultiQueue mode working with this version?

Being rather naive, I just saw that this version was relatively old, had 
some "computing time" left on my devel, so I thought: "Why not...?" ;-)

> Currently we not use the igb lfs because the older Version from
> backports works with MultiQueue.

I didn't know that and actually can't test this driver on my system. I 
just thought it could be updated.

An excerpt from README - perhaps always the same - leads me to the 
assumption that Multiqueue mode perhaps can be enabled (?):

***SNIP***
Multiqueue
----------

In this mode, a separate MSI-X vector is allocated for each queue and 
one for "other" interrupts such as link status change and errors. All 
interrupts are throttled via interrupt moderation. Interrupt moderation 
must be used to avoid interrupt storms while the driver is processing 
one interrupt. The moderation value should be at least as large as the 
expected time for the driver to process an interrupt. Multiqueue is off 
by default.

REQUIREMENTS: MSI-X support is required for Multiqueue. If MSI-X is not 
found, the system will fallback to MSI or to Legacy interrupts. This 
driver supports multiqueue in kernel versions 2.6.24 and newer. This 
driver supports receive multiqueue on all kernels that support MSI-X.

NOTES:

- Do not use MSI-X with the 2.6.19 or 2.6.20 kernels.
- On some kernels a reboot is required to switch between single queue 
mode and multiqueue mode or vice-versa.
***SNAP***

Regards
Matthias
Matthias Fischer Aug. 16, 2015, 5:32 p.m. UTC | #3 
Hi,

On 16.08.2015 07:54, Arne Fitzenreiter wrote:
> Is the MultiQueue mode working with this version?

'/src/igb.h' says...

***SNIP***
...
/* Interrupt modes, as used by the IntMode paramter */
#define IGB_INT_MODE_LEGACY                0
#define IGB_INT_MODE_MSI                   1
#define IGB_INT_MODE_MSIX                  2
...
***SNAP***

...so in *my* opinion something *must* be possible...

It seems that this *not* enabled by default, but can be forced.

Regards
Matthias
Michael Tremer Aug. 18, 2015, 7:24 a.m. UTC | #4 
Hi,

this driver is currently not compiled any way.

So I guess merging this does not make any sense until the kernel is
updated, too.

Best,
-Michael

On Sun, 2015-08-16 at 09:32 +0200, Matthias Fischer wrote:
> Hi,
> 
> On 16.08.2015 07:54, Arne Fitzenreiter wrote:
> > Is the MultiQueue mode working with this version?
> 
> '/src/igb.h' says...
> 
> ***SNIP***
> ...
> /* Interrupt modes, as used by the IntMode paramter */
> #define IGB_INT_MODE_LEGACY                0
> #define IGB_INT_MODE_MSI                   1
> #define IGB_INT_MODE_MSIX                  2
> ...
> ***SNAP***
> 
> ...so in *my* opinion something *must* be possible...
> 
> It seems that this *not* enabled by default, but can be forced.
> 
> Regards
> Matthias
>