diff mbox series

fireinfo.cgi: improve readability of command outputs

Message ID 0faba960-9f85-1d39-41d6-6969cd91c1ed@ipfire.org
State Accepted
Commit 99644abaf5f09143f31fc678499695a8b0ad6a51
Headers
Series fireinfo.cgi: improve readability of command outputs |

Commit Message

Peter Müller March 7, 2020, 6:58 p.m. UTC 
  Especially when it comes to the output of "uname -a", <code> tags
greatly improve readability.

Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
---
 html/cgi-bin/fireinfo.cgi | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Comments

Michael Tremer March 8, 2020, 11:48 a.m. UTC | #1 
Reviewed-by: Michael Tremer <michael.tremer@ipfire.org>

> On 7 Mar 2020, at 18:58, Peter Müller <peter.mueller@ipfire.org> wrote:
> 
> Especially when it comes to the output of "uname -a", <code> tags
> greatly improve readability.
> 
> Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
> ---
> html/cgi-bin/fireinfo.cgi | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/html/cgi-bin/fireinfo.cgi b/html/cgi-bin/fireinfo.cgi
> index 967e250c7..dfc741fde 100644
> --- a/html/cgi-bin/fireinfo.cgi
> +++ b/html/cgi-bin/fireinfo.cgi
> @@ -90,18 +90,18 @@ my $kernel_version = `uname -a`;
> 
> &Header::openbox('100%', 'left', $Lang::tr{'fireinfo system version'});
> print <<END;
> -	<table width="100%">
> +	<table cellspacing='1' cellpadding='0' class='tbl'>
> 		<tr>
> -			<td>$Lang::tr{'fireinfo ipfire version'}:</td>
> -			<td>$ipfire_version</td>
> +			<td align='center' bgcolor='#F0F0F0' width='15%'>$Lang::tr{'fireinfo ipfire version'}</td>
> +			<td bgcolor='#F0F0F0'><code>$ipfire_version</code></td>
> 		</tr>
> 		<tr>
> -			<td>$Lang::tr{'fireinfo pakfire version'}:</td>
> -			<td>$pakfire_version</td>
> +			<td align='center' bgcolor='#D6D6D6' width='15%'>$Lang::tr{'fireinfo pakfire version'}</td>
> +			<td bgcolor='#D6D6D6'><code>$pakfire_version</code></td>
> 		</tr>
> 		<tr>
> -			<td>$Lang::tr{'fireinfo kernel version'}:</td>
> -			<td>$kernel_version</td>
> +			<td align='center' bgcolor='#F0F0F0' width='15%'>$Lang::tr{'fireinfo kernel version'}</td>
> +			<td bgcolor='#F0F0F0'><code>$kernel_version</code></td>
> 		</tr>
> 	</table>
> END
> -- 
> 2.16.4
diff mbox series

Patch

diff --git a/html/cgi-bin/fireinfo.cgi b/html/cgi-bin/fireinfo.cgi
index 967e250c7..dfc741fde 100644
--- a/html/cgi-bin/fireinfo.cgi
+++ b/html/cgi-bin/fireinfo.cgi
@@ -90,18 +90,18 @@  my $kernel_version = `uname -a`;
 
 &Header::openbox('100%', 'left', $Lang::tr{'fireinfo system version'});
 print <<END;
-	<table width="100%">
+	<table cellspacing='1' cellpadding='0' class='tbl'>
 		<tr>
-			<td>$Lang::tr{'fireinfo ipfire version'}:</td>
-			<td>$ipfire_version</td>
+			<td align='center' bgcolor='#F0F0F0' width='15%'>$Lang::tr{'fireinfo ipfire version'}</td>
+			<td bgcolor='#F0F0F0'><code>$ipfire_version</code></td>
 		</tr>
 		<tr>
-			<td>$Lang::tr{'fireinfo pakfire version'}:</td>
-			<td>$pakfire_version</td>
+			<td align='center' bgcolor='#D6D6D6' width='15%'>$Lang::tr{'fireinfo pakfire version'}</td>
+			<td bgcolor='#D6D6D6'><code>$pakfire_version</code></td>
 		</tr>
 		<tr>
-			<td>$Lang::tr{'fireinfo kernel version'}:</td>
-			<td>$kernel_version</td>
+			<td align='center' bgcolor='#F0F0F0' width='15%'>$Lang::tr{'fireinfo kernel version'}</td>
+			<td bgcolor='#F0F0F0'><code>$kernel_version</code></td>
 		</tr>
 	</table>
 END