From patchwork Wed Apr 7 20:44:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robin Roevens X-Patchwork-Id: 4120 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4FFxHj2N6Xz3yBV for ; Wed, 7 Apr 2021 20:45:53 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4FFxHh1CMJzfQ; Wed, 7 Apr 2021 20:45:52 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4FFxHg6yLzz2xkF; Wed, 7 Apr 2021 20:45:51 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4FFxHf1Mc8z2xJw for ; Wed, 7 Apr 2021 20:45:50 +0000 (UTC) Received: from knopi.disroot.org (knopi.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail01.ipfire.org (Postfix) with ESMTPS id 4FFxHc5vdYzfQ for ; Wed, 7 Apr 2021 20:45:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 8130D50D96 for ; Wed, 7 Apr 2021 22:45:47 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DxWkgzCFP1iD for ; Wed, 7 Apr 2021 22:45:46 +0200 (CEST) Received: from amaterasu.sicho.home ([192.168.0.1] helo=chojin.sicho.home) by filekeeper.sicho.home with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1lUF39-0003Zi-EE for development@lists.ipfire.org; Wed, 07 Apr 2021 22:45:19 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1617828334; bh=/2y38mIL150twp3Yh+yzOTaVirBwNaHrW4dfL7iDotA=; h=From:To:Subject:Date; b=D7Xo/izAqrJsG2Qfsx5DpIpTfzTNoWZTdXqAVIfFJBP2bIQqTSdqaJgTxc+Vza5Kz BrwmWBwzSP49vMSN1PoI0/x4CoAyEwEzpQIA/cmI3EC5VzU9br+wLEgLMKjWMZvWG5 pn5UY9UwvTojZiUDWaW9OIM0FujQOMr7lwJLpt7XBA3U9HkNy/AcbV3yWW3Jrf2kAR pFeSQusfw5m54yGtQI7LSV8PsbH5UhV8gVySnsc7fMVNDVgbO6U4HF24OWF7QXX6eb U+f/dFazINNto6kuZwAVCCzFFfQjzqnLoODZKlPB+1BErUm0JJFRglZreEvzXO7Gg0 hcL0MIYTTW9RA== From: Robin Roevens To: development@lists.ipfire.org Subject: [PATCH 0/4] [V2] zabbix_agentd: new maintainer/summary Date: Wed, 7 Apr 2021 22:44:52 +0200 Message-Id: <20210407204455.450-1-robin.roevens@disroot.org> Mime-Version: 1.0 X-filekeeper-MailScanner-ID: 1lUF39-0003Zi-EE X-filekeeper-MailScanner: Found to be clean X-filekeeper-MailScanner-From: robin.roevens@disroot.org X-filekeeper-MailScanner-Watermark: 1618433126.68881@ftnn2kV76wT8S0LTLrE8KQ ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.ipfire.org; s=202003rsa; t=1617828349; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:dkim-signature; bh=Av75hYx0evdr44Ea1Q1/ou9lMNDBnmPTNu5mcQnibdk=; b=Z6uUFASFPQSFT+z8rzOAivDxuwyPqo8B7By6WJJLQEp1flUVAOyUUjCZuEH6exFwOBBlJa hKrj1WdfB2pK5w52X+ZVJAZEms0eFpB58bn4CmBn9GHDTN81taK6lh8s6IJq3eCXqtSMHo RS22rLDBNK9q76HV7Aj5wLNAoyuneZgwmxGnGxwE0mkm7bmL/2pZGLs5xU/eB3R1cui9XV YWNPcXz2N03JftQ9XF/2yk5qBTzRUIKKPrDZfdkSK2Ynef5we3aevphVdCzg0DAt9HSUmI /V7NND8nWEImS1Y+i47L1u87kbY9mQh8RgGY8WlN8/BuIqfBs/96xFLp5RmN2w== ARC-Seal: i=1; s=202003rsa; d=lists.ipfire.org; t=1617828349; a=rsa-sha256; cv=none; b=AUN6FAMdAbQyxzLKL8hK/btex+b/B4790gdfWcyexprEEzS3u5I+PDt7mHY1NRPAQ4Kd2H N7iNCuXYhLnakQl8JhFFMugFzrBALkvVprsg3I5GRoURlPq/QSkkVH+f5iLeqJEEqa/5np Y+FD1I0ALWAWSbp9s2BHYcptv8211ilYwHYz0MM3/2wWcLW5++8k5Nx0BKSUiLtpdxsxAP 5UDLhd+Oe6WVhpwHBqtL8THdNTH15+JfCb0iO/2SfMis0mGvP5cwnVHdXALRaopompQg9d 2DZHU3DE/XHGud37rCYCYGl+apSD2/ZBJCmTrA1kUF30lgwVczdNVUQdQrjWnA== ARC-Authentication-Results: i=1; mail01.ipfire.org; dkim=pass header.d=disroot.org header.s=mail header.b="D7Xo/izA"; spf=pass (mail01.ipfire.org: domain of robin.roevens@disroot.org designates 178.21.23.139 as permitted sender) smtp.mailfrom=robin.roevens@disroot.org X-Rspamd-Queue-Id: 4FFxHc5vdYzfQ Authentication-Results: mail01.ipfire.org; dkim=pass header.d=disroot.org header.s=mail header.b="D7Xo/izA"; dmarc=pass (policy=quarantine) header.from=disroot.org; spf=pass (mail01.ipfire.org: domain of robin.roevens@disroot.org designates 178.21.23.139 as permitted sender) smtp.mailfrom=robin.roevens@disroot.org X-Rspamd-Server: mail01.haj.ipfire.org X-Spamd-Result: default: False [2.22 / 11.00]; ARC_NA(0.00)[]; R_SPF_ALLOW(-0.20)[+a]; R_DKIM_ALLOW(-0.20)[disroot.org:s=mail]; FROM_HAS_DN(0.00)[]; MV_CASE(0.50)[]; R_MISSING_CHARSET(2.50)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[development@lists.ipfire.org]; BROKEN_CONTENT_TYPE(1.50)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[4]; TO_DN_NONE(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[disroot.org:+]; DMARC_POLICY_ALLOW(-0.50)[disroot.org,quarantine]; MID_CONTAINS_FROM(1.00)[]; IP_REPUTATION_HAM(-2.27)[asn: 50673(-0.32), country: NL(-0.01), ip: 178.21.23.139(-0.81)]; ARC_SIGNED(0.00)[lists.ipfire.org:s=202003rsa:i=1]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:50673, ipnet:178.21.23.0/24, country:NL]; BAYES_HAM(-0.00)[42.53%] X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: development-bounces@lists.ipfire.org Sender: "Development" Since a new version of Zabbix Agent 5 LTS was released before the previous patch-set was reviewed, I resubmit my patchset as a V2 updating current zabbix_agentd 4.2.6 to 5.0.10 as opposed to v5.0.9 in my previous submission. The other 3 patches in the set remain unchanged. For reference I'll include the summary again: This set of patches does not only update the binaries (well, the first patch only does that) but also fixes some things that I see as problematic in previous version: - /usr/lib/zabbix is created for users to drop custom agent modules in, however that dir was removed and recreated on update as it was not in the backup. I added it to the backup and prevented deletion of the directory if it is not empty upon uninstall, so user-added content would not disapear when the package is removed. - Sometimes a new version of the agent will introduce new configuration parameters. In general the Zabbix Agent config file(s) should remain compatible, but we never know what the future will bring us; and the user may miss out on new features introduced with new parameters in the config file. However we don't want to plain overwrite the configfile as the user may (probably has) have changed it. Currently on upgrade configfiles are backed up, removed, new are installed, then overwritten by the old ones from the backup. Ending with the old config and the new agent. I didn't find an example of another package doing something similar, so I chose to save the new configfile(s) as .ipfirenew-files like RPM-based distro's do with .rpmnew-files. If the original config file is absent the install script will automatically strip the .ipfirenew extension. And if the new config file does not differ from the currently installed one, the .ipfirenew-file is removed. The install-script will also issue warning messages if such .ipfirenew-files are left on the filesystem, requesting the user to manually investigate and possibly merge the configfile. I hope those warnings are visible in the pakfire output. A side effect is that the config files are also not removed when the package is uninstalled. I don't see a problem here for the zabbix own config-files. But it may pose a risk concerning the sudoers-file? - I added a few IPFire specific monitoring items to the agent config which can be used for more in-depth monitoring of the IPFire installation. The user is of course free to use my template available on share.zabbix.com or github to monitor those items, or create their own template. Thanks for considering this patch-set. Please be honest but gentle commenting on it :-). Regards Robin