From patchwork Tue Mar 30 15:28:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robin Roevens X-Patchwork-Id: 4000 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4F8tdb4CBQz3ws3 for ; Tue, 30 Mar 2021 15:28:51 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4F8tdZ4KnVz1TL; Tue, 30 Mar 2021 15:28:50 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4F8tdZ3YKyz2xSG; Tue, 30 Mar 2021 15:28:50 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4F8tdX4bHZz2xSG for ; Tue, 30 Mar 2021 15:28:48 +0000 (UTC) Received: from knopi.disroot.org (knopi.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail01.ipfire.org (Postfix) with ESMTPS id 4F8tdW4RqDzZ0 for ; Tue, 30 Mar 2021 15:28:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 80A3B50CEE for ; Tue, 30 Mar 2021 17:28:46 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nETZXMn7Hctr for ; Tue, 30 Mar 2021 17:28:45 +0200 (CEST) Received: from amaterasu.sicho.home ([192.168.0.1] helo=chojin.sicho.home) by filekeeper.sicho.home with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1lRGIE-00046g-A4 for development@lists.ipfire.org; Tue, 30 Mar 2021 17:28:34 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1617118123; bh=jqOPPeweg0FqvFCiScYXmeIktHim5sTI0nuNU3dAYQ4=; h=From:To:Subject:Date; b=G5iYbmk3/67vH3oSh7cwaKZsVZGJdMNEocYexeiDj7zcwH2nc0657+OuFTsr1s8bF lX29Gau3Oxwzy/q/WVhMu9mw6TOgRWmTjWYQl6gYL12WFSmZfmj8gU1BMDoWItI646 zd44aTc/9uZeyIhRDkvNCE8gvNkqXBjlfehikjhnT+XoGMNbBtH+RSpdShB9pRJr+1 bBMTYyTPJ0h76PjECR7Qk1DWN+zTt5w2IjAr/WRdGd3Ls302x5j8I7K5981HuU3+wu OR58Gxe99UMPtTznKuZzGkkdOJ0Qvq5b6VB6dl2Jy4OBhln/SbGXjq/x2tG3M2V9E4 qYZuuWqTdix1Q== From: Robin Roevens To: development@lists.ipfire.org Subject: [PATCH 0/4] zabbix_agentd: new maintainer/summary Date: Tue, 30 Mar 2021 17:28:26 +0200 Message-Id: <20210330152830.2859-1-robin.roevens@disroot.org> Mime-Version: 1.0 X-filekeeper-MailScanner-ID: 1lRGIE-00046g-A4 X-filekeeper-MailScanner: Found to be clean X-filekeeper-MailScanner-From: robin.roevens@disroot.org X-filekeeper-MailScanner-Watermark: 1617722916.2095@BlZhmmvpL2mHJukBQDcymw ARC-Authentication-Results: i=1; mail01.ipfire.org; dkim=pass header.d=disroot.org header.s=mail header.b=G5iYbmk3; spf=pass (mail01.ipfire.org: domain of robin.roevens@disroot.org designates 178.21.23.139 as permitted sender) smtp.mailfrom=robin.roevens@disroot.org ARC-Seal: i=1; s=202003rsa; d=lists.ipfire.org; t=1617118127; a=rsa-sha256; cv=none; b=s2bWppBiyR2GPoI61DOVYLPrErF2h0gB6xOInSprNJQU7Tqm65gbruZ+e8IczVU1NQfmeP mPxfojlLXLHeD6KxYyjBu8IWWpQH3ne2Bnzs7QdvCnfNw3MK702+mCzcsyTn5xSlwbQawe jeNwGOmMwB+tRHi5FVAdNN5+GlKNH6cH7vwls2hMHK2NXzicD+9HWaqzOqEe4mjRN1Iih2 m11gPHPZNfHHyMyDenfN2g47UVdnK13vT2T4wC7Co5vUJJ66T4wiPvssn2oSj7X0lWoG6o 6OYTalL0KjKsi0mT+Iu3Q/3lnBf19T7J8nHvLffxBhYodOWi7LL3JzpRc5zP+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.ipfire.org; s=202003rsa; t=1617118127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:dkim-signature; bh=ZkUPqP5VDIuv+PPa/vZqJtMN0rbFsqHNOX6A5dD2j0o=; b=YprRn4pKDASmE81WwGDXJT11DjAstwesFd78m6Lugy0vdVnbQ6ZNyaFh1bFCXWi9StViSx KPQsrORfl+4BwepT1qr7PlHRcUUHICU+tb5MTBgsSQf5VVbVROKNaRnJNsG7B6awEt0YyB hmpqmyjA5p8Yxqo+AW5RAszxyX8NXXtfIbN7LfgoDvg5or88KC9QnLoPZxDlatPIMOstyQ /oudzuM+lmy4MLUEIuiEtdqROAlTjSPxImKYYsWC+p13NSWv9avoJQK3KORixCClWS+7Fo y8VAMw/tTEkKxJtYZ7Tfn9CgQJlBeWz0n9GB3qMYaGcR9QdjwHOGLhHpGqWDZw== Authentication-Results: mail01.ipfire.org; dkim=pass header.d=disroot.org header.s=mail header.b=G5iYbmk3; dmarc=pass (policy=quarantine) header.from=disroot.org; spf=pass (mail01.ipfire.org: domain of robin.roevens@disroot.org designates 178.21.23.139 as permitted sender) smtp.mailfrom=robin.roevens@disroot.org X-Rspamd-Server: mail01.haj.ipfire.org X-Spamd-Result: default: False [2.42 / 11.00]; ARC_NA(0.00)[]; R_SPF_ALLOW(-0.20)[+a]; R_DKIM_ALLOW(-0.20)[disroot.org:s=mail]; FROM_HAS_DN(0.00)[]; MV_CASE(0.50)[]; R_MISSING_CHARSET(2.50)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[development@lists.ipfire.org]; BROKEN_CONTENT_TYPE(1.50)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[4]; TO_DN_NONE(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[disroot.org:+]; DMARC_POLICY_ALLOW(-0.50)[disroot.org,quarantine]; MID_CONTAINS_FROM(1.00)[]; IP_REPUTATION_HAM(-0.01)[asn: 50673(0.00), country: NL(-0.01), ip: 178.21.23.139(0.00)]; ARC_SIGNED(0.00)[lists.ipfire.org:s=202003rsa:i=1]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:50673, ipnet:178.21.23.0/24, country:NL]; BAYES_HAM(-2.07)[95.45%] X-Rspamd-Queue-Id: 4F8tdW4RqDzZ0 X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: development-bounces@lists.ipfire.org Sender: "Development" Hi all With this my first submission into the IPFire Project and my implicit confirmation that I will now be the new maintainer of the zabbix-agentd addon package. I currently choose to only release LTS versions of the Zabbix agent as those should contain less bugs and/or security issues in the long term. This set of patches does not only update the binaries (well, the first patch only does that) but also fixes some things that I see as problematic in previous version: - /usr/lib/zabbix is created for users to drop custom agent modules in, however that dir was removed and recreated on update as it was not in the backup. I added it to the backup and prevented deletion of the directory if it is not empty upon uninstall, so user-added content would not disapear when the package is removed. - Sometimes a new version of the agent will introduce new configuration parameters. In general the Zabbix Agent config file(s) should remain compatible, but we never know what the future will bring us; and the user may miss out on new features introduced with new parameters in the config file. However we don't want to plain overwrite the configfile as the user may (probably has) have changed it. Currently on upgrade configfiles are backed up, removed, new are installed, then overwritten by the old ones from the backup. Ending with the old config and the new agent. I didn't find an example of another package doing something similar, so I chose to save the new configfile(s) as .ipfirenew-files like RPM-based distro's do with .rpmnew-files. If the original config file is absent the install script will automatically strip the .ipfirenew extension. And if the new config file does not differ from the currently installed one, the .ipfirenew-file is removed. The install-script will also issue warning messages if such .ipfirenew-files are left on the filesystem, requesting the user to manually investigate and possibly merge the configfile. I hope those warnings are visible in the pakfire output. A side effect is that the config files are also not removed when the package is uninstalled. I don't see a problem here for the zabbix own config-files. But it may pose a risk concerning the sudoers-file? - I added a few IPFire specific monitoring items to the agent config which can be used for more in-depth monitoring of the IPFire installation. The user is of course free to use my template available on share.zabbix.com or github to monitor those items, or create their own template. Thanks for considering this patch-set. Please be honest but gentle commenting on it :-). Regards Robin