From patchwork Thu Feb 15 06:35:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernhard Held X-Patchwork-Id: 1664 Return-Path: Received: from mail01.ipfire.org (mail01.ipfire.org [IPv6:2001:470:7183:25::1]) by web02.i.ipfire.org (Postfix) with ESMTP id 1D4B160C10 for ; Wed, 14 Feb 2018 20:36:00 +0100 (CET) X-Virus-Scanned: ClamAV at mail01.ipfire.org Received: from mail01.i.ipfire.org (localhost [IPv6:::1]) by mail01.ipfire.org (Postfix) with ESMTP id CA570108C3BD; Wed, 14 Feb 2018 19:36:04 +0000 (GMT) Authentication-Results: mail01.ipfire.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: mail01.ipfire.org; spf=pass smtp.mailfrom=development-bounces@lists.ipfire.org X-Virus-Scanned: ClamAV at mail01.ipfire.org Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-2" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 39874105FC88 for ; Wed, 14 Feb 2018 19:35:53 +0000 (GMT) Authentication-Results: mail01.ipfire.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: mail01.ipfire.org; spf=pass smtp.mailfrom=berny156@gmx.de Received: from quad.berny.local ([46.244.233.56]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MCLQ1-1ev9Wc03nt-009AUL for ; Wed, 14 Feb 2018 20:35:31 +0100 From: Bernhard Held To: development@lists.ipfire.org Subject: [PATCH v3 0/4] proxy.cgi fixes for bugzilla #10852 Date: Wed, 14 Feb 2018 20:35:18 +0100 Message-Id: <20180214193522.26880-1-berny156@gmx.de> X-Mailer: git-send-email 2.16.1 X-Provags-ID: V03:K0:GaYdVseQHzC/ZK+uzSY/ia2Hosh/8kGkXU95CrErRbLXhnmSRjZ yQFFmu7jlm72py/NztNKUbPAA3MjQw+8VKAKeUIiUSlkBm0uuj6Yyi35sIrHdMOmlLYhDq1 a9JYvMIwroWwzEktTcMQK08352exXXHGWCC5JCo/Ov5+An36gwRKobHAYAiqlProzvI2VcK sRCJoeO/suiNHEojAXs4w== X-UI-Out-Filterresults: notjunk:1; V01:K0:iLpe2rZCZxI=:THr8VsDKjFCd5d1qigaEH7 RPyLzx+8HasDQtiDPSE8Q860tk6E/f4DfwkzapKe6Y0mjBffpZT7iFAeIv8pOBvqdKJQa8Bt8 yykRQ6I3Jm2FCc4yov+NQ1J5rejxxwl/SggZRvSGazk+EVSADvBE/T5csU+5/jvpKG2eglbq1 3GNh8gncVXt/+fzGDKq/QxyiP/6xoeH0Um87cvrfs0S5jl9pDdQnMrIoJcsOhk0+Tj/9TbH2W GDVu0VxGnQ/gmXu3avD0B/PmeA3ingSg6MFIkcGHNQYndA9wS1vG40EXxuALGjROLGQ+Q6KAV sTqQu3spQbpyoaS1uaTMpsqF4hM89zzDzkQGbhUWGe5M2wj1UVRRhCSBoBFZTahII2n2CLJ0F tIxIsu23d/ajbNhzzI9L0S0I+xwCdaqj8yNoAEVV2sTg2ooOQX47pDdY8lJVudJ1SGb8lsC8K qH8sTtm3WISPw0WqvT8tzhg5Zg3kg91le04TbfoiJFC9hZHPNAYmA82Q2JylY0tzaNfrnuTD1 sKZ02DizpYk4S630RR7U8phQEobEZ3MLYfnpK+lj0LML7Ga+tBWGEN4Wl9E1dXXwwoOP80lnk m6r1rZDQDnUXjRN5VizfmxnrX+f3KEuQRJRiZShm3Df350wPVg2buAKYxcxNlBXRvis41zYM1 uJq4/vBNR4gdublZimDNbESItOVFCKyoIb4CGjYBJFb9yt9It1rXwcfj59mQRse1ezD/z8PYF MzDmRd/O9yvfuMONTl+/sa1Wd5VRRGeWh3IPYm7nM9rXyojQY+TUYfmRIcSQQLkiTosYjubHr 0eOwnkGIvRp9GCFUYUdTgc92hbhww== X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: IPFire development talk List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: development-bounces@lists.ipfire.org Sender: "Development" v2 -> v3 - Network::network2bin: use 'return ();' instead of plain 'return;' - Network::network_qual: fix identation problem - proxy.cgi::writepacfile: use 'chomp(@templist);' once before loop v1 -> v2 - Network::network_qual: Improved check if array is fully defined. Honestly, the testsuite of the unpatched file still fails on my IPFire for an unknown reason. The patches fixe the issue for me using perl v5.12.3 as well as v5.26.1. - Network::network2bin: 'return undef;' doesn't return an empty list causing lots of headaches. Popular sites strongly recommend to use 'return;' instead of 'return undef;'. Maybe 'return undef;' should be avoided everywhere in IPFire. Have fun, Bernhard