From patchwork Tue Feb 13 09:19:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernhard Held X-Patchwork-Id: 1655 Return-Path: Received: from mail01.ipfire.org (unknown [172.28.1.200]) by web02.i.ipfire.org (Postfix) with ESMTP id B6564602CB for ; Mon, 12 Feb 2018 23:20:02 +0100 (CET) X-Virus-Scanned: ClamAV at mail01.ipfire.org Received: from mail01.i.ipfire.org (localhost [IPv6:::1]) by mail01.ipfire.org (Postfix) with ESMTP id DDEDD1140A37; Mon, 12 Feb 2018 22:20:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 mail01.ipfire.org DDEDD1140A37 Authentication-Results: mail01.ipfire.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: mail01.ipfire.org; spf=pass smtp.mailfrom=development-bounces@lists.ipfire.org X-Virus-Scanned: ClamAV at mail01.ipfire.org Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-2" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 6BA251140A3A for ; Mon, 12 Feb 2018 22:19:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 mail01.ipfire.org 6BA251140A3A Authentication-Results: mail01.ipfire.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: mail01.ipfire.org; spf=pass smtp.mailfrom=berny156@gmx.de Received: from quad.berny.local ([46.244.228.114]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LqiJO-1eG89z0VCk-00eIhs for ; Mon, 12 Feb 2018 23:19:37 +0100 From: Bernhard Held To: development@lists.ipfire.org Subject: [PATCH v2 0/4] proxy.cgi fixes for bugzilla #10852 Date: Mon, 12 Feb 2018 23:19:28 +0100 Message-Id: <20180212221932.29122-1-berny156@gmx.de> X-Mailer: git-send-email 2.16.1 X-Provags-ID: V03:K0:krWBtNQo8xsbRkh3By3YHKAKPahvKTu/VQRos0l4e8ioqiX5w9E NZm353vkRKaHiLJJFGa/djDB1G/6zFkQFlOcX3bh60bTwuzjHiVmD2BGy26ADIAlsPyamdG sZE5o+wiLKvB7F29Za3QYPjcc40cjMmbb+4lwRIGsbhyowbVcebfrIRqsJosT3uQTXBtsxu 2M2YfhWCd0hKC7JicgbYQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:59C3Q2qrA8I=:92S6wGYNMdLcC2jn+MwY/K 655HtAnpkwA9uZPSQoCq8c0qQh6GJjTWhGLVYU80oUA4I01x2fc48uXgOeJhya0yroPFUDFbs 2sHid1iDH4SAGKSnvLYbTLZcNUq3zwejWnyEuK/U9DJs54/nA9aDXEWGe7vzuxuMBCo0RV8xN CUKlKYsVixxUzQNlV3sLiW8LFofaeTN/Ps08V8ATAM2AEmPrXqsD2Bkl2MXilbjgGr4mfRdpA MUDMU8BMBDOdBshSZ2Hxk+EvxiJIOc3U91Z4n9QaB/mT7huCSezNA7THSumtGRlKDTwo7Z/mj Ueil28q3IAmigS7dR1HvkOvEcV5Hryz2SyWbPMN4xtZ2QWdnyIzPN+hGFQcDvLsFY0u14K2Dn fiI3G2LK3kTJAVZcwduPCSs5bWgMNGU5b7XzmsiibZ9J5EYwnTPywOfA7DFUYjyv4d53CdhuK 26GdXcrMm4mt+5M8T0azRm3lsIqytlY8IiGTt78hxC60CGYdJEEWVocMUog6zFzg6Xu7BMEnO XO2tQ1UxXv6ZBiWwO7wnUC7kSXKYcTMCqxpfOgxtVTkNjmKHjAeu9tHrA0kOt3aI6W8vJITs2 8EFseXm4VvIk3TSdgFtrbqFuYWLeIbmY1DrqlOu01geiz57OJTLYEAlwhUE60NIv/MlRyly1e 9EI7ER+iFYWmco0pvb4iuDOwHQE/Bp62ALiWPOtsgmkc2WEuQn6SBYffTMQ6ez02rYkX/Gf7V YHALs69+tTn55hmD2YK1ib0SaPohDkZOlIZU1EWPXXtE1/cbOjszSB2YS47ZwMBxo1F/Drg3M Cc0NoCk8oyPOr1WEjmR5aK3AZXVMg== X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: IPFire development talk List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: development-bounces@lists.ipfire.org Sender: "Development" v2 with following changes: Network::network_qual: Improved check if array is fully defined. Honestly, the testsuite of the unpatched file still fails on my IPFire for an unknown reason. The patches fixe the issue for me using perl v5.12.3 as well as v5.26.1. Network::network2bin: 'return undef;' doesn't return an empty list causing lots of headaches. Popular sites strongly recommend to use 'return;' instead of 'return undef;'. Maybe 'return undef;' should be avoided everywhere in IPFire. Have fun, Bernhard