From patchwork Tue Oct 8 08:37:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tremer X-Patchwork-Id: 2486 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 46nW1T0pSFz3yqX for ; Tue, 8 Oct 2019 08:37:17 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail02.haj.ipfire.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 46nW1S5V2kz2jb; Tue, 8 Oct 2019 08:37:16 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 46nW1S37Z5z2xxx; Tue, 8 Oct 2019 08:37:16 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 46nW1R44qwz2yBP for ; Tue, 8 Oct 2019 08:37:15 +0000 (UTC) Received: from michael.haj.ipfire.org (fw01.haj.ipfire.org [172.28.1.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) by mail01.ipfire.org (Postfix) with ESMTPSA id 46nW1R20fLz2Lb; Tue, 8 Oct 2019 08:37:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=201909rsa; t=1570523835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=tuMRbtLekI/8NinBnLXJwufX4/2mNPW/voMQEENcYZE=; b=JXyaA8/EDBElA88LUS9gZfftM/MpJPUt1eJR/Pfh7JnzhYhkwnX2/M0uj4JvUoAobsPiDc VsUtlsQDZ6kKRimPEyBFXpT5dZXm3AwmlKkJ/mlt8cras18gDx975dxGYCOqrGHJ9H+p/y ZSRWYRNHFXVOAdYj7UwRdGzqLSHPeTBepXtSppHcnA5+UQOEz2mgH+GHwdF/pMRDHU+v/B 6sm9zmrwWeHfgJFtbmNYwwbjXGLAVyHrP6PBtcy9LnnPxGh55hM129qqdBC5iBUC36oJvd n5yk/3NM3i8nX8K/w9s4SY+3wKRpx7LDHC/vjkQd/8x23dGYmsnDfSpoUl6+Qg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=201909ed25519; t=1570523835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=tuMRbtLekI/8NinBnLXJwufX4/2mNPW/voMQEENcYZE=; b=tEi56t2H8UZ1wxtpMirPDlLcpoESvjJymDOeTAHqsGn0WyC5w9g4s7kc51B2dAy575Rt4a ggt4CjmcHF4UYVAg== From: Michael Tremer To: ddns@lists.ipfire.org Subject: [PATCH] Use HTTPS for checkip{6,4}.dns.lightningwirelabs.com Date: Tue, 8 Oct 2019 08:37:06 +0000 Message-Id: <20191008083706.5120-1-michael.tremer@ipfire.org> MIME-Version: 1.0 X-BeenThere: ddns@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List for the IPFire dynamic DNS client List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ddns-bounces@lists.ipfire.org Sender: "ddns" Since we are deploying a HSTS policy for lightningwirelabs.com now, and we generally only use HTTPS for everything, this patch changes this for the IP address discovery process, too. Signed-off-by: Michael Tremer --- src/ddns/system.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ddns/system.py b/src/ddns/system.py index 67ea553..b7a51f6 100644 --- a/src/ddns/system.py +++ b/src/ddns/system.py @@ -112,9 +112,9 @@ class DDNSSystem(object): def guess_external_ip_address(self, family, **kwargs): if family == "ipv6": - url = "http://checkip6.dns.lightningwirelabs.com" + url = "https://checkip6.dns.lightningwirelabs.com" elif family == "ipv4": - url = "http://checkip4.dns.lightningwirelabs.com" + url = "https://checkip4.dns.lightningwirelabs.com" else: raise ValueError("unknown address family")