[3/3] Only call radvd_update if a zone contains an IPv6.
Message ID | 20170125134821.15442-3-stefan.schantl@ipfire.org |
---|---|
State | Accepted |
Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (unknown [172.28.1.200]) by web02.ipfire.org (Postfix) with ESMTP id E153E620B2 for <patchwork@ipfire.org>; Wed, 25 Jan 2017 14:47:46 +0100 (CET) Received: from mail01.ipfire.org (localhost [IPv6:::1]) by mail01.ipfire.org (Postfix) with ESMTP id A0DA79F3; Wed, 25 Jan 2017 14:47:42 +0100 (CET) Received: from tuxedo.stevee (213162068239.public.t-mobile.at [213.162.68.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 3425A1065; Wed, 25 Jan 2017 14:47:29 +0100 (CET) From: Stefan Schantl <stefan.schantl@ipfire.org> To: development@lists.ipfire.org Subject: [PATCH 3/3] Only call radvd_update if a zone contains an IPv6. Date: Wed, 25 Jan 2017 14:48:21 +0100 Message-Id: <20170125134821.15442-3-stefan.schantl@ipfire.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170125134821.15442-1-stefan.schantl@ipfire.org> References: <20170125134821.15442-1-stefan.schantl@ipfire.org> X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <http://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <http://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Cc: network@lists.ipfire.org Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
Message
Stefan Schantl
Jan. 26, 2017, 12:48 a.m. UTC
On systems which lacks any IPv6 configured zone, radvd would be
started with an empty configuration file and crashes which will
brick the system startup and results in a frozen system.
Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
---
src/functions/functions.routing | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Comments
Please ignore this patch, it fixes the descibed issue on IPv4 only systems but there is another issue with IPv6 as well which requires more and deeper work to get this solved in a right way. Thanks in advance, -Stefan > On systems which lacks any IPv6 configured zone, radvd would be > started with an empty configuration file and crashes which will > brick the system startup and results in a frozen system. > > Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org> > --- > src/functions/functions.routing | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/functions/functions.routing > b/src/functions/functions.routing > index c7aac09..4824f34 100644 > --- a/src/functions/functions.routing > +++ b/src/functions/functions.routing > @@ -81,7 +81,9 @@ routing_default_update() { > routes=$(echo ${routes}) > > # Reload radvd configuration > - [[ "${proto}" = "ipv6" ]] && radvd_update > + if [[ "${proto}" = "ipv6" ]] && db_exists > "${zone}/ipv6"; then > + radvd_update > + fi > > # Remove all default routes. > if [ -z "${routes}" ]; then