mbox

[PATCHv2] Zoneedit: Provide better error message on error 702 responses.

Message ID 1461933302-24640-1-git-send-email-stefan.schantl@ipfire.org
State Accepted
Commit 15640d72ba670a32a76d15dcc1c3a4d45d160a7f
Headers

Message

Stefan Schantl April 29, 2016, 10:35 p.m. UTC 
  A returned error code 702 when using Zoneedit as provider now raise
a request error with an corresponding message instead of a simple
InternalServerError exception.

This will help to clarify and debug update problems.

Fixes #11042.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
---
 src/ddns/providers.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Tremer April 29, 2016, 10:36 p.m. UTC | #1 
Reviewed-by: Michael Tremer <michael.tremer@ipfire.org>

ACK

On Fri, 2016-04-29 at 14:35 +0200, Stefan Schantl wrote:
> A returned error code 702 when using Zoneedit as provider now raise
> a request error with an corresponding message instead of a simple
> InternalServerError exception.
> 
> This will help to clarify and debug update problems.
> 
> Fixes #11042.
> 
> Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
> ---
>  src/ddns/providers.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> index 3845193..c653aa5 100644
> --- a/src/ddns/providers.py
> +++ b/src/ddns/providers.py
> @@ -1576,7 +1576,7 @@ class DDNSProviderZoneedit(DDNSProvider):
>  		elif output.startswith("<ERROR CODE=\"704\""):
>  			raise DDNSRequestError(_("No valid FQDN was
> given.")) 
>  		elif output.startswith("<ERROR CODE=\"702\""):
> -			raise DDNSInternalServerError
> +			raise DDNSRequestError(_("Too frequent update
> requests have been sent."))
>  
>  		# If we got here, some other update error happened.
>  		raise DDNSUpdateError