diff mbox series

ddns add provider Feste-IP.NET

Message ID	9cac2a23-4575-4b06-d4d5-dc9c60ca65bb@posteo.de
State	Dropped
Headers	To: development@lists.ipfire.org From: Martin Krieger <makrie@posteo.de> Subject: ddns add provider Feste-IP.NET Message-ID: <9cac2a23-4575-4b06-d4d5-dc9c60ca65bb@posteo.de> Date: Wed, 5 May 2021 18:13:52 +0000 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Pb7sDe4t6RnQBsIVSIKDGTrjBxAHrQdVc" country: DE(-0.01), ip: 185.67.36.65(0.00)]; R_SPF_ALLOW(-0.20)[+ip4:185.67.36.0/23]; HAS_ATTACHMENT(0.00)[]; REPLYTO_ADDR_EQ_FROM(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; ARC_SIGNED(0.00)[lists.ipfire.org:s=202003rsa:i=1]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[posteo.de:+]; MX_GOOD(-0.01)[]; DMARC_POLICY_ALLOW(-0.50)[posteo.de,none]; RCVD_IN_DNSWL_MED(-0.20)[185.67.36.65:from]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+,3:~]; ASN(0.00)[asn:8495, ipnet:185.67.36.0/23, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; BAYES_HAM(-3.00)[99.98%]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[posteo.de:s=2017]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,multipart/mixed,text/plain]; PREVIOUSLY_DELIVERED(0.00)[development@lists.ipfire.org]; RCPT_COUNT_ONE(0.00)[1]; DWL_DNSWL_LOW(-1.00)[posteo.de:dkim]; RCVD_TLS_ALL(0.00)[] Precedence: list Reply-To: makrie@posteo.de Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org>
Series	ddns add provider Feste-IP.NET \| ddns add provider Feste-IP.NET

Commit Message

Martin Krieger May 5, 2021, 6:13 p.m. UTC

Comments

Michael Tremer May 5, 2021, 10:28 p.m. UTC | #1

Hello Martin,

Thank you very much for your submission.

> On 5 May 2021, at 19:13, Martin Krieger <makrie@posteo.de> wrote:
> 
> diff --git a/README b/README
> index b6decb3..fa6ce5e 100644
> --- a/README
> +++ b/README
> @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS:
>        easydns.com
>        enom.com
>        entrydns.net
> +       feste-ip.net
>        freedns.afraid.org
>        inwx.com|de|at|ch|es
>        itsdns.de
> diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> index 56e6620..c70423b 100644
> --- a/src/ddns/providers.py
> +++ b/src/ddns/providers.py
> @@ -1178,6 +1178,16 @@ class DDNSProviderEntryDNS(DDNSProvider):
>                # If we got here, some other update error happened.
>                raise DDNSUpdateError
> 
> +class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider):
> +        handle    = "feste-ip.net"
> +        name      = "Feste-IP.Net"
> +        website   = "https//www.feste-ip.net/"

You are missing a “:” in the URL.

> +        protocols = ("ipv4",)

According to this documentation, the provider supports IPv6 as well:

  https://www.feste-ip.net/ddns-service/einrichtung/linux/

> +        # Information about the format of the request is to be found
> +        # https://www.feste-ip.net/ddns-service/allgemeine-informationen/
> +
> +        url = "https://members.feste-ip.net/nic/update"
> 
> class DDNSProviderFreeDNSAfraidOrg(DDNSProvider):
>        handle    = “freedns.afraid.org"
> 

Best,
-Michael

Martin Krieger May 6, 2021, 10:21 a.m. UTC | #2

Hello Michael,

by eMail again, because I didn't figure out to use git (commit, 
format-patch & send-email) in the correct way for patch submission. Sorry.

Regards,

Martin Krieger

diff --git a/README b/README
index b6decb3..fa6ce5e 100644
--- a/README
+++ b/README
@@ -68,6 +68,7 @@ SUPPORTED PROVIDERS:
         easydns.com
         enom.com
         entrydns.net
+       feste-ip.net
         freedns.afraid.org
         inwx.com|de|at|ch|es
         itsdns.de
diff --git a/src/ddns/providers.py b/src/ddns/providers.py
index 56e6620..c53ff9a 100644
--- a/src/ddns/providers.py
+++ b/src/ddns/providers.py
@@ -1178,6 +1178,16 @@ class DDNSProviderEntryDNS(DDNSProvider):
                 # If we got here, some other update error happened.
                 raise DDNSUpdateError

+class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider):
+        handle    = "feste-ip.net"
+        name      = "Feste-IP.Net"
+        website   = "https://www.feste-ip.net/"
+        protocols = ("ipv4","ipv6")
+
+        # Information about the format of the request is to be found
+        # https://www.feste-ip.net/ddns-service/einrichtung/linux/
+
+        url = "https://members.feste-ip.net/nic/update"

  class DDNSProviderFreeDNSAfraidOrg(DDNSProvider):
         handle    = "freedns.afraid.org"

Michael Tremer:
> Hello Martin,
> 
> Thank you very much for your submission.
> 
>> On 5 May 2021, at 19:13, Martin Krieger <makrie@posteo.de> wrote:
>>
>> diff --git a/README b/README
>> index b6decb3..fa6ce5e 100644
>> --- a/README
>> +++ b/README
>> @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS:
>>         easydns.com
>>         enom.com
>>         entrydns.net
>> +       feste-ip.net
>>         freedns.afraid.org
>>         inwx.com|de|at|ch|es
>>         itsdns.de
>> diff --git a/src/ddns/providers.py b/src/ddns/providers.py
>> index 56e6620..c70423b 100644
>> --- a/src/ddns/providers.py
>> +++ b/src/ddns/providers.py
>> @@ -1178,6 +1178,16 @@ class DDNSProviderEntryDNS(DDNSProvider):
>>                 # If we got here, some other update error happened.
>>                 raise DDNSUpdateError
>>
>> +class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider):
>> +        handle    = "feste-ip.net"
>> +        name      = "Feste-IP.Net"
>> +        website   = "https//www.feste-ip.net/"
> 
> You are missing a “:” in the URL.
> 
>> +        protocols = ("ipv4",)
> 
> According to this documentation, the provider supports IPv6 as well:
> 
>    https://www.feste-ip.net/ddns-service/einrichtung/linux/
> 
>> +        # Information about the format of the request is to be found
>> +        # https://www.feste-ip.net/ddns-service/allgemeine-informationen/
>> +
>> +        url = "https://members.feste-ip.net/nic/update"
>>
>> class DDNSProviderFreeDNSAfraidOrg(DDNSProvider):
>>         handle    = “freedns.afraid.org"
>>
> 
> Best,
> -Michael
>

Michael Tremer May 6, 2021, 3:08 p.m. UTC | #3

Hello Martin,

> On 6 May 2021, at 11:21, Martin Krieger <makrie@posteo.de> wrote:
> 
> Hello Michael,
> 
> by eMail again, because I didn't figure out to use git (commit, format-patch & send-email) in the correct way for patch submission. Sorry.
> 
> Regards,
> 
> Martin Krieger
> 
> diff --git a/README b/README
> index b6decb3..fa6ce5e 100644
> --- a/README
> +++ b/README
> @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS:
>        easydns.com
>        enom.com
>        entrydns.net
> +       feste-ip.net
>        freedns.afraid.org
>        inwx.com|de|at|ch|es
>        itsdns.de
> diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> index 56e6620..c53ff9a 100644
> --- a/src/ddns/providers.py
> +++ b/src/ddns/providers.py
> @@ -1178,6 +1178,16 @@ class DDNSProviderEntryDNS(DDNSProvider):
>                # If we got here, some other update error happened.
>                raise DDNSUpdateError
> 
> +class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider):
> +        handle    = "feste-ip.net"
> +        name      = "Feste-IP.Net"
> +        website   = "https://www.feste-ip.net/"
> +        protocols = ("ipv4","ipv6")

According to the documentation, the request has to be sent to a different host for IPv6. Just adding it to the list probably won’t work because this provider has implemented a different way to use the DynDNS API.

> +        # Information about the format of the request is to be found
> +        # https://www.feste-ip.net/ddns-service/einrichtung/linux/
> +
> +        url = "https://members.feste-ip.net/nic/update"
> 
> class DDNSProviderFreeDNSAfraidOrg(DDNSProvider):
>        handle    = "freedns.afraid.org"
> 
> Michael Tremer:
>> Hello Martin,
>> Thank you very much for your submission.
>>> On 5 May 2021, at 19:13, Martin Krieger <makrie@posteo.de> wrote:
>>> 
>>> diff --git a/README b/README
>>> index b6decb3..fa6ce5e 100644
>>> --- a/README
>>> +++ b/README
>>> @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS:
>>>        easydns.com
>>>        enom.com
>>>        entrydns.net
>>> +       feste-ip.net
>>>        freedns.afraid.org
>>>        inwx.com|de|at|ch|es
>>>        itsdns.de
>>> diff --git a/src/ddns/providers.py b/src/ddns/providers.py
>>> index 56e6620..c70423b 100644
>>> --- a/src/ddns/providers.py
>>> +++ b/src/ddns/providers.py
>>> @@ -1178,6 +1178,16 @@ class DDNSProviderEntryDNS(DDNSProvider):
>>>                # If we got here, some other update error happened.
>>>                raise DDNSUpdateError
>>> 
>>> +class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider):
>>> +        handle    = "feste-ip.net"
>>> +        name      = "Feste-IP.Net"
>>> +        website   = "https//www.feste-ip.net/"
>> You are missing a “:” in the URL.
>>> +        protocols = ("ipv4",)
>> According to this documentation, the provider supports IPv6 as well:
>>   https://www.feste-ip.net/ddns-service/einrichtung/linux/
>>> +        # Information about the format of the request is to be found
>>> +        # https://www.feste-ip.net/ddns-service/allgemeine-informationen/
>>> +
>>> +        url = "https://members.feste-ip.net/nic/update"
>>> 
>>> class DDNSProviderFreeDNSAfraidOrg(DDNSProvider):
>>>        handle    = “freedns.afraid.org"
>>> 
>> Best,
>> -Michael
>

Martin Krieger May 8, 2021, 12:20 p.m. UTC | #4

Hello Michael,

unfortunately my actual Python knowledge is very basic. I found no 
solution to implement ipv6 in addition to ipv4. Also IPFire is based on 
ipv4 and will be there in future as far as I understood.

I adapted providers.py to force FesteIP.Net to use ipv4 according to the 
information on the homepage.

A test showed no issue:

ddns -d update --force ipfire.feste-ip.net

Running on distribution: ipfire-2
Loading configuration file /var/ipfire/ddns/ddns.conf
Updating ipfire.feste-ip.net forced
Sending request (GET): 
https://v4.members.feste-ip.net/nic/update/?hostname=ipfire.feste-ip.net&myip=5.63.50.246
Request header:
   Authorization: Basic MjA2MDA0Ol84UnN2bjZidDk=
   User-agent: IPFireDDNSUpdater/013
   Pragma: no-cache
Response header (Status Code 200):
   Date: Sat, 08 May 2021 12:01:04 GMT
   Content-Type: text/plain
   Connection: close
   Accept-Ranges: none
   Server: Feste-IP.net Server
   Strict-Transport-Security: max-age=15768000
Dynamic DNS update for ipfire.feste-ip.net (Feste-IP.Net) successful
Logging successful update for ipfire.feste-ip.net
Opening database /var/lib/ddns.db

So, from my point of view the patch should do the job.

Regards,

Martin Krieger

diff --git a/README b/README
index b6decb3..fa6ce5e 100644
--- a/README
+++ b/README
@@ -68,6 +68,7 @@ SUPPORTED PROVIDERS:
         easydns.com
         enom.com
         entrydns.net
+       feste-ip.net
         freedns.afraid.org
         inwx.com|de|at|ch|es
         itsdns.de
diff --git a/src/ddns/providers.py b/src/ddns/providers.py
index 56e6620..8348ed1 100644
--- a/src/ddns/providers.py
+++ b/src/ddns/providers.py
@@ -1178,6 +1178,17 @@ class DDNSProviderEntryDNS(DDNSProvider):
                 # If we got here, some other update error happened.
                 raise DDNSUpdateError

+class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider):
+        handle    = "feste-ip.net"
+        name      = "Feste-IP.Net"
+        website   = "https://www.feste-ip.net/"
+        protocols = ("ipv4",)
+
+        # Information about the format of the request is to be found
+        # https://www.feste-ip.net/ddns-service/einrichtung/linux/
+        # https://www.feste-ip.net/ddns-service/einrichtung/ipv4-ipv6/
+
+        url = "https://v4.members.feste-ip.net/nic/update"

  class DDNSProviderFreeDNSAfraidOrg(DDNSProvider):
         handle    = "freedns.afraid.org"

Michael Tremer:
> Hello Martin,
> 
>> On 6 May 2021, at 11:21, Martin Krieger <makrie@posteo.de> wrote:
>>
>> Hello Michael,
>>
>> by eMail again, because I didn't figure out to use git (commit, format-patch & send-email) in the correct way for patch submission. Sorry.
>>
>> Regards,
>>
>> Martin Krieger
>>
>> diff --git a/README b/README
>> index b6decb3..fa6ce5e 100644
>> --- a/README
>> +++ b/README
>> @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS:
>>         easydns.com
>>         enom.com
>>         entrydns.net
>> +       feste-ip.net
>>         freedns.afraid.org
>>         inwx.com|de|at|ch|es
>>         itsdns.de
>> diff --git a/src/ddns/providers.py b/src/ddns/providers.py
>> index 56e6620..c53ff9a 100644
>> --- a/src/ddns/providers.py
>> +++ b/src/ddns/providers.py
>> @@ -1178,6 +1178,16 @@ class DDNSProviderEntryDNS(DDNSProvider):
>>                 # If we got here, some other update error happened.
>>                 raise DDNSUpdateError
>>
>> +class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider):
>> +        handle    = "feste-ip.net"
>> +        name      = "Feste-IP.Net"
>> +        website   = "https://www.feste-ip.net/"
>> +        protocols = ("ipv4","ipv6")
> 
> According to the documentation, the request has to be sent to a different host for IPv6. Just adding it to the list probably won’t work because this provider has implemented a different way to use the DynDNS API.
> 
>> +        # Information about the format of the request is to be found
>> +        # https://www.feste-ip.net/ddns-service/einrichtung/linux/
>> +
>> +        url = "https://members.feste-ip.net/nic/update"
>>
>> class DDNSProviderFreeDNSAfraidOrg(DDNSProvider):
>>         handle    = "freedns.afraid.org"
>>
>> Michael Tremer:
>>> Hello Martin,
>>> Thank you very much for your submission.
>>>> On 5 May 2021, at 19:13, Martin Krieger <makrie@posteo.de> wrote:
>>>>
>>>> diff --git a/README b/README
>>>> index b6decb3..fa6ce5e 100644
>>>> --- a/README
>>>> +++ b/README
>>>> @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS:
>>>>         easydns.com
>>>>         enom.com
>>>>         entrydns.net
>>>> +       feste-ip.net
>>>>         freedns.afraid.org
>>>>         inwx.com|de|at|ch|es
>>>>         itsdns.de
>>>> diff --git a/src/ddns/providers.py b/src/ddns/providers.py
>>>> index 56e6620..c70423b 100644
>>>> --- a/src/ddns/providers.py
>>>> +++ b/src/ddns/providers.py
>>>> @@ -1178,6 +1178,16 @@ class DDNSProviderEntryDNS(DDNSProvider):
>>>>                 # If we got here, some other update error happened.
>>>>                 raise DDNSUpdateError
>>>>
>>>> +class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider):
>>>> +        handle    = "feste-ip.net"
>>>> +        name      = "Feste-IP.Net"
>>>> +        website   = "https//www.feste-ip.net/"
>>> You are missing a “:” in the URL.
>>>> +        protocols = ("ipv4",)
>>> According to this documentation, the provider supports IPv6 as well:
>>>    https://www.feste-ip.net/ddns-service/einrichtung/linux/
>>>> +        # Information about the format of the request is to be found
>>>> +        # https://www.feste-ip.net/ddns-service/allgemeine-informationen/
>>>> +
>>>> +        url = "https://members.feste-ip.net/nic/update"
>>>>
>>>> class DDNSProviderFreeDNSAfraidOrg(DDNSProvider):
>>>>         handle    = “freedns.afraid.org"
>>>>
>>> Best,
>>> -Michael
>>
>

Michael Tremer May 11, 2021, 9:44 a.m. UTC | #5

Hello Martin,

> On 8 May 2021, at 13:20, Martin Krieger <makrie@posteo.de> wrote:
> 
> Hello Michael,
> 
> unfortunately my actual Python knowledge is very basic. I found no solution to implement ipv6 in addition to ipv4. Also IPFire is based on ipv4 and will be there in future as far as I understood.

Currently IPFire 2 only supports IPv4, but that is not mean to stay for forever and ddns is used elsewhere, too.

> I adapted providers.py to force FesteIP.Net to use ipv4 according to the information on the homepage.

I do not think that it is a good idea to implement half a provider. Could you maybe contact them and ask them to integrate their custom API into ddns?

-Michael

> 
> A test showed no issue:
> 
> ddns -d update --force ipfire.feste-ip.net
> 
> Running on distribution: ipfire-2
> Loading configuration file /var/ipfire/ddns/ddns.conf
> Updating ipfire.feste-ip.net forced
> Sending request (GET): https://v4.members.feste-ip.net/nic/update/?hostname=ipfire.feste-ip.net&myip=5.63.50.246
> Request header:
>  Authorization: Basic MjA2MDA0Ol84UnN2bjZidDk=
>  User-agent: IPFireDDNSUpdater/013
>  Pragma: no-cache
> Response header (Status Code 200):
>  Date: Sat, 08 May 2021 12:01:04 GMT
>  Content-Type: text/plain
>  Connection: close
>  Accept-Ranges: none
>  Server: Feste-IP.net Server
>  Strict-Transport-Security: max-age=15768000
> Dynamic DNS update for ipfire.feste-ip.net (Feste-IP.Net) successful
> Logging successful update for ipfire.feste-ip.net
> Opening database /var/lib/ddns.db
> 
> So, from my point of view the patch should do the job.
> 
> Regards,
> 
> Martin Krieger
> 
> diff --git a/README b/README
> index b6decb3..fa6ce5e 100644
> --- a/README
> +++ b/README
> @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS:
>        easydns.com
>        enom.com
>        entrydns.net
> +       feste-ip.net
>        freedns.afraid.org
>        inwx.com|de|at|ch|es
>        itsdns.de
> diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> index 56e6620..8348ed1 100644
> --- a/src/ddns/providers.py
> +++ b/src/ddns/providers.py
> @@ -1178,6 +1178,17 @@ class DDNSProviderEntryDNS(DDNSProvider):
>                # If we got here, some other update error happened.
>                raise DDNSUpdateError
> 
> +class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider):
> +        handle    = "feste-ip.net"
> +        name      = "Feste-IP.Net"
> +        website   = "https://www.feste-ip.net/"
> +        protocols = ("ipv4",)
> +
> +        # Information about the format of the request is to be found
> +        # https://www.feste-ip.net/ddns-service/einrichtung/linux/
> +        # https://www.feste-ip.net/ddns-service/einrichtung/ipv4-ipv6/
> +
> +        url = "https://v4.members.feste-ip.net/nic/update"
> 
> class DDNSProviderFreeDNSAfraidOrg(DDNSProvider):
>        handle    = "freedns.afraid.org"
> 
> Michael Tremer:
>> Hello Martin,
>>> On 6 May 2021, at 11:21, Martin Krieger <makrie@posteo.de> wrote:
>>> 
>>> Hello Michael,
>>> 
>>> by eMail again, because I didn't figure out to use git (commit, format-patch & send-email) in the correct way for patch submission. Sorry.
>>> 
>>> Regards,
>>> 
>>> Martin Krieger
>>> 
>>> diff --git a/README b/README
>>> index b6decb3..fa6ce5e 100644
>>> --- a/README
>>> +++ b/README
>>> @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS:
>>>        easydns.com
>>>        enom.com
>>>        entrydns.net
>>> +       feste-ip.net
>>>        freedns.afraid.org
>>>        inwx.com|de|at|ch|es
>>>        itsdns.de
>>> diff --git a/src/ddns/providers.py b/src/ddns/providers.py
>>> index 56e6620..c53ff9a 100644
>>> --- a/src/ddns/providers.py
>>> +++ b/src/ddns/providers.py
>>> @@ -1178,6 +1178,16 @@ class DDNSProviderEntryDNS(DDNSProvider):
>>>                # If we got here, some other update error happened.
>>>                raise DDNSUpdateError
>>> 
>>> +class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider):
>>> +        handle    = "feste-ip.net"
>>> +        name      = "Feste-IP.Net"
>>> +        website   = "https://www.feste-ip.net/"
>>> +        protocols = ("ipv4","ipv6")
>> According to the documentation, the request has to be sent to a different host for IPv6. Just adding it to the list probably won’t work because this provider has implemented a different way to use the DynDNS API.
>>> +        # Information about the format of the request is to be found
>>> +        # https://www.feste-ip.net/ddns-service/einrichtung/linux/
>>> +
>>> +        url = "https://members.feste-ip.net/nic/update"
>>> 
>>> class DDNSProviderFreeDNSAfraidOrg(DDNSProvider):
>>>        handle    = "freedns.afraid.org"
>>> 
>>> Michael Tremer:
>>>> Hello Martin,
>>>> Thank you very much for your submission.
>>>>> On 5 May 2021, at 19:13, Martin Krieger <makrie@posteo.de> wrote:
>>>>> 
>>>>> diff --git a/README b/README
>>>>> index b6decb3..fa6ce5e 100644
>>>>> --- a/README
>>>>> +++ b/README
>>>>> @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS:
>>>>>        easydns.com
>>>>>        enom.com
>>>>>        entrydns.net
>>>>> +       feste-ip.net
>>>>>        freedns.afraid.org
>>>>>        inwx.com|de|at|ch|es
>>>>>        itsdns.de
>>>>> diff --git a/src/ddns/providers.py b/src/ddns/providers.py
>>>>> index 56e6620..c70423b 100644
>>>>> --- a/src/ddns/providers.py
>>>>> +++ b/src/ddns/providers.py
>>>>> @@ -1178,6 +1178,16 @@ class DDNSProviderEntryDNS(DDNSProvider):
>>>>>                # If we got here, some other update error happened.
>>>>>                raise DDNSUpdateError
>>>>> 
>>>>> +class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider):
>>>>> +        handle    = "feste-ip.net"
>>>>> +        name      = "Feste-IP.Net"
>>>>> +        website   = "https//www.feste-ip.net/"
>>>> You are missing a “:” in the URL.
>>>>> +        protocols = ("ipv4",)
>>>> According to this documentation, the provider supports IPv6 as well:
>>>>   https://www.feste-ip.net/ddns-service/einrichtung/linux/
>>>>> +        # Information about the format of the request is to be found
>>>>> +        # https://www.feste-ip.net/ddns-service/allgemeine-informationen/
>>>>> +
>>>>> +        url = "https://members.feste-ip.net/nic/update"
>>>>> 
>>>>> class DDNSProviderFreeDNSAfraidOrg(DDNSProvider):
>>>>>        handle    = “freedns.afraid.org"
>>>>> 
>>>> Best,
>>>> -Michael
>>> 
>

diff mbox series

Patch

diff --git a/README b/README
index b6decb3..fa6ce5e 100644
--- a/README
+++ b/README
@@ -68,6 +68,7 @@  SUPPORTED PROVIDERS:
         easydns.com
         enom.com
         entrydns.net
+       feste-ip.net
         freedns.afraid.org
         inwx.com|de|at|ch|es
         itsdns.de
diff --git a/src/ddns/providers.py b/src/ddns/providers.py
index 56e6620..c70423b 100644
--- a/src/ddns/providers.py
+++ b/src/ddns/providers.py
@@ -1178,6 +1178,16 @@  class DDNSProviderEntryDNS(DDNSProvider):
                 # If we got here, some other update error happened.
                 raise DDNSUpdateError

+class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider):
+        handle    = "feste-ip.net"
+        name      = "Feste-IP.Net"
+        website   = "https//www.feste-ip.net/"
+        protocols = ("ipv4",)
+
+        # Information about the format of the request is to be found
+        # https://www.feste-ip.net/ddns-service/allgemeine-informationen/
+
+        url = "https://members.feste-ip.net/nic/update"

  class DDNSProviderFreeDNSAfraidOrg(DDNSProvider):
         handle    = "freedns.afraid.org"