[1/4] httpd: remove compatibility instructions for very old browsers

Message ID 0b270dd5-9a61-2901-c75e-8698dd4373e8@ipfire.org
State Accepted
Commit a8996f857cda8bb5b11bf335eeb84cdad040b9b4
Headers
Series [1/4] httpd: remove compatibility instructions for very old browsers |

Commit Message

Peter Müller April 12, 2021, 9 p.m. UTC
  These are not in use any more - and if they would, we don't support them.

Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
---
 config/httpd/server-tuning.conf                 | 10 ----------
 config/httpd/vhosts.d/ipfire-interface-ssl.conf |  3 ---
 2 files changed, 13 deletions(-)
  

Comments

Michael Tremer April 14, 2021, 5:24 p.m. UTC | #1
Thank you. Excellent work.

> On 12 Apr 2021, at 22:00, Peter Müller <peter.mueller@ipfire.org> wrote:
> 
> These are not in use any more - and if they would, we don't support them.
> 
> Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
> ---
> config/httpd/server-tuning.conf                 | 10 ----------
> config/httpd/vhosts.d/ipfire-interface-ssl.conf |  3 ---
> 2 files changed, 13 deletions(-)
> 
> diff --git a/config/httpd/server-tuning.conf b/config/httpd/server-tuning.conf
> index 5642a1e44..9ee651e45 100644
> --- a/config/httpd/server-tuning.conf
> +++ b/config/httpd/server-tuning.conf
> @@ -22,13 +22,3 @@ MaxSpareThreads 20
> StartServers 2
> MaxRequestWorkers 256
> ThreadsPerChild 16
> -
> -#
> -# The following directives modify normal HTTP response behavior to
> -# handle known problems with browser implementations.
> -#
> -BrowserMatch "Mozilla/2" nokeepalive
> -BrowserMatch "MSIE 4\.0b2;" nokeepalive downgrade-1.0 force-response-1.0
> -BrowserMatch "RealPlayer 4\.0" force-response-1.0
> -BrowserMatch "Java/1\.0" force-response-1.0
> -BrowserMatch "JDK/1\.0" force-response-1.0
> diff --git a/config/httpd/vhosts.d/ipfire-interface-ssl.conf b/config/httpd/vhosts.d/ipfire-interface-ssl.conf
> index de7b8559d..8c4cf3806 100644
> --- a/config/httpd/vhosts.d/ipfire-interface-ssl.conf
> +++ b/config/httpd/vhosts.d/ipfire-interface-ssl.conf
> @@ -64,9 +64,6 @@
> 	SSLOptions +StdEnvVars
>     </Directory>
>     SetEnv HOME /home/nobody
> -    SetEnvIf User-Agent ".*MSIE.*" \
> -	nokeepalive ssl-unclean-shutdown \
> -	downgrade-1.0 force-response-1.0
>     CustomLog /var/log/httpd/ssl_request_log \
> 	"%t %h %{SSL_PROTOCOL}x %{SSL_CIPHER}x \"%r\" %b"
> 
> -- 
> 2.26.2
  

Patch

diff --git a/config/httpd/server-tuning.conf b/config/httpd/server-tuning.conf
index 5642a1e44..9ee651e45 100644
--- a/config/httpd/server-tuning.conf
+++ b/config/httpd/server-tuning.conf
@@ -22,13 +22,3 @@  MaxSpareThreads 20
 StartServers 2
 MaxRequestWorkers 256
 ThreadsPerChild 16
-
-#
-# The following directives modify normal HTTP response behavior to
-# handle known problems with browser implementations.
-#
-BrowserMatch "Mozilla/2" nokeepalive
-BrowserMatch "MSIE 4\.0b2;" nokeepalive downgrade-1.0 force-response-1.0
-BrowserMatch "RealPlayer 4\.0" force-response-1.0
-BrowserMatch "Java/1\.0" force-response-1.0
-BrowserMatch "JDK/1\.0" force-response-1.0
diff --git a/config/httpd/vhosts.d/ipfire-interface-ssl.conf b/config/httpd/vhosts.d/ipfire-interface-ssl.conf
index de7b8559d..8c4cf3806 100644
--- a/config/httpd/vhosts.d/ipfire-interface-ssl.conf
+++ b/config/httpd/vhosts.d/ipfire-interface-ssl.conf
@@ -64,9 +64,6 @@ 
 	SSLOptions +StdEnvVars
     </Directory>
     SetEnv HOME /home/nobody
-    SetEnvIf User-Agent ".*MSIE.*" \
-	nokeepalive ssl-unclean-shutdown \
-	downgrade-1.0 force-response-1.0
     CustomLog /var/log/httpd/ssl_request_log \
 	"%t %h %{SSL_PROTOCOL}x %{SSL_CIPHER}x \"%r\" %b"