diff mbox series

speedtest-cli: Fix for bug #12602 - CORE 155 error with speedtest-cli

Message ID 20210408203721.1735066-1-adolf.belka@ipfire.org
State Accepted
Headers
Series speedtest-cli: Fix for bug #12602 - CORE 155 error with speedtest-cli |

Commit Message

Adolf Belka April 8, 2021, 8:37 p.m. UTC 
  - Update from 2.1.2 to 2.1.3 - fix for bug #12602
   Updated addon installed and fix confirmed
- Update rootfile
- Changelog
    Address issue where a test server may return an HTTP error during upload or download
    Address issue where ignore_ids may be empty or have empty values

Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 config/rootfiles/packages/speedtest-cli | 13 +++++++------
 lfs/speedtest-cli                       |  6 +++---
 2 files changed, 10 insertions(+), 9 deletions(-)

Comments

Jon Murphy April 8, 2021, 9:10 p.m. UTC | #1 
I seem to remember a bug report for speedtest (besides #12602 below).  It had to do with this post:

https://community.ipfire.org/t/replace-speedtest-cli-with-speedtest-for-better-accuracy/3698 <https://community.ipfire.org/t/replace-speedtest-cli-with-speedtest-for-better-accuracy/3698>

I could not locate the bugzilla post.

Can speedtest be updated for this issue?


Jon


> On Apr 8, 2021, at 3:37 PM, Adolf Belka <adolf.belka@ipfire.org> wrote:
> 
> - Update from 2.1.2 to 2.1.3 - fix for bug #12602
>   Updated addon installed and fix confirmed
> - Update rootfile
> - Changelog
>    Address issue where a test server may return an HTTP error during upload or download
>    Address issue where ignore_ids may be empty or have empty values
> 
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
> config/rootfiles/packages/speedtest-cli | 13 +++++++------
> lfs/speedtest-cli                       |  6 +++---
> 2 files changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/config/rootfiles/packages/speedtest-cli b/config/rootfiles/packages/speedtest-cli
> index 0ef126e23..6632e235c 100644
> --- a/config/rootfiles/packages/speedtest-cli
> +++ b/config/rootfiles/packages/speedtest-cli
> @@ -1,9 +1,10 @@
> usr/bin/speedtest
> usr/bin/speedtest-cli
> usr/lib/python3.8/site-packages/speedtest.py
> -usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info
> -usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/PKG-INFO
> -usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/SOURCES.txt
> -usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/dependency_links.txt
> -usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/entry_points.txt
> -usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/top_level.txt
> +usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info
> +usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/PKG-INFO
> +usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/SOURCES.txt
> +usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/dependency_links.txt
> +usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/entry_points.txt
> +usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/top_level.txt
> +
> diff --git a/lfs/speedtest-cli b/lfs/speedtest-cli
> index 446844ab3..f6bcf4c96 100644
> --- a/lfs/speedtest-cli
> +++ b/lfs/speedtest-cli
> @@ -24,7 +24,7 @@
> 
> include Config
> 
> -VER        = 2.1.2
> +VER        = 2.1.3
> 
> THISAPP    = speedtest-cli-$(VER)
> DL_FILE    = $(THISAPP).tar.gz
> @@ -32,7 +32,7 @@ DL_FROM    = $(URL_IPFIRE)
> DIR_APP    = $(DIR_SRC)/$(THISAPP)
> TARGET     = $(DIR_INFO)/$(THISAPP)
> PROG       = speedtest-cli
> -PAK_VER    = 3
> +PAK_VER    = 4
> 
> DEPS       =
> 
> @@ -44,7 +44,7 @@ objects = $(DL_FILE)
> 
> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
> 
> -$(DL_FILE)_MD5 = a49ad088331810fc9442e8a5c59de713
> +$(DL_FILE)_MD5 = 08c431f2f398880745c4f0564962b9e2
> 
> install : $(TARGET)
> 
> -- 
> 2.31.1
>
<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">I seem to remember a bug report for speedtest (besides #12602 below). &nbsp;It had to do with this post:<div class=""><br class=""></div><div class=""><a href="https://community.ipfire.org/t/replace-speedtest-cli-with-speedtest-for-better-accuracy/3698" class="">https://community.ipfire.org/t/replace-speedtest-cli-with-speedtest-for-better-accuracy/3698</a></div><div class=""><br class=""></div><div class="">I could not locate the bugzilla post.</div><div class=""><br class=""></div><div class="">Can speedtest be updated for this issue?</div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">Jon</div><div class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Apr 8, 2021, at 3:37 PM, Adolf Belka &lt;<a href="mailto:adolf.belka@ipfire.org" class="">adolf.belka@ipfire.org</a>&gt; wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">- Update from 2.1.2 to 2.1.3 - fix for bug #12602<br class=""> &nbsp;&nbsp;Updated addon installed and fix confirmed<br class="">- Update rootfile<br class="">- Changelog<br class=""> &nbsp;&nbsp;&nbsp;Address issue where a test server may return an HTTP error during upload or download<br class=""> &nbsp;&nbsp;&nbsp;Address issue where ignore_ids may be empty or have empty values<br class=""><br class="">Signed-off-by: Adolf Belka &lt;<a href="mailto:adolf.belka@ipfire.org" class="">adolf.belka@ipfire.org</a>&gt;<br class="">---<br class=""> config/rootfiles/packages/speedtest-cli | 13 +++++++------<br class=""> lfs/speedtest-cli &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;| &nbsp;6 +++---<br class=""> 2 files changed, 10 insertions(+), 9 deletions(-)<br class=""><br class="">diff --git a/config/rootfiles/packages/speedtest-cli b/config/rootfiles/packages/speedtest-cli<br class="">index 0ef126e23..6632e235c 100644<br class="">--- a/config/rootfiles/packages/speedtest-cli<br class="">+++ b/config/rootfiles/packages/speedtest-cli<br class="">@@ -1,9 +1,10 @@<br class=""> usr/bin/speedtest<br class=""> usr/bin/speedtest-cli<br class=""> usr/lib/python3.8/site-packages/speedtest.py<br class="">-usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info<br class="">-usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/PKG-INFO<br class="">-usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/SOURCES.txt<br class="">-usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/dependency_links.txt<br class="">-usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/entry_points.txt<br class="">-usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/top_level.txt<br class="">+usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info<br class="">+usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/PKG-INFO<br class="">+usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/SOURCES.txt<br class="">+usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/dependency_links.txt<br class="">+usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/entry_points.txt<br class="">+usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/top_level.txt<br class="">+<br class="">diff --git a/lfs/speedtest-cli b/lfs/speedtest-cli<br class="">index 446844ab3..f6bcf4c96 100644<br class="">--- a/lfs/speedtest-cli<br class="">+++ b/lfs/speedtest-cli<br class="">@@ -24,7 +24,7 @@<br class=""><br class=""> include Config<br class=""><br class="">-VER &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;= 2.1.2<br class="">+VER &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;= 2.1.3<br class=""><br class=""> THISAPP &nbsp;&nbsp;&nbsp;= speedtest-cli-$(VER)<br class=""> DL_FILE &nbsp;&nbsp;&nbsp;= $(THISAPP).tar.gz<br class="">@@ -32,7 +32,7 @@ DL_FROM &nbsp;&nbsp;&nbsp;= $(URL_IPFIRE)<br class=""> DIR_APP &nbsp;&nbsp;&nbsp;= $(DIR_SRC)/$(THISAPP)<br class=""> TARGET &nbsp;&nbsp;&nbsp;&nbsp;= $(DIR_INFO)/$(THISAPP)<br class=""> PROG &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;= speedtest-cli<br class="">-PAK_VER &nbsp;&nbsp;&nbsp;= 3<br class="">+PAK_VER &nbsp;&nbsp;&nbsp;= 4<br class=""><br class=""> DEPS &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=<br class=""><br class="">@@ -44,7 +44,7 @@ objects = $(DL_FILE)<br class=""><br class=""> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)<br class=""><br class="">-$(DL_FILE)_MD5 = a49ad088331810fc9442e8a5c59de713<br class="">+$(DL_FILE)_MD5 = 08c431f2f398880745c4f0564962b9e2<br class=""><br class=""> install : $(TARGET)<br class=""><br class="">-- <br class="">2.31.1<br class=""><br class=""></div></div></blockquote></div><br class=""></div></body></html>
Adolf Belka April 8, 2021, 9:30 p.m. UTC | #2 
Hi Jon,

On 08/04/2021 23:10, Jon Murphy wrote:
> I seem to remember a bug report for speedtest (besides #12602 below).  It had to do with this post:
> 
> https://community.ipfire.org/t/replace-speedtest-cli-with-speedtest-for-better-accuracy/3698 <https://community.ipfire.org/t/replace-speedtest-cli-with-speedtest-for-better-accuracy/3698>
> 
> I could not locate the bugzilla post.
That is because the poster never raised it as a bug.
> 
> Can speedtest be updated for this issue?
I provided links to the addon creation process and how to submit a patch to the development list. He was going to build the patch for himself and then submit it to the development list for review. He never came back with a patch submission.

Regards,
Adolf
> 
> 
> Jon
> 
> 
>> On Apr 8, 2021, at 3:37 PM, Adolf Belka <adolf.belka@ipfire.org <mailto:adolf.belka@ipfire.org>> wrote:
>>
>> - Update from 2.1.2 to 2.1.3 - fix for bug #12602
>>   Updated addon installed and fix confirmed
>> - Update rootfile
>> - Changelog
>>    Address issue where a test server may return an HTTP error during upload or download
>>    Address issue where ignore_ids may be empty or have empty values
>>
>> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org <mailto:adolf.belka@ipfire.org>>
>> ---
>> config/rootfiles/packages/speedtest-cli | 13 +++++++------
>> lfs/speedtest-cli                       |  6 +++---
>> 2 files changed, 10 insertions(+), 9 deletions(-)
>>
>> diff --git a/config/rootfiles/packages/speedtest-cli b/config/rootfiles/packages/speedtest-cli
>> index 0ef126e23..6632e235c 100644
>> --- a/config/rootfiles/packages/speedtest-cli
>> +++ b/config/rootfiles/packages/speedtest-cli
>> @@ -1,9 +1,10 @@
>> usr/bin/speedtest
>> usr/bin/speedtest-cli
>> usr/lib/python3.8/site-packages/speedtest.py
>> -usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info
>> -usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/PKG-INFO
>> -usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/SOURCES.txt
>> -usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/dependency_links.txt
>> -usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/entry_points.txt
>> -usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/top_level.txt
>> +usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info
>> +usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/PKG-INFO
>> +usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/SOURCES.txt
>> +usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/dependency_links.txt
>> +usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/entry_points.txt
>> +usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/top_level.txt
>> +
>> diff --git a/lfs/speedtest-cli b/lfs/speedtest-cli
>> index 446844ab3..f6bcf4c96 100644
>> --- a/lfs/speedtest-cli
>> +++ b/lfs/speedtest-cli
>> @@ -24,7 +24,7 @@
>>
>> include Config
>>
>> -VER        = 2.1.2
>> +VER        = 2.1.3
>>
>> THISAPP    = speedtest-cli-$(VER)
>> DL_FILE    = $(THISAPP).tar.gz
>> @@ -32,7 +32,7 @@ DL_FROM    = $(URL_IPFIRE)
>> DIR_APP    = $(DIR_SRC)/$(THISAPP)
>> TARGET     = $(DIR_INFO)/$(THISAPP)
>> PROG       = speedtest-cli
>> -PAK_VER    = 3
>> +PAK_VER    = 4
>>
>> DEPS       =
>>
>> @@ -44,7 +44,7 @@ objects = $(DL_FILE)
>>
>> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>>
>> -$(DL_FILE)_MD5 = a49ad088331810fc9442e8a5c59de713
>> +$(DL_FILE)_MD5 = 08c431f2f398880745c4f0564962b9e2
>>
>> install : $(TARGET)
>>
>> -- 
>> 2.31.1
>>
>
Michael Tremer April 12, 2021, 10:38 a.m. UTC | #3 
Hello,

The user who reported this did not really make a case for why the client should be changed.

The Python client is working and still maintained, so I do not see any reason to change this.

-Michael

> On 8 Apr 2021, at 22:30, Adolf Belka <adolf.belka@ipfire.org> wrote:
> 
> Hi Jon,
> 
> On 08/04/2021 23:10, Jon Murphy wrote:
>> I seem to remember a bug report for speedtest (besides #12602 below).  It had to do with this post:
>> https://community.ipfire.org/t/replace-speedtest-cli-with-speedtest-for-better-accuracy/3698 <https://community.ipfire.org/t/replace-speedtest-cli-with-speedtest-for-better-accuracy/3698>
>> I could not locate the bugzilla post.
> That is because the poster never raised it as a bug.
>> Can speedtest be updated for this issue?
> I provided links to the addon creation process and how to submit a patch to the development list. He was going to build the patch for himself and then submit it to the development list for review. He never came back with a patch submission.
> 
> Regards,
> Adolf
>> Jon
>>> On Apr 8, 2021, at 3:37 PM, Adolf Belka <adolf.belka@ipfire.org <mailto:adolf.belka@ipfire.org>> wrote:
>>> 
>>> - Update from 2.1.2 to 2.1.3 - fix for bug #12602
>>>   Updated addon installed and fix confirmed
>>> - Update rootfile
>>> - Changelog
>>>    Address issue where a test server may return an HTTP error during upload or download
>>>    Address issue where ignore_ids may be empty or have empty values
>>> 
>>> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org <mailto:adolf.belka@ipfire.org>>
>>> ---
>>> config/rootfiles/packages/speedtest-cli | 13 +++++++------
>>> lfs/speedtest-cli                       |  6 +++---
>>> 2 files changed, 10 insertions(+), 9 deletions(-)
>>> 
>>> diff --git a/config/rootfiles/packages/speedtest-cli b/config/rootfiles/packages/speedtest-cli
>>> index 0ef126e23..6632e235c 100644
>>> --- a/config/rootfiles/packages/speedtest-cli
>>> +++ b/config/rootfiles/packages/speedtest-cli
>>> @@ -1,9 +1,10 @@
>>> usr/bin/speedtest
>>> usr/bin/speedtest-cli
>>> usr/lib/python3.8/site-packages/speedtest.py
>>> -usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info
>>> -usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/PKG-INFO
>>> -usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/SOURCES.txt
>>> -usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/dependency_links.txt
>>> -usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/entry_points.txt
>>> -usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/top_level.txt
>>> +usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info
>>> +usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/PKG-INFO
>>> +usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/SOURCES.txt
>>> +usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/dependency_links.txt
>>> +usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/entry_points.txt
>>> +usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/top_level.txt
>>> +
>>> diff --git a/lfs/speedtest-cli b/lfs/speedtest-cli
>>> index 446844ab3..f6bcf4c96 100644
>>> --- a/lfs/speedtest-cli
>>> +++ b/lfs/speedtest-cli
>>> @@ -24,7 +24,7 @@
>>> 
>>> include Config
>>> 
>>> -VER        = 2.1.2
>>> +VER        = 2.1.3
>>> 
>>> THISAPP    = speedtest-cli-$(VER)
>>> DL_FILE    = $(THISAPP).tar.gz
>>> @@ -32,7 +32,7 @@ DL_FROM    = $(URL_IPFIRE)
>>> DIR_APP    = $(DIR_SRC)/$(THISAPP)
>>> TARGET     = $(DIR_INFO)/$(THISAPP)
>>> PROG       = speedtest-cli
>>> -PAK_VER    = 3
>>> +PAK_VER    = 4
>>> 
>>> DEPS       =
>>> 
>>> @@ -44,7 +44,7 @@ objects = $(DL_FILE)
>>> 
>>> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>>> 
>>> -$(DL_FILE)_MD5 = a49ad088331810fc9442e8a5c59de713
>>> +$(DL_FILE)_MD5 = 08c431f2f398880745c4f0564962b9e2
>>> 
>>> install : $(TARGET)
>>> 
>>> -- 
>>> 2.31.1
>>>
diff mbox series

Patch

diff --git a/config/rootfiles/packages/speedtest-cli b/config/rootfiles/packages/speedtest-cli
index 0ef126e23..6632e235c 100644
--- a/config/rootfiles/packages/speedtest-cli
+++ b/config/rootfiles/packages/speedtest-cli
@@ -1,9 +1,10 @@ 
 usr/bin/speedtest
 usr/bin/speedtest-cli
 usr/lib/python3.8/site-packages/speedtest.py
-usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info
-usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/PKG-INFO
-usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/SOURCES.txt
-usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/dependency_links.txt
-usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/entry_points.txt
-usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/top_level.txt
+usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info
+usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/PKG-INFO
+usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/SOURCES.txt
+usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/dependency_links.txt
+usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/entry_points.txt
+usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/top_level.txt
+
diff --git a/lfs/speedtest-cli b/lfs/speedtest-cli
index 446844ab3..f6bcf4c96 100644
--- a/lfs/speedtest-cli
+++ b/lfs/speedtest-cli
@@ -24,7 +24,7 @@ 
 
 include Config
 
-VER        = 2.1.2
+VER        = 2.1.3
 
 THISAPP    = speedtest-cli-$(VER)
 DL_FILE    = $(THISAPP).tar.gz
@@ -32,7 +32,7 @@  DL_FROM    = $(URL_IPFIRE)
 DIR_APP    = $(DIR_SRC)/$(THISAPP)
 TARGET     = $(DIR_INFO)/$(THISAPP)
 PROG       = speedtest-cli
-PAK_VER    = 3
+PAK_VER    = 4
 
 DEPS       =
 
@@ -44,7 +44,7 @@  objects = $(DL_FILE)
 
 $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
 
-$(DL_FILE)_MD5 = a49ad088331810fc9442e8a5c59de713
+$(DL_FILE)_MD5 = 08c431f2f398880745c4f0564962b9e2
 
 install : $(TARGET)