dhcpcd: Update to 9.1.3

Message ID 20200702204305.30711-1-matthias.fischer@ipfire.org
State Superseded
Headers
Series dhcpcd: Update to 9.1.3 |

Commit Message

Matthias Fischer July 2, 2020, 8:43 p.m. UTC
  For details see:
https://roy.marples.name/blog/dhcpcd-9-1-3-released.html

    "configure: Fix fallout with disabling embedded config
    inet6: Add support for reporting Mobile IPv6 RA's
    inet6: Report RA Proxy flag if set
    BSD: Allow non NetBSD and OpenBSD to set IN6_IFF_AUTOCONF
    privsep: Don't handle any signals meant for the main process
    eloop: Try and survive a signal storm
    configure: add --with-eghook=foo
    dhcpcd: Add an option to poll the interface carrier state
    script: Make visible some link level parameters to lease dumping
    Linux: ignore unsupported interfaces by default, such as sit0
    Linux: support aarch64 for reading cpu info
    Linux: keep the generic netlink socket around to get ssid with privsep
    Linux: restore fix when no address is returned by getifaddrs(3)
    inet6: Don't regen temp addresses we didn't add
    privsep: Don't limit file writes if logging to a file
    DHCP6: Fix lease timings with nodelay option"

Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org>
---
 lfs/dhcpcd | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Michael Tremer July 3, 2020, 9:37 a.m. UTC | #1
Reviewed-by: Michael Tremer <michael.tremer@ipfire.org>

Very interesting how much you can develop around a simple DHCP client :)

> On 2 Jul 2020, at 21:43, Matthias Fischer <matthias.fischer@ipfire.org> wrote:
> 
> For details see:
> https://roy.marples.name/blog/dhcpcd-9-1-3-released.html
> 
>    "configure: Fix fallout with disabling embedded config
>    inet6: Add support for reporting Mobile IPv6 RA's
>    inet6: Report RA Proxy flag if set
>    BSD: Allow non NetBSD and OpenBSD to set IN6_IFF_AUTOCONF
>    privsep: Don't handle any signals meant for the main process
>    eloop: Try and survive a signal storm
>    configure: add --with-eghook=foo
>    dhcpcd: Add an option to poll the interface carrier state
>    script: Make visible some link level parameters to lease dumping
>    Linux: ignore unsupported interfaces by default, such as sit0
>    Linux: support aarch64 for reading cpu info
>    Linux: keep the generic netlink socket around to get ssid with privsep
>    Linux: restore fix when no address is returned by getifaddrs(3)
>    inet6: Don't regen temp addresses we didn't add
>    privsep: Don't limit file writes if logging to a file
>    DHCP6: Fix lease timings with nodelay option"
> 
> Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org>
> ---
> lfs/dhcpcd | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lfs/dhcpcd b/lfs/dhcpcd
> index c5a2c1a25..cdec5b5fa 100644
> --- a/lfs/dhcpcd
> +++ b/lfs/dhcpcd
> @@ -24,7 +24,7 @@
> 
> include Config
> 
> -VER        = 9.1.2
> +VER        = 9.1.3
> 
> THISAPP    = dhcpcd-$(VER)
> DL_FILE    = $(THISAPP).tar.xz
> @@ -40,7 +40,7 @@ objects = $(DL_FILE)
> 
> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
> 
> -$(DL_FILE)_MD5 = 96fc03f0b57e85a2dca2854bf2ff762d
> +$(DL_FILE)_MD5 = 27050a48f547200fb6a8da35c67c6d97
> 
> install : $(TARGET)
> 
> -- 
> 2.18.0
>
  
Matthias Fischer July 3, 2020, 4:09 p.m. UTC | #2
Hi,

On 03.07.2020 11:37, Michael Tremer wrote:
> Reviewed-by: Michael Tremer <michael.tremer@ipfire.org>
> 
> Very interesting how much you can develop around a simple DHCP client :)
> 
...
And guess what? 9.3.4 is out.

Please don't merge...the next patch is on his way.  *sigh*

Best,
Matthias
  
Michael Tremer July 4, 2020, 9:32 a.m. UTC | #3
Hi,

So since there is a lot of releases, can we come up with some sort of regular update cycle?

I do not think it makes sense to build every single release, because there will always be another one. Should we limit ourselves to about one a month or something like that?

-Michael

> On 3 Jul 2020, at 17:09, Matthias Fischer <matthias.fischer@ipfire.org> wrote:
> 
> Hi,
> 
> On 03.07.2020 11:37, Michael Tremer wrote:
>> Reviewed-by: Michael Tremer <michael.tremer@ipfire.org>
>> 
>> Very interesting how much you can develop around a simple DHCP client :)
>> 
> ...
> And guess what? 9.3.4 is out.
> 
> Please don't merge...the next patch is on his way.  *sigh*
> 
> Best,
> Matthias
  
Bernhard Bitsch July 4, 2020, 10:23 a.m. UTC | #4
Hi,

looking at the traffic in the mailing list of dhcpcd, I think this is a (hopefully) temporary phenomenon. As far I can see, Roy Marples made some deep changes to the code, for restructuring, ... Those changes always make in noise in the development and testing process.

Do we have a possibility, to participate in the testing process of dhcpcd? We have a somewhat broad user community, but the DHCP client is a essential part for all installations using a DHCP WAN connection.
Currently I see issues with the client, when the ISP changes my IP. Because this happens in the night ( 1.00 am to 2.30 am ), I haven't examined this in depth, yet.

-Bernhard

> Gesendet: Samstag, 04. Juli 2020 um 11:32 Uhr
> Von: "Michael Tremer" <michael.tremer@ipfire.org>
> An: "Matthias Fischer" <matthias.fischer@ipfire.org>
> Cc: development@lists.ipfire.org
> Betreff: Re: [PATCH] dhcpcd: Update to 9.1.3
>
> Hi,
>
> So since there is a lot of releases, can we come up with some sort of regular update cycle?
>
> I do not think it makes sense to build every single release, because there will always be another one. Should we limit ourselves to about one a month or something like that?
>
> -Michael
>
> > On 3 Jul 2020, at 17:09, Matthias Fischer <matthias.fischer@ipfire.org> wrote:
> >
> > Hi,
> >
> > On 03.07.2020 11:37, Michael Tremer wrote:
> >> Reviewed-by: Michael Tremer <michael.tremer@ipfire.org>
> >>
> >> Very interesting how much you can develop around a simple DHCP client :)
> >>
> > ...
> > And guess what? 9.3.4 is out.
> >
> > Please don't merge...the next patch is on his way.  *sigh*
> >
> > Best,
> > Matthias
>
>
  
Matthias Fischer July 5, 2020, 8:44 a.m. UTC | #5
Hi,

On 04.07.2020 11:32, Michael Tremer wrote:
> Hi,
> 
> So since there is a lot of releases, can we come up with some sort of regular update cycle?

I'd like to. Otherwise, its often hard to decide whether an update is
*really* important or just "nice to have". Software is evil... ;-)

This is one reason why I stopped pushing every available 'squid 4.12' patch.
E.g., how many IPFire user are affected by "squid-Bug 503" (Negative
caching caches errors from If-Modified-Since requests indefinitely) and
is this a serious bug? For IPFire? Hm. Hard to tell. The same applies to
'dhcpcd'. Which release is important for us?

> I do not think it makes sense to build every single release, because there will always be another one.

Yep. Especially for 'dhcpcd' there were over a dozen releases in the
last  half year. But who - and how to - decide(s) what "makes sense"!?
Besides - apart from a few exceptions - I test almost every single patch
before I upload it (yesterday's updates - libvirt, libusbredir, qemu-
are for example such exceptions). And I often sent patches for errors
that I could not reproduce in my environment. Only to prevent them from
appearing with other users.

> Should we limit ourselves to about one a month or something like that?

This would be no problem for me. And it would save some traffic/noise on
the list. As I wrote above: hard to tell...

Best,
Matthias

> 
> -Michael
> 
>> On 3 Jul 2020, at 17:09, Matthias Fischer <matthias.fischer@ipfire.org> wrote:
>> 
>> Hi,
>> 
>> On 03.07.2020 11:37, Michael Tremer wrote:
>>> Reviewed-by: Michael Tremer <michael.tremer@ipfire.org>
>>> 
>>> Very interesting how much you can develop around a simple DHCP client :)
>>> 
>> ...
>> And guess what? 9.3.4 is out.
>> 
>> Please don't merge...the next patch is on his way.  *sigh*
>> 
>> Best,
>> Matthias
>
  
Matthias Fischer July 5, 2020, 8:44 a.m. UTC | #6
Hi,

On 04.07.2020 12:23, Bernhard Bitsch wrote:
> Hi,
> 
> looking at the traffic in the mailing list of dhcpcd, I think this is a (hopefully) temporary phenomenon. As far I can see, Roy Marples made some deep changes to the code, for restructuring, ... Those changes always make in noise in the development and testing process.

I'm hoping the same - at some point it will wear off.

> Do we have a possibility, to participate in the testing process of dhcpcd? We have a somewhat broad user community, but the DHCP client is a essential part for all installations using a DHCP WAN connection.

My first thought: if you'd like to participate - why not just ask in the
dhcpcd discussion group?

> Currently I see issues with the client, when the ISP changes my IP. Because this happens in the night ( 1.00 am to 2.30 am ), I haven't examined this in depth, yet.

This sounds easy, but sometimes I decide whether to upload an update or
not based on the number of requests in the respective discussion groups
or in the IPFire forum - even if I cannot reproduce the bug(s) or am not
directly affected.

Sadly, my system is running without seen problems. The kids have mostly
moved out and it gets boring. No more challenges. ;-)

> 
> -Bernhard
> 
>> Gesendet: Samstag, 04. Juli 2020 um 11:32 Uhr
>> Von: "Michael Tremer" <michael.tremer@ipfire.org>
>> An: "Matthias Fischer" <matthias.fischer@ipfire.org>
>> Cc: development@lists.ipfire.org
>> Betreff: Re: [PATCH] dhcpcd: Update to 9.1.3
>>
>> Hi,
>>
>> So since there is a lot of releases, can we come up with some sort of regular update cycle?
>>
>> I do not think it makes sense to build every single release, because there will always be another one. Should we limit ourselves to about one a month or something like that?
>>
>> -Michael
>>
>> > On 3 Jul 2020, at 17:09, Matthias Fischer <matthias.fischer@ipfire.org> wrote:
>> >
>> > Hi,
>> >
>> > On 03.07.2020 11:37, Michael Tremer wrote:
>> >> Reviewed-by: Michael Tremer <michael.tremer@ipfire.org>
>> >>
>> >> Very interesting how much you can develop around a simple DHCP client :)
>> >>
>> > ...
>> > And guess what? 9.3.4 is out.
>> >
>> > Please don't merge...the next patch is on his way.  *sigh*
>> >
>> > Best,
>> > Matthias
>>
>>
>
  

Patch

diff --git a/lfs/dhcpcd b/lfs/dhcpcd
index c5a2c1a25..cdec5b5fa 100644
--- a/lfs/dhcpcd
+++ b/lfs/dhcpcd
@@ -24,7 +24,7 @@ 
 
 include Config
 
-VER        = 9.1.2
+VER        = 9.1.3
 
 THISAPP    = dhcpcd-$(VER)
 DL_FILE    = $(THISAPP).tar.xz
@@ -40,7 +40,7 @@  objects = $(DL_FILE)
 
 $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
 
-$(DL_FILE)_MD5 = 96fc03f0b57e85a2dca2854bf2ff762d
+$(DL_FILE)_MD5 = 27050a48f547200fb6a8da35c67c6d97
 
 install : $(TARGET)