Typo in 'media.cgi'

Message ID 20200513135520.30310-1-matthias.fischer@ipfire.org
State New
Headers show
Series
  • Typo in 'media.cgi'
Related show

Commit Message

Matthias Fischer May 13, 2020, 1:55 p.m. UTC
'transfers' = 'Transfers'

Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org>
---
 html/cgi-bin/media.cgi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Tremer May 13, 2020, 2:04 p.m. UTC | #1
Hi,

Should we not have a variable here to get the string form the language files?

-Michael

> On 13 May 2020, at 14:55, Matthias Fischer <matthias.fischer@ipfire.org> wrote:
> 
> 'transfers' = 'Transfers'
> 
> Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org>
> ---
> html/cgi-bin/media.cgi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/html/cgi-bin/media.cgi b/html/cgi-bin/media.cgi
> index 0bb6435ab..a33d69313 100644
> --- a/html/cgi-bin/media.cgi
> +++ b/html/cgi-bin/media.cgi
> @@ -147,7 +147,7 @@ END
> 	my @iostat1 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$1}');
> 	my @iostat2 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$5}');
> 	my @iostat3 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$6}');
> -	print "<tr><td colspan='3'>&nbsp;\n<tr><td colspan='3'><h3>transfers</h3></td></tr>";
> +	print "<tr><td colspan='3'>&nbsp;\n<tr><td colspan='3'><h3>Transfers</h3></td></tr>";
> 	my $i=0;
> 
> 	for(my $i = 1; $i <= $#iostat1; $i++){
> -- 
> 2.17.1
>
Matthias Fischer May 13, 2020, 2:17 p.m. UTC | #2
Right.

Work in progress.

On 13.05.2020 16:04, Michael Tremer wrote:
> Hi,
> 
> Should we not have a variable here to get the string form the language files?
> 
> -Michael
> 
>> On 13 May 2020, at 14:55, Matthias Fischer <matthias.fischer@ipfire.org> wrote:
>> 
>> 'transfers' = 'Transfers'
>> 
>> Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org>
>> ---
>> html/cgi-bin/media.cgi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/html/cgi-bin/media.cgi b/html/cgi-bin/media.cgi
>> index 0bb6435ab..a33d69313 100644
>> --- a/html/cgi-bin/media.cgi
>> +++ b/html/cgi-bin/media.cgi
>> @@ -147,7 +147,7 @@ END
>> 	my @iostat1 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$1}');
>> 	my @iostat2 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$5}');
>> 	my @iostat3 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$6}');
>> -	print "<tr><td colspan='3'>&nbsp;\n<tr><td colspan='3'><h3>transfers</h3></td></tr>";
>> +	print "<tr><td colspan='3'>&nbsp;\n<tr><td colspan='3'><h3>Transfers</h3></td></tr>";
>> 	my $i=0;
>> 
>> 	for(my $i = 1; $i <= $#iostat1; $i++){
>> -- 
>> 2.17.1
>> 
>

Patch

diff --git a/html/cgi-bin/media.cgi b/html/cgi-bin/media.cgi
index 0bb6435ab..a33d69313 100644
--- a/html/cgi-bin/media.cgi
+++ b/html/cgi-bin/media.cgi
@@ -147,7 +147,7 @@  END
 	my @iostat1 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$1}');
 	my @iostat2 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$5}');
 	my @iostat3 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$6}');
-	print "<tr><td colspan='3'>&nbsp;\n<tr><td colspan='3'><h3>transfers</h3></td></tr>";
+	print "<tr><td colspan='3'>&nbsp;\n<tr><td colspan='3'><h3>Transfers</h3></td></tr>";
 	my $i=0;
 
 	for(my $i = 1; $i <= $#iostat1; $i++){