diff mbox series

[1/2] Lightning Wire Labs: Drop authentication using username/password

Message ID 20200130173814.9364-1-michael.tremer@ipfire.org
State Accepted
Commit c772f5f2e9e3251d3ca2a62b364c95c048ffcdb6
Headers
Series [1/2] Lightning Wire Labs: Drop authentication using username/password |

Commit Message

Michael Tremer Jan. 30, 2020, 5:38 p.m. UTC 
  This is quite dangerous using the main credentials to
update DDNS. Hence LWL is dropping this now and only
supports authentication using tokens.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---
 src/ddns/providers.py | 20 +++++---------------
 1 file changed, 5 insertions(+), 15 deletions(-)
diff mbox series

Patch

diff --git a/src/ddns/providers.py b/src/ddns/providers.py
index 661fbcc..95f3dd5 100644
--- a/src/ddns/providers.py
+++ b/src/ddns/providers.py
@@ -1227,27 +1227,17 @@  class DDNSProviderLightningWireLabs(DDNSProvider):
 	url = "https://dns.lightningwirelabs.com/update"
 
 	def update(self):
+		# Raise an error if no auth details are given.
+		if not self.token:
+			raise DDNSConfigurationError
+
 		data =  {
 			"hostname" : self.hostname,
+			"token"    : self.token,
 			"address6" : self.get_address("ipv6", "-"),
 			"address4" : self.get_address("ipv4", "-"),
 		}
 
-		# Check if a token has been set.
-		if self.token:
-			data["token"] = self.token
-
-		# Check for username and password.
-		elif self.username and self.password:
-			data.update({
-				"username" : self.username,
-				"password" : self.password,
-			})
-
-		# Raise an error if no auth details are given.
-		else:
-			raise DDNSConfigurationError
-
 		# Send update to the server.
 		response = self.send_request(self.url, data=data)