Use HTTPS for checkip{6,4}.dns.lightningwirelabs.com

Message ID 20191008083706.5120-1-michael.tremer@ipfire.org
State Accepted
Commit 60e54d7112ba2a068c8909ca22c5f71734871cab
Headers
Series Use HTTPS for checkip{6,4}.dns.lightningwirelabs.com |

Commit Message

Michael Tremer Oct. 8, 2019, 8:37 a.m. UTC
  Since we are deploying a HSTS policy for lightningwirelabs.com now,
and we generally only use HTTPS for everything, this patch changes
this for the IP address discovery process, too.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---
 src/ddns/system.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Patch

diff --git a/src/ddns/system.py b/src/ddns/system.py
index 67ea553..b7a51f6 100644
--- a/src/ddns/system.py
+++ b/src/ddns/system.py
@@ -112,9 +112,9 @@  class DDNSSystem(object):
 
 	def guess_external_ip_address(self, family, **kwargs):
 		if family == "ipv6":
-			url = "http://checkip6.dns.lightningwirelabs.com"
+			url = "https://checkip6.dns.lightningwirelabs.com"
 		elif family == "ipv4":
-			url = "http://checkip4.dns.lightningwirelabs.com"
+			url = "https://checkip4.dns.lightningwirelabs.com"
 		else:
 			raise ValueError("unknown address family")