| Message ID | 20190901224729.24567-1-ipfire@starkstromkonsument.de |
|---|---|
| State | Accepted |
| Commit | 7f44ec0478285bc16c5ff9336f604a0e45678130 |
| Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (mail01.i.ipfire.org [172.28.1.200]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail01.ipfire.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 46M7ds3ZgMz42D3 for <patchwork@web04.haj.ipfire.org>; Sun, 1 Sep 2019 22:47:45 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail02.haj.ipfire.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 46M7dr0Zz7z4xFbX; Sun, 1 Sep 2019 23:47:44 +0100 (BST) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 46M7dq2KRWz2yjK; Sun, 1 Sep 2019 22:47:43 +0000 (UTC) Received: from mail01.ipfire.org (mail01.i.ipfire.org [172.28.1.200]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail01.ipfire.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 46M7dn2GyLz2ygm for <development@lists.ipfire.org>; Sun, 1 Sep 2019 22:47:41 +0000 (UTC) Received: from nx113.node01.secure-mailgate.com (nx113.node01.secure-mailgate.com [89.22.108.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail01.ipfire.org (Postfix) with ESMTPS id 46M7dn0CCDz4xFbX for <development@lists.ipfire.org>; Sun, 1 Sep 2019 23:47:40 +0100 (BST) Received: from dehamd003.servertools24.de ([31.47.254.18]) by node01.secure-mailgate.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from <ipfire@starkstromkonsument.de>) id 1i4YdB-0001gc-LO for development@lists.ipfire.org; Mon, 02 Sep 2019 00:47:34 +0200 Received: from starkstromlahn.spdns.org (dslb-002-205-034-161.002.205.pools.vodafone-ip.de [2.205.34.161]) by dehamd003.servertools24.de (Postfix) with ESMTPSA id 49105805CD for <development@lists.ipfire.org>; Mon, 2 Sep 2019 00:47:32 +0200 (CEST) Received-SPF: pass (dehamd003.servertools24.de: connection is authenticated) From: Alex Koch <ipfire@starkstromkonsument.de> To: development@lists.ipfire.org Subject: [PATCH] zoneconf: reduce the width of inputs for vlanid Date: Mon, 2 Sep 2019 00:47:29 +0200 Message-Id: <20190901224729.24567-1-ipfire@starkstromkonsument.de> X-PPP-Message-ID: <20190901224732.24358.56595@dehamd003.servertools24.de> X-PPP-Vhost: starkstromkonsument.de X-Originating-IP: 31.47.254.18 X-SecureMailgate-Domain: dehamd003.servertools24.de X-SecureMailgate-Username: 31.47.254.18 X-SecureMailgate-Outgoing-Class: ham X-SecureMailgate-Outgoing-Evidence: Combined (0.02) X-Recommended-Action: accept X-Filter-ID: Mvzo4OR0dZXEDF/gcnlw0duM4P579sYYbdH8Mt+sPVWpSDasLI4SayDByyq9LIhVqf11m3Hktqi3 it11fN6+wkTNWdUk1Ol2OGx3IfrIJKywOmJyM1qr8uRnWBrbSAGDjJTO55kJBbv01x7dn2l3rPNh vhTXFC3uEZfNFh1aVkTnx8yeplRO3sLIqUlSH7OGEsChco5tPWDUcSEm5f06yoMlhcTgOXSCz8qb ysTVYVkaLnpCEJIWxWTJBf3FFLEmu3xsQHMYnlKQ9pcJ+5Uh0/FACMa4l/3pd4b5Oy6wVMHiry29 aJ9gWL+JCa8hKpZUCzCvRwvqVEAQMkdN/mM3fI6jSvfpO+1kZkomjtjB6X7/nuj3koRhn2BlE7dX oT0pcbRIdQWM2NQMFh4QV224OAeB7iXwS+ET8xu8PinDjLaQeETIza2ISn5dEgBRzdTORAwX31WV Y5lWjWxuGSRuxWXf5NNoWqxwzT7YQb2bq3uDyiKr2bObCttBtO6VKDuO5YE5enyccp7RH4WQio3u GQOhzeGzw2pFTXtxL2RPdTQ0WClL7lPySiyMTFKyJyozybxQmwA+8NxVIq0MJiSKg9jlDHh8k6TT dHl8m1/8O/92QjNLubgZSlcJjVjePeKVzS9GD/IKkRDV2QGlthfHXYgh8CEuU+1XW0vEtT+FwMsd KoBm7LpFtilifZWOLmV3/CeYAyttYdeEH2R9QRhZDqzL2SfQG0dSP4FuiPfFINA+p/Z3NcHxDVIt hQj36LyC1x66Qw3T0UFAji0c5knCvGgNninNOnp9XbMRwMwWrv3zxYP9kzBy945btFBHxykDy3BH QTsHg9ZZ+vQS6KwWvZyHPpuhdexsTmFv41vHXcgN4a3CnNcF3q0FZHwZG8ZR0sEmtoqhLjbEtkj9 CuDQRUFlf+gWT7v14rJm2E3PGsbtxOzzT/YWdmD8gywgB151eyyFY8GlmzRmIAOnS+GEXwEKaipO awN0AgJAg/KPUJM4l8rbNA7wj6QG1FXuXiK7N6LaNLb3lhm5MX4VrSl93jbiT9tkDxmwwn3e/+d7 cvas+yPoAIIlCTgNeJ6BI6ZW8USH3dGwLkG46rflwqVsACGdtrRMVGrTPw8oVQPCiJ8= X-Report-Abuse-To: spam@node01.secure-mailgate.com Authentication-Results: mail01.ipfire.org; dkim=none; dmarc=none; spf=pass (mail01.ipfire.org: domain of ipfire@starkstromkonsument.de designates 89.22.108.113 as permitted sender) smtp.mailfrom=ipfire@starkstromkonsument.de X-Rspamd-Queue-Id: 46M7dn0CCDz4xFbX X-Spamd-Result: default: False [-4.72 / 11.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:89.22.108.0/24]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[development@lists.ipfire.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[3]; DMARC_NA(0.00)[starkstromkonsument.de]; MX_GOOD(-0.01)[cached: mail.starkstromkonsument.de]; RCVD_IN_DNSWL_NONE(0.00)[113.108.22.89.list.dnswl.org : 127.0.5.0]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM(-2.40)[-0.799,0]; IP_SCORE(-0.02)[country: DE(-0.08)]; RECEIVED_SPAMHAUS_PBL(0.00)[161.34.205.2.zen.spamhaus.org : 127.0.0.11]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:45031, ipnet:89.22.96.0/19, country:DE]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-3.00)[99.99%]; FROM_EQ_ENVFROM(0.00)[] X-Rspamd-Server: mail01.i.ipfire.org X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <https://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <https://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
| Series |
zoneconf: reduce the width of inputs for vlanid
|
|
Commit Message
Alexander Koch
Sept. 1, 2019, 10:47 p.m. UTC
The inputs for the vlanids are overlapping the borders of their cells (using a recent Firefox on Linux Mint, Android or Windows 7). This patch fixes this by limiting the width to a fixed value.
Signed-off-by: Alex Koch <ipfire@starkstromkonsument.de>
---
html/cgi-bin/zoneconf.cgi | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
Comments
Hi, Just for my own illustration, could you send a screenshot? Best, -Michael > On 1 Sep 2019, at 23:47, Alex Koch <ipfire@starkstromkonsument.de> wrote: > > The inputs for the vlanids are overlapping the borders of their cells (using a recent Firefox on Linux Mint, Android or Windows 7). This patch fixes this by limiting the width to a fixed value. > > Signed-off-by: Alex Koch <ipfire@starkstromkonsument.de> > --- > html/cgi-bin/zoneconf.cgi | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/html/cgi-bin/zoneconf.cgi b/html/cgi-bin/zoneconf.cgi > index 40239c14e..6b8642818 100644 > --- a/html/cgi-bin/zoneconf.cgi > +++ b/html/cgi-bin/zoneconf.cgi > @@ -93,6 +93,10 @@ my $css = <<END > text-align: center; > } > > + input.vlanid { > + width: 4em; > + } > + > #submit-container { > width: 100%; > padding-top: 20px; > @@ -432,7 +436,7 @@ foreach (@nics) { > <option value="NATIVE" $access_selected{"NATIVE"}>$Lang::tr{"zoneconf access native"}</option> > <option value="VLAN" $access_selected{"VLAN"} $vlan_disabled>$Lang::tr{"zoneconf access vlan"}</option> > </select> > - <input type="number" id="TAG $uc $mac" name="TAG $uc $mac" min="1" max="4095" value="$zone_vlan_id" $field_disabled> > + <input type="number" class="vlanid" id="TAG $uc $mac" name="TAG $uc $mac" min="1" max="4095" value="$zone_vlan_id" $field_disabled> > </td> > END > ; > -- > 2.17.1 >
Hi, the Problem occurs if you use four zones and the "ipfire-legacy"-Theme. But the "ipfire"-Theme also renders the vlanid-input pretty wide and wraps the line inside the cell. There actually is no need for this, as an VLAN-ID has a maximum length of four digits. Some Screenshots: https://starkstromlahn.spdns.org/s/qb4iFZmxCQqxb7f Regards, Alex -------- Original Message -------- From: Michael Tremer [mailto:michael.tremer@ipfire.org] Sent: Monday, 2 September 2019, 13:32 CEST To: Alex Koch <ipfire@starkstromkonsument.de> Cc: development@lists.ipfire.org Subject: [PATCH] zoneconf: reduce the width of inputs for vlanid Hi, Just for my own illustration, could you send a screenshot? Best, -Michael On 1 Sep 2019, at 23:47, Alex Koch <ipfire@starkstromkonsument.de> wrote: The inputs for the vlanids are overlapping the borders of their cells (using a recent Firefox on Linux Mint, Android or Windows 7). This patch fixes this by limiting the width to a fixed value. Signed-off-by: Alex Koch <ipfire@starkstromkonsument.de> --- html/cgi-bin/zoneconf.cgi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/html/cgi-bin/zoneconf.cgi b/html/cgi-bin/zoneconf.cgi index 40239c14e..6b8642818 100644 --- a/html/cgi-bin/zoneconf.cgi +++ b/html/cgi-bin/zoneconf.cgi @@ -93,6 +93,10 @@ my $css = <<END text-align: center; } + input.vlanid { + width: 4em; + } + #submit-container { width: 100%; padding-top: 20px; @@ -432,7 +436,7 @@ foreach (@nics) { <option value="NATIVE" $access_selected{"NATIVE"}>$Lang::tr{"zoneconf access native"}</option> <option value="VLAN" $access_selected{"VLAN"} $vlan_disabled>$Lang::tr{"zoneconf access vlan"}</option> </select> - <input type="number" id="TAG $uc $mac" name="TAG $uc $mac" min="1" max="4095" value="$zone_vlan_id" $field_disabled> + <input type="number" class="vlanid" id="TAG $uc $mac" name="TAG $uc $mac" min="1" max="4095" value="$zone_vlan_id" $field_disabled> </td> END ;
Hi, > On 3 Sep 2019, at 19:50, Alexander Koch <ipfire@starkstromkonsument.de> wrote: > > Hi, > > the Problem occurs if you use four zones and the "ipfire-legacy"-Theme. But the "ipfire"-Theme also renders the vlanid-input pretty wide and wraps the line inside the cell. There actually is no need for this, as an VLAN-ID has a maximum length of four digits. > > Some Screenshots: https://starkstromlahn.spdns.org/s/qb4iFZmxCQqxb7f The old theme is practically unmaintainable, but good to take a little bit of care here as well. Acked-by: Michael Tremer <michael.tremer@ipfire.org> -Michael > > Regards, Alex > > > -------- Original Message -------- > From: Michael Tremer [mailto:michael.tremer@ipfire.org] > Sent: Monday, 2 September 2019, 13:32 CEST > To: Alex Koch <ipfire@starkstromkonsument.de> > Cc: development@lists.ipfire.org > Subject: [PATCH] zoneconf: reduce the width of inputs for vlanid > > Hi, > > Just for my own illustration, could you send a screenshot? > > Best, > -Michael > > On 1 Sep 2019, at 23:47, Alex Koch <ipfire@starkstromkonsument.de> wrote: > > The inputs for the vlanids are overlapping the borders of their cells (using a recent Firefox on Linux Mint, Android or Windows 7). This patch fixes this by limiting the width to a fixed value. > > Signed-off-by: Alex Koch <ipfire@starkstromkonsument.de> > --- > html/cgi-bin/zoneconf.cgi | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/html/cgi-bin/zoneconf.cgi b/html/cgi-bin/zoneconf.cgi > index 40239c14e..6b8642818 100644 > --- a/html/cgi-bin/zoneconf.cgi > +++ b/html/cgi-bin/zoneconf.cgi > @@ -93,6 +93,10 @@ my $css = <<END > text-align: center; > } > > + input.vlanid { > + width: 4em; > + } > + > #submit-container { > width: 100%; > padding-top: 20px; > @@ -432,7 +436,7 @@ foreach (@nics) { > <option value="NATIVE" $access_selected{"NATIVE"}>$Lang::tr{"zoneconf access native"}</option> > <option value="VLAN" $access_selected{"VLAN"} $vlan_disabled>$Lang::tr{"zoneconf access vlan"}</option> > </select> > - <input type="number" id="TAG $uc $mac" name="TAG $uc $mac" min="1" max="4095" value="$zone_vlan_id" $field_disabled> > + <input type="number" class="vlanid" id="TAG $uc $mac" name="TAG $uc $mac" min="1" max="4095" value="$zone_vlan_id" $field_disabled> > </td> > END > ; > -- > 2.17.1 > > >
diff --git a/html/cgi-bin/zoneconf.cgi b/html/cgi-bin/zoneconf.cgi index 40239c14e..6b8642818 100644 --- a/html/cgi-bin/zoneconf.cgi +++ b/html/cgi-bin/zoneconf.cgi @@ -93,6 +93,10 @@ my $css = <<END text-align: center; } + input.vlanid { + width: 4em; + } + #submit-container { width: 100%; padding-top: 20px; @@ -432,7 +436,7 @@ foreach (@nics) { <option value="NATIVE" $access_selected{"NATIVE"}>$Lang::tr{"zoneconf access native"}</option> <option value="VLAN" $access_selected{"VLAN"} $vlan_disabled>$Lang::tr{"zoneconf access vlan"}</option> </select> - <input type="number" id="TAG $uc $mac" name="TAG $uc $mac" min="1" max="4095" value="$zone_vlan_id" $field_disabled> + <input type="number" class="vlanid" id="TAG $uc $mac" name="TAG $uc $mac" min="1" max="4095" value="$zone_vlan_id" $field_disabled> </td> END ;