proxy.cgi: Even more cosmetics for lazy ones (V3)

Message ID 20170929090825.2054-1-matthias.fischer@ipfire.org
State Superseded
Headers
Series proxy.cgi: Even more cosmetics for lazy ones (V3) |

Commit Message

Matthias Fischer Sept. 29, 2017, 7:08 p.m. UTC
  Another clickable link, this time for the 'Cache Manager Interface' - this one opens in a new window.

Best,
Matthias

Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org>
---
 html/cgi-bin/proxy.cgi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Michael Tremer Oct. 10, 2017, 1:34 a.m. UTC | #1
Hi,

On Fri, 2017-09-29 at 11:08 +0200, Matthias Fischer wrote:
> Another clickable link, this time for the 'Cache Manager Interface' - this one
> opens in a new window.
> 
> Best,
> Matthias
> 
> Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org>
> ---
>  html/cgi-bin/proxy.cgi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/html/cgi-bin/proxy.cgi b/html/cgi-bin/proxy.cgi
> index dd83bba73..ab490c3d3 100644
> --- a/html/cgi-bin/proxy.cgi
> +++ b/html/cgi-bin/proxy.cgi
> @@ -1118,7 +1118,7 @@ print <<END
>  	<td colspan='4'><b>$Lang::tr{'advproxy cache management'}</b></td>
>  </tr>
>  <tr>
> -	<td class='base'>$Lang::tr{'proxy cachemgr'}:</td>
> +	<td class='base'><a href='/cgi-bin/cachemgr.cgi\'
> target=\'_blank\'>$Lang::tr{'proxy cachemgr'}</a>:</td>
>  	<td><input type='checkbox' name='CACHEMGR' $checked{'CACHEMGR'}{'on'}
> /></td>

Why do you escape the '?

>  	<td class='base'>$Lang::tr{'advproxy admin mail'}:</td>
>  	<td><input type='text' name='ADMIN_MAIL_ADDRESS'
> value='$proxysettings{'ADMIN_MAIL_ADDRESS'}' /></td>

-Michael
  
Matthias Fischer Oct. 10, 2017, 5:38 a.m. UTC | #2
Hi,

On 09.10.2017 16:34, Michael Tremer wrote:
> Hi,
> 
> On Fri, 2017-09-29 at 11:08 +0200, Matthias Fischer wrote:
>> Another clickable link, this time for the 'Cache Manager Interface' - this one
>> opens in a new window.
>> 
>> Best,
>> Matthias
>> 
>> Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org>
>> ---
>>  html/cgi-bin/proxy.cgi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/html/cgi-bin/proxy.cgi b/html/cgi-bin/proxy.cgi
>> index dd83bba73..ab490c3d3 100644
>> --- a/html/cgi-bin/proxy.cgi
>> +++ b/html/cgi-bin/proxy.cgi
>> @@ -1118,7 +1118,7 @@ print <<END
>>  	<td colspan='4'><b>$Lang::tr{'advproxy cache management'}</b></td>
>>  </tr>
>>  <tr>
>> -	<td class='base'>$Lang::tr{'proxy cachemgr'}:</td>
>> +	<td class='base'><a href='/cgi-bin/cachemgr.cgi\'
>> target=\'_blank\'>$Lang::tr{'proxy cachemgr'}</a>:</td>
>>  	<td><input type='checkbox' name='CACHEMGR' $checked{'CACHEMGR'}{'on'}
>> /></td>
> 
> Why do you escape the '?

No good reason just one too many.

>>  	<td class='base'>$Lang::tr{'advproxy admin mail'}:</td>
>>  	<td><input type='text' name='ADMIN_MAIL_ADDRESS'
>> value='$proxysettings{'ADMIN_MAIL_ADDRESS'}' /></td>
> 
> -Michael
>
  

Patch

diff --git a/html/cgi-bin/proxy.cgi b/html/cgi-bin/proxy.cgi
index dd83bba73..ab490c3d3 100644
--- a/html/cgi-bin/proxy.cgi
+++ b/html/cgi-bin/proxy.cgi
@@ -1118,7 +1118,7 @@  print <<END
 	<td colspan='4'><b>$Lang::tr{'advproxy cache management'}</b></td>
 </tr>
 <tr>
-	<td class='base'>$Lang::tr{'proxy cachemgr'}:</td>
+	<td class='base'><a href='/cgi-bin/cachemgr.cgi\' target=\'_blank\'>$Lang::tr{'proxy cachemgr'}</a>:</td>
 	<td><input type='checkbox' name='CACHEMGR' $checked{'CACHEMGR'}{'on'} /></td>
 	<td class='base'>$Lang::tr{'advproxy admin mail'}:</td>
 	<td><input type='text' name='ADMIN_MAIL_ADDRESS' value='$proxysettings{'ADMIN_MAIL_ADDRESS'}' /></td>