mbox

[1/5] zone: fix zone_config()

Message ID 1500305066-12510-1-git-send-email-jonatan.schlag@ipfire.org
State Superseded
Headers

Message

Jonatan Schlag July 18, 2017, 1:24 a.m. UTC 
  Signed-off-by: Jonatan Schlag <jonatan.schlag@ipfire.org>
---
 src/functions/functions.zone | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Michael Tremer July 18, 2017, 6:20 a.m. UTC | #1 
Hi,

I merged this patchset, but there is a few comments left.

Maybe you can have a look at them and if you think it suits, please
send some patches to get rid of any problems.

-Michael

On Mon, 2017-07-17 at 17:24 +0200, Jonatan Schlag wrote:
> Signed-off-by: Jonatan Schlag <jonatan.schlag@ipfire.org>
> ---
>  src/functions/functions.zone | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/functions/functions.zone
> b/src/functions/functions.zone
> index acf68f5..11a8dc2 100644
> --- a/src/functions/functions.zone
> +++ b/src/functions/functions.zone
> @@ -565,9 +565,9 @@ zone_config() {
>  			# TODO This could be also a valid hid
>  			local id=${cmd}
>  
> -			if zone_config_id_is valid ${zone} ${id} &&
> [[ ${1} == "edit" ]]; then
> +			if zone_config_id_is_valid ${zone} ${id} &&
> [[ ${1} == "edit" ]]; then
>  				shift 1
> -				zone_config_edit "${zone}"
> "${id}""$@"
> +				zone_config_edit "${zone}" "${id}"
> "$@"
>  			else
>  				error "Unrecognized argument:
> ${cmd}"
>  				cli_usage root-zone-config-
> subcommands