| Message ID | 1494497813-2694-1-git-send-email-dirk.wagner@ipfire.org |
|---|---|
| State | Superseded |
| Headers |
Return-Path: <ddns-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (unknown [172.28.1.200]) by web02.ipfire.org (Postfix) with ESMTP id DD3A16216F for <patchwork@ipfire.org>; Thu, 11 May 2017 12:17:24 +0200 (CEST) Received: from mail01.ipfire.org (localhost [IPv6:::1]) by mail01.ipfire.org (Postfix) with ESMTP id 9926624AC; Thu, 11 May 2017 12:17:19 +0200 (CEST) Received: from server.wagner-budenheim.de (ip5b43bba1.dynamic.kabel-deutschland.de [91.67.187.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 80BEF171E; Thu, 11 May 2017 12:17:10 +0200 (CEST) From: Dirk Wagner <dirk.wagner@ipfire.org> To: ddns@lists.ipfire.org Subject: Date: Thu, 11 May 2017 12:16:18 +0200 Message-Id: <1494497813-2694-1-git-send-email-dirk.wagner@ipfire.org> X-Mailer: git-send-email 2.1.4 X-BeenThere: ddns@lists.ipfire.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List for the IPFire dynamic DNS client <ddns.lists.ipfire.org> List-Unsubscribe: <http://lists.ipfire.org/mailman/options/ddns>, <mailto:ddns-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/ddns/> List-Post: <mailto:ddns@lists.ipfire.org> List-Help: <mailto:ddns-request@lists.ipfire.org?subject=help> List-Subscribe: <http://lists.ipfire.org/mailman/listinfo/ddns>, <mailto:ddns-request@lists.ipfire.org?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ddns-bounces@lists.ipfire.org Sender: "ddns" <ddns-bounces@lists.ipfire.org> |
Message
Dirk Wagner
May 11, 2017, 8:16 p.m. UTC
One issue remains: The constant holdoff_rate_limited_minutes should be overwritable for each provider. For DomainOffensive 30 min ist too short. From 312ca7b32852c8b950868423d1919bc2f25031aa Mon Sep 17 00:00:00 2001 From: Dirk Wagner <dirk.wagner@ipfire.org> Date: Thu, 11 May 2017 09:04:49 +0200 Subject: [PATCH] ddns: fixed compile errors Signed-off-by: Dirk Wagner <dirk.wagner@ipfire.org> --- src/ddns/providers.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Comments
Sorry for the empty Subject, parts of the mail are lost. The patch is for the status-defeated branch > ---------- Ursprüngliche Nachricht ---------- > Von: Dirk Wagner <dirk.wagner@ipfire.org> > An: ddns@lists.ipfire.org > Cc: Dirk Wagner <dirk.wagner@ipfire.org> > Datum: 11. Mai 2017 um 12:16 > Betreff: > > One issue remains: > The constant holdoff_rate_limited_minutes should be overwritable for each provider. For DomainOffensive 30 min ist too short. > > From 312ca7b32852c8b950868423d1919bc2f25031aa Mon Sep 17 00:00:00 2001 > From: Dirk Wagner <dirk.wagner@ipfire.org> > Date: Thu, 11 May 2017 09:04:49 +0200 > Subject: [PATCH] ddns: fixed compile errors > > Signed-off-by: Dirk Wagner <dirk.wagner@ipfire.org> > --- > src/ddns/providers.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/ddns/providers.py b/src/ddns/providers.py > index cb6dd2d..5386f35 100644 > --- a/src/ddns/providers.py > +++ b/src/ddns/providers.py > @@ -69,7 +69,7 @@ class DDNSProvider(object): > > # holdoff time for rate-limited updates - Number of minutes no update > # is tried after the last one has been sent. > - holdoff_rate-limited_minutes = 30 > + holdoff_rate_limited_minutes = 30 > > # True if the provider is able to remove records, too. > # Required to remove AAAA records if IPv6 is absent again. > @@ -248,10 +248,10 @@ class DDNSProvider(object): > last_update = self.db.last_update(self.hostname, status=last_status) > > # Calculate holdoff end, based on the last status (failure or rate-limited) > - if last_status == "failure" > + if last_status == "failure": > holdoff_end = last_update + datetime.timedelta(days=self.holdoff_failure_days) > else: > - holdoff_end = last_update + datetime.timedelta(minutes=self.holdoff_rate-limited_minutes) > + holdoff_end = last_update + datetime.timedelta(minutes=self.holdoff_rate_limited_minutes) > > now = datetime.datetime.utcnow() > if now < holdoff_end: > -- > 2.1.4 >
Hello, @Stefan: Could you please review these patches more swiftly? There are so many things open and lying around regarding ddns which I would like to see solved. No need to rush things, but at least I would like to see things moving forward. Best, -Michael On Thu, 2017-05-11 at 12:23 +0200, dirk.wagner@ipfire.org wrote: > Sorry for the empty Subject, parts of the mail are lost. > > The patch is for the status-defeated branch > > > ---------- Ursprüngliche Nachricht ---------- > > Von: Dirk Wagner <dirk.wagner@ipfire.org> > > An: ddns@lists.ipfire.org > > Cc: Dirk Wagner <dirk.wagner@ipfire.org> > > Datum: 11. Mai 2017 um 12:16 > > Betreff: > > > > One issue remains: > > The constant holdoff_rate_limited_minutes should be overwritable for each > > provider. For DomainOffensive 30 min ist too short. > > > > From 312ca7b32852c8b950868423d1919bc2f25031aa Mon Sep 17 00:00:00 2001 > > From: Dirk Wagner <dirk.wagner@ipfire.org> > > Date: Thu, 11 May 2017 09:04:49 +0200 > > Subject: [PATCH] ddns: fixed compile errors > > > > Signed-off-by: Dirk Wagner <dirk.wagner@ipfire.org> > > --- > > src/ddns/providers.py | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/src/ddns/providers.py b/src/ddns/providers.py > > index cb6dd2d..5386f35 100644 > > --- a/src/ddns/providers.py > > +++ b/src/ddns/providers.py > > @@ -69,7 +69,7 @@ class DDNSProvider(object): > > > > # holdoff time for rate-limited updates - Number of minutes no > > update > > # is tried after the last one has been sent. > > - holdoff_rate-limited_minutes = 30 > > + holdoff_rate_limited_minutes = 30 > > > > # True if the provider is able to remove records, too. > > # Required to remove AAAA records if IPv6 is absent again. > > @@ -248,10 +248,10 @@ class DDNSProvider(object): > > last_update = self.db.last_update(self.hostname, > > status=last_status) > > > > # Calculate holdoff end, based on the last status (failure > > or rate-limited) > > - if last_status == "failure" > > + if last_status == "failure": > > holdoff_end = last_update + > > datetime.timedelta(days=self.holdoff_failure_days) > > else: > > - holdoff_end = last_update + > > datetime.timedelta(minutes=self.holdoff_rate-limited_minutes) > > + holdoff_end = last_update + > > datetime.timedelta(minutes=self.holdoff_rate_limited_minutes) > > > > now = datetime.datetime.utcnow() > > if now < holdoff_end: > > -- > > 2.1.4 > > > > _______________________________________________ > ddns mailing list > ddns@lists.ipfire.org > http://lists.ipfire.org/mailman/listinfo/ddns
Any new on that? > Michael Tremer hat am 24. Mai 2017 um 16:43 geschrieben: > > > Hello, > > @Stefan: Could you please review these patches more swiftly? There are so many > things open and lying around regarding ddns which I would like to see solved. > > No need to rush things, but at least I would like to see things moving forward. > > Best, > -Michael > > On Thu, 2017-05-11 at 12:23 +0200, dirk.wagner@ipfire.org mailto:dirk.wagner@ipfire.org wrote: > > > > Sorry for the empty Subject, parts of the mail are lost. > > > > The patch is for the status-defeated branch > > > > > -------- Ursprüngliche Nachricht ---------- > Von: Dirk Wagner > An: ddns@lists.ipfire mailto:ddns@lists.ipfire .org > Cc: Dirk Wagner > Datum: 11. Mai 2017 um 12:16 > Betreff: > > One issue remains: > The constant holdoff_rate_limited_minutes should be overwritable for each > provider. For DomainOffensive 30 min ist too short. > > From 312ca7b32852c8b950868423d1919bc2f25031aa Mon Sep 17 00:00:00 2001 > From: Dirk Wagner > Date: Thu, 11 May 2017 09:04:49 +0200 > Subject: [PATCH] ddns: fixed compile errors > > Signed-off-by: Dirk Wagner > --- > src/ddns/providers.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/ddns/providers.py b/src/ddns/providers.py > index cb6dd2d..5386f35 100644 > --- a/src/ddns/providers.py > +++ b/src/ddns/providers.py > @@ -69,7 +69,7 @@ class DDNSProvider(object): > > # holdoff time for rate-limited updates - Number of minutes no > update > # is tried after the last one has been sent. > - holdoff_rate-limited_minutes = 30 > + holdoff_rate_limited_minutes = 30 > > # True if the provider is able to remove records, too. > # Required to remove AAAA records if IPv6 is absent again. > @@ -248,10 +248,10 @@ class DDNSProvider(object): > last_update = self.db.last_update(self.hostname, > status=last_status) > > # Calculate holdoff end, based on the last status (failure > or rate-limited) > - if last_status == "failure" > + if last_status == "failure": > holdoff_end = last_update + > datetime.timedelta(days=self.holdoff_failure_days) > else: > - holdoff_end = last_update + > datetime.timedelta(minutes=self.holdoff_rate-limited_minutes) > + holdoff_end = last_update + > datetime.timedelta(minutes=self.holdoff_rate_limited_minutes) > > now = datetime.datetime.utcnow() > if now < holdoff_end: > -- > 2.1.4 > > _______________________________________________ ddns mailing list ddns@lists.ipfire mailto:ddns@lists.ipfire .org http://lists.ipfire.org/mailman/listinfo/ddns