New package iPerf3
Message ID | 1450877399.7835.0@smtp.1und1.de |
---|---|
State | Superseded |
Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (mail01.tremer.info [172.28.1.200]) by septima.ipfire.org (Postfix) with ESMTP id 0F01861A6E for <patchwork@ipfire.org>; Wed, 23 Dec 2015 14:30:08 +0100 (CET) Received: from hedwig.ipfire.org (localhost [IPv6:::1]) by mail01.ipfire.org (Postfix) with ESMTP id 53105197F; Wed, 23 Dec 2015 14:30:06 +0100 (CET) Received-SPF: None (no SPF record) identity=mailfrom; client-ip=217.72.192.73; helo=mout.kundenserver.de; envelope-from=jonatan@familyschlag.de; receiver=development@lists.ipfire.org Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.73]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPS id 1B4071964 for <development@lists.ipfire.org>; Wed, 23 Dec 2015 14:30:01 +0100 (CET) Received: from [192.168.103.126] ([88.73.223.171]) by mrelayeu.kundenserver.de (mreue101) with ESMTPSA (Nemesis) id 0MDxdP-1Zx9hX0Nix-00HOPH for <development@lists.ipfire.org>; Wed, 23 Dec 2015 14:30:00 +0100 Date: Wed, 23 Dec 2015 14:29:59 +0100 From: Jonatan Schlag <jonatan@familyschlag.de> Subject: New package iPerf3 To: development@lists.ipfire.org Message-Id: <1450877399.7835.0@smtp.1und1.de> X-Mailer: geary/0.10.0 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=-6ciDyRVyUSFjZJe4uM0b" X-Provags-ID: V03:K0:jhtQRcu5ui3L7Xz1GI6pJ8r189GnbqxtB6J4TR/rzyIh8qi7MRp X1YUJkYq6WaoSXKrKVKLwW3LyJE3qx1CMLPm9vI9TA2zOSgskJ9FAiuAwjS5Skr5IsIydZE pgSPkoKkxEURpkKSkZVSWEvRjuNsW2QL52IZ6yNSPNvga4w1fOtHp/JNx61I1RPysBekIDn zKA/XhEseKJ7jhZ8eJZ/w== X-UI-Out-Filterresults: notjunk:1; V01:K0:8f0teVahX2A=:vlwRQ/PFBteCnMHpxirwD7 byVEwlq+tkG3n5COumfXauaopzNLGyU1QZ+nmKIVaNM1As+lcgsQ7xmFtPmQ8lHn7Fv8QBHqH KSh3cpFYXC9K/c0cYZLlohoTGPRftykBrqFffhUjlq3D4uuk9vSJUxQKrKPQGZ40yh7OQQiVb FuU4PMQmV5qX1bQbgUZn17rPe1Jp/3M9UnRqFx2SLPkXpVcy3/KgmYxGsEVKUvst6r2xnOpgi IM2zQ9TXGDbUbOeQyE7m17gN2+nint4A4UtK5FMUPbPT/rS/aWbyBZ/qVxSClgurfxZuHWshQ Pi4KWYNjYhUjzLBzWBCII3NkJffWnErggRIcqc3k4ovXq2c65Rc9mKt8EHvMsPROw3dxjEzrd mFyOTtMg/umSayhm5DeijHi1CgAezuahX5r+Q0S2T7USuzuKCvLTFVsWFt7qhNeOH4rznG79n DvcobwbsRYEjCNC1EafHIAIz6bJbTYdcKxMYOaSAehC/JB7KX7queuH2HPNw1piWI+6cSOV3s zDQkHRY57X91NZfCZrWrEvQ9CNZYFyKApBx0L6x9W9sILbpTpDmvcSOD2BLE1gW84LvjqDT1x mRo96CTln0tSR9iRR2QKAoALgL/wYIA94rbJ8nNUBkUBpQylAuiTrHPI2xF/r1yK20hO78b0h ri5uNky4iAuYYQy/mN+ZUN/72v/NxEfk6MunPbc1BHuzXFuAnbFK+/HkwWcJR54x78kWUt4Jm de3103ZDUzuojZ8N X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <http://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <http://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
Message
Jonatan Schlag
Dec. 24, 2015, 12:29 a.m. UTC
Hi, I build iPerf3 for IPFire, (for reasons look here: http://forum.ipfire.org/viewtopic.php?f=50&t=15498) and was told that i should submit changes to the mailing list. Here is a patch with all changes: Signed-off-by: Jonatan Schlag <jonatan@familyschlag.de> From a403b42f389cd5617937a0df220c67e279236034 Mon Sep 17 00:00:00 2001 From: jonaschl <jonnyschlag@gmail.com> Date: Wed, 23 Dec 2015 13:43:20 +0100 Subject: [PATCH] new package iPerf 3 email: jonnyschlag@gmail.com author: jonaschl --- config/rootfiles/packages/iperf3 | 10 +++++ lfs/iperf3 | 84 ++++++++++++++++++++++++++++++++++++++++ make.sh | 1 + 3 files changed, 95 insertions(+) create mode 100644 config/rootfiles/packages/iperf3 create mode 100644 lfs/iperf3
Comments
Hi, I would be interested in merging this as more and more people tend to use iperf3 instead of the legacy one. However, the patch has some whitespace issues. Could you resend it like the other ones? Also fix authorship and the other usual things. Regarding the build error: Don't change the release tarball. You can use sed to remove the "-pg" flag from src/Makefile.am and then run autoreconf -vfi. After that run ./configure ... && make && make install and the issue should be gone. gcc -pg would add some debugging information for gprof which is handy for development but not useful in release builds. Best, -Michael On Wed, 2015-12-23 at 14:29 +0100, Jonatan Schlag wrote: > Hi, > I build iPerf3 for IPFire, (for reasons look here: http://forum.ipfire.org/vie > wtopic.php?f=50&t=15498) and was told that i should submit changes to the > mailing list. > > Here is a patch with all changes: > > Signed-off-by: Jonatan Schlag <jonatan@familyschlag.de> > > From a403b42f389cd5617937a0df220c67e279236034 Mon Sep 17 00:00:00 2001 > From: jonaschl <jonnyschlag@gmail.com> > Date: Wed, 23 Dec 2015 13:43:20 +0100 > Subject: [PATCH] new package iPerf 3 > > email: jonnyschlag@gmail.com > author: jonaschl > --- > config/rootfiles/packages/iperf3 | 10 +++++ > lfs/iperf3 | 84 ++++++++++++++++++++++++++++++++++++++++ > make.sh | 1 + > 3 files changed, 95 insertions(+) > create mode 100644 config/rootfiles/packages/iperf3 > create mode 100644 lfs/iperf3 > > diff --git a/config/rootfiles/packages/iperf3 > b/config/rootfiles/packages/iperf3 > new file mode 100644 > index 0000000..717cc96 > --- /dev/null > +++ b/config/rootfiles/packages/iperf3 > @@ -0,0 +1,10 @@ > +usr/bin/iperf3 > +#usr/include/iperf_api.h > +usr/lib/libiperf.a > +usr/lib/libiperf.la > +usr/lib/libiperf.so > +usr/lib/libiperf.so.0 > +usr/lib/libiperf.so.0.0.0 > +#usr/share/man/man1/iperf3.1 > +#usr/share/man/man3/libiperf.3 > + > diff --git a/lfs/iperf3 b/lfs/iperf3 > new file mode 100644 > index 0000000..b8e0cd2 > --- /dev/null > +++ b/lfs/iperf3 > @@ -0,0 +1,84 @@ > +############################################################################# > ## > +# # > +# IPFire.org - A linux based firewall # > +# Copyright (C) 2007-2015 IPFire Team <info@ipfire.org> # > +# # > +# This program is free software: you can redistribute it and/or modify # > +# it under the terms of the GNU General Public License as published by # > +# the Free Software Foundation, either version 3 of the License, or # > +# (at your option) any later version. # > +# # > +# This program is distributed in the hope that it will be useful, # > +# but WITHOUT ANY WARRANTY; without even the implied warranty of # > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # > +# GNU General Public License for more details. # > +# # > +# You should have received a copy of the GNU General Public License # > +# along with this program. If not, see <http://www.gnu.org/licenses/>. # > +# # > +############################################################################# > ## > + > +############################################################################# > ## > +# Definitions > +############################################################################# > ## > + > +include Config > + > +VER = 3.1.1 > + > +THISAPP = iperf3-$(VER) > +DL_FILE = $(THISAPP).tar.gz > +DL_FROM = $(URL_IPFIRE) > +DIR_APP = $(DIR_SRC)/$(THISAPP) > +TARGET = $(DIR_INFO)/$(THISAPP) > +PROG = iperf3 > +PAK_VER = 1 > + > +DEPS = "" > + > +############################################################################# > ## > +# Top-level Rules > +############################################################################# > ## > + > +objects = $(DL_FILE) > + > +$(DL_FILE) = $(DL_FROM)/$(DL_FILE) > + > +$(DL_FILE)_MD5 = 62e3d2a057cca69e88ebfbf35b7483ef > + > +install : $(TARGET) > + > +check : $(patsubst %,$(DIR_CHK)/%,$(objects)) > + > +download :$(patsubst %,$(DIR_DL)/%,$(objects)) > + > +md5 : $(subst %,%_MD5,$(objects)) > + > +dist: > + @$(PAK) > + > +############################################################################# > ## > +# Downloading, checking, md5sum > +############################################################################# > ## > + > +$(patsubst %,$(DIR_CHK)/%,$(objects)) : > + @$(CHECK) > + > +$(patsubst %,$(DIR_DL)/%,$(objects)) : > + @$(LOAD) > + > +$(subst %,%_MD5,$(objects)) : > + @$(MD5) > + > +############################################################################# > ## > +# Installation Details > +############################################################################# > ## > + > +$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) > + @$(PREBUILD) > + @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FILE) > + cd $(DIR_APP) && ./configure --prefix=/usr > + cd $(DIR_APP) && make $(MAKETUNING) > + cd $(DIR_APP) && make install > + @rm -rf $(DIR_APP) > + @$(POSTBUILD) > diff --git a/make.sh b/make.sh > index 39089cd..b184115 100755 > --- a/make.sh > +++ b/make.sh > @@ -740,6 +740,7 @@ buildipfire() { > ipfiremake gutenprint > ipfiremake apcupsd > ipfiremake iperf > + ipfiremake iperf3 > ipfiremake netcat > ipfiremake 7zip > ipfiremake lynis > -- > 2.1.4 > > > I do not know if i do all right, in the moment I am not so familiar with git > and patches. > > In addition I have a question. When I build iPerf 3 I run into a bug (see http > s://github.com/esnet/iperf/issues/337). I modified the source package and now > iPerf 3 build. There are c flags which are incompatible. What is the better > style to modify the source package and use this source package or to create a > patch (what I try but I fail) and use the original source package and patch it > during the build process? The source package what I use in the moment could be > find here: http://forum.ipfire.org/download/file.php?id=1853 > > > > Yours sincerely Jonatan Schlag > > >
Hi, I created a new patch and send it to the mailing list. The build issue is gone with the new compiler. Everything work fine now. Regards Jonatan