diff mbox series

sshd kill all sessions on deamon stop

Message ID	6d9b9a50-4479-422f-a370-540a59fa6959@brecht-schule.hamburg
State	New
Headers	Message-ID: <6d9b9a50-4479-422f-a370-540a59fa6959@brecht-schule.hamburg> Date: Sun, 24 Aug 2025 08:25:22 +0200 Precedence: list Sender: <development@lists.ipfire.org> Mail-Followup-To: <development@lists.ipfire.org> MIME-Version: 1.0 Content-Language: en-US To: development@lists.ipfire.org Cc: Peer Dietzmann <dietzmann@brecht-schule.hamburg> From: Peer Dietzmann <dietzmann@brecht-schule.hamburg> Subject: sshd kill all sessions on deamon stop Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit country: DE(0.00), ip: 2001:678:b28::(-0.17)]; RCVD_IN_DNSWL_MED(-0.20)[84.46.83.131:received]; MAILLIST(-0.18)[generic]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; HAS_LIST_UNSUB(-0.01)[]; RECEIVED_HELO_LOCALHOST(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; ARC_SIGNED(0.00)[ipfire.org:s=202003rsa:i=2]; RCVD_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DMARC_POLICY_ALLOW(0.00)[brecht-schule.hamburg,reject]; TAGGED_FROM(0.00)[bounces-835-patchwork=ipfire.org]; R_SPF_SOFTFAIL(0.00)[~all:c]; MID_RHS_MATCH_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[dietzmann@brecht-schule.hamburg,development@lists.ipfire.org]; FROM_HAS_DN(0.00)[]; RCVD_TLS_LAST(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; ASN(0.00)[asn:204867, ipnet:2001:678:b28::/48, country:DE]; DKIM_TRACE(0.00)[brecht-schule.hamburg:+]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; FORGED_SENDER_MAILLIST(0.00)[]
Series	sshd kill all sessions on deamon stop \| sshd kill all sessions on deamon stop

Commit Message

Peer Dietzmann 24 Aug 2025, 6:25 a.m. UTC

Hi All,

I discovered, that while rebooting an IPFire instance via SSH my 
terminal keeps stuck after the broadcast message because IPFire isn't 
closing all active connection correctly. As it is annoying especially 
when using SSH in SSH connections because all connections have to be 
reopened manually, I thought of adding just one line to the init-script 
that closes all running sessions.

Best regards,

Peer

Comments

Michael Tremer 24 Aug 2025, 12:55 p.m. UTC | #1

Hello Peer,

Thank you for your email.

I understand what you want to achieve here, but I don’t quite unterstand why. Why would those sessions need to be closed?

Your patch would have some other consequences which I don’t think you intend. For example, if someone would install an update using a SSH console and if that update upgrades OpenSSH and restarts it abort the update. The process would terminate the updater and you would be left with an incomplete update.

I suppose what we could think about is to move terminating the SSH daemon before the network is being shut down. Would that fix your problem?

-Michael

> On 24 Aug 2025, at 07:25, Peer Dietzmann <dietzmann@brecht-schule.hamburg> wrote:
> 
> Hi All,
> 
> I discovered, that while rebooting an IPFire instance via SSH my terminal keeps stuck after the broadcast message because IPFire isn't closing all active connection correctly. As it is annoying especially when using SSH in SSH connections because all connections have to be reopened manually, I thought of adding just one line to the init-script that closes all running sessions.
> 
> Best regards,
> 
> Peer
> 
> 
> diff --git a/src/initscripts/system/sshd b/src/initscripts/system/sshd
> index e5a9931af..e69904c61 100644
> --- a/src/initscripts/system/sshd
> +++ b/src/initscripts/system/sshd
> @@ -50,6 +50,7 @@ case "$1" in
>      stop)
>          boot_mesg "Stopping SSH Server..."
>          killproc -p "/var/run/sshd.pid" /usr/sbin/sshd || true
> +        killall sshd-session
>          ;;
> 
>      reload)
> 
>

Peer Dietzmann 24 Aug 2025, 5:59 p.m. UTC | #2

Hi Michael,

On 24/08/2025 14:55, Michael Tremer wrote:
> Hello Peer,
>
> Thank you for your email.
>
> I understand what you want to achieve here, but I don’t quite unterstand why. Why would those sessions need to be closed?
As those sessions aren't restored after a reboot, these sessions are 
then useless and have to be closed anyway. I think this could be done 
automatically by IPFire.
>
> Your patch would have some other consequences which I don’t think you intend. For example, if someone would install an update using a SSH console and if that update upgrades OpenSSH and restarts it abort the update. The process would terminate the updater and you would be left with an incomplete update.
>
> I suppose what we could think about is to move terminating the SSH daemon before the network is being shut down. Would that fix your problem?

I understand your explanation, I was unsure if my patch would also 
affect the updater, but the solution you supposed would also fix the 
problem I tried to solve with my patch. Could you add this to the 
corresponding script?

Thanks in advance!

Best regards,

Peer

>
> -Michael
>
>> On 24 Aug 2025, at 07:25, Peer Dietzmann <dietzmann@brecht-schule.hamburg> wrote:
>>
>> Hi All,
>>
>> I discovered, that while rebooting an IPFire instance via SSH my terminal keeps stuck after the broadcast message because IPFire isn't closing all active connection correctly. As it is annoying especially when using SSH in SSH connections because all connections have to be reopened manually, I thought of adding just one line to the init-script that closes all running sessions.
>>
>> Best regards,
>>
>> Peer
>>
>>
>> diff --git a/src/initscripts/system/sshd b/src/initscripts/system/sshd
>> index e5a9931af..e69904c61 100644
>> --- a/src/initscripts/system/sshd
>> +++ b/src/initscripts/system/sshd
>> @@ -50,6 +50,7 @@ case "$1" in
>>       stop)
>>           boot_mesg "Stopping SSH Server..."
>>           killproc -p "/var/run/sshd.pid" /usr/sbin/sshd || true
>> +        killall sshd-session
>>           ;;
>>
>>       reload)
>>
>>

diff mbox series

Patch

diff --git a/src/initscripts/system/sshd b/src/initscripts/system/sshd
index e5a9931af..e69904c61 100644
--- a/src/initscripts/system/sshd
+++ b/src/initscripts/system/sshd
@@ -50,6 +50,7 @@  case "$1" in
      stop)
          boot_mesg "Stopping SSH Server..."
          killproc -p "/var/run/sshd.pid" /usr/sbin/sshd || true
+        killall sshd-session
          ;;

      reload)