[RFC,1/3] linux: Don't blacklist the DRM modules any more

Message ID 20250427171524.324778-1-michael.tremer@ipfire.org
State Staged
Commit 4fa2ca7575a4de1bec2f211f92335c011f169650
Headers
Series [RFC,1/3] linux: Don't blacklist the DRM modules any more |

Commit Message

Michael Tremer April 27, 2025, 5:15 p.m. UTC
  Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---
 config/rootfiles/common/aarch64/linux |  1 -
 config/rootfiles/common/riscv64/linux |  1 -
 config/rootfiles/common/x86_64/linux  |  1 -
 lfs/linux                             | 13 -------------
 4 files changed, 16 deletions(-)
  

Comments

Adolf Belka June 15, 2025, 6:53 p.m. UTC | #1
Hi Michael,

I just did a test of suricata-8.0.0-rc1 in a 196 build so was also able to test out this patch set for DRM.

My vm console terminal worked and was shown at a higher resolution than previously.

So everything worked fine from my simple test.

Regards,

Adolf.


On 27/04/2025 19:15, Michael Tremer wrote:
> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
> ---
>   config/rootfiles/common/aarch64/linux |  1 -
>   config/rootfiles/common/riscv64/linux |  1 -
>   config/rootfiles/common/x86_64/linux  |  1 -
>   lfs/linux                             | 13 -------------
>   4 files changed, 16 deletions(-)
> 
> diff --git a/config/rootfiles/common/aarch64/linux b/config/rootfiles/common/aarch64/linux
> index 88c528557..ffd22d7a8 100644
> --- a/config/rootfiles/common/aarch64/linux
> +++ b/config/rootfiles/common/aarch64/linux
> @@ -573,7 +573,6 @@ boot/dtb-KVER
>   #boot/dtb-KVER/synaptics/berlin4ct-stb.dtb
>   boot/vmlinuz-KVER
>   #etc/cpufreq-bench.conf
> -etc/modprobe.d/framebuffer.conf
>   etc/modprobe.d/ipv6.conf
>   #lib/modules
>   #lib/modules/KVER
> diff --git a/config/rootfiles/common/riscv64/linux b/config/rootfiles/common/riscv64/linux
> index e1b6c071c..7681cf09a 100644
> --- a/config/rootfiles/common/riscv64/linux
> +++ b/config/rootfiles/common/riscv64/linux
> @@ -13,7 +13,6 @@ boot/dtb-KVER
>   #boot/dtb-KVER/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb
>   boot/vmlinuz-KVER
>   #etc/cpufreq-bench.conf
> -etc/modprobe.d/framebuffer.conf
>   etc/modprobe.d/ipv6.conf
>   #lib/modules
>   #lib/modules/KVER
> diff --git a/config/rootfiles/common/x86_64/linux b/config/rootfiles/common/x86_64/linux
> index aeb8ce71b..7ae6bbaae 100644
> --- a/config/rootfiles/common/x86_64/linux
> +++ b/config/rootfiles/common/x86_64/linux
> @@ -2,7 +2,6 @@ boot/System.map-KVER
>   boot/config-KVER
>   boot/vmlinuz-KVER
>   #etc/cpufreq-bench.conf
> -etc/modprobe.d/framebuffer.conf
>   etc/modprobe.d/ipv6.conf
>   #lib/modules
>   #lib/modules/KVER
> diff --git a/lfs/linux b/lfs/linux
> index f1a436c03..15e279ca9 100644
> --- a/lfs/linux
> +++ b/lfs/linux
> @@ -225,19 +225,6 @@ endif
>   	# Only do this once
>   	cd $(DIR_APP) && install -m 755 usr/gen_init_cpio /sbin/
>   
> -	# disable drm by install drm to /bin/false because i915 ignore blacklisting
> -	echo install drm /bin/false > /etc/modprobe.d/framebuffer.conf
> -
> -	# Blacklist old framebuffer modules
> -	for f in $$(find /lib/modules/$(KVER)/kernel/drivers/video/fbdev/ -name *.ko.xz); do \
> -		echo "blacklist $$(basename $$f)" >> /etc/modprobe.d/framebuffer.conf ; \
> -	done
> -	# Blacklist new drm framebuffer modules
> -	for f in $$(find /lib/modules/$(KVER)/kernel/drivers/gpu/drm -name *.ko.xz); do \
> -		echo "blacklist $$(basename $$f)" >> /etc/modprobe.d/framebuffer.conf ; \
> -	done
> -	sed -i -e "s|.ko.xz||g" /etc/modprobe.d/framebuffer.conf
> -
>   	# Disable ipv6 at runtime
>   	echo "options ipv6 disable_ipv6=1" > /etc/modprobe.d/ipv6.conf
>
  
Michael Tremer June 16, 2025, 8:52 a.m. UTC | #2
Good morning Adolf,

The DRM feedback is very valuable. I don’t think we should be breaking anything, but it would be important to get as much information in as soon as possible.

-Michael

> On 15 Jun 2025, at 19:53, Adolf Belka <adolf.belka@ipfire.org> wrote:
> 
> Hi Michael,
> 
> I just did a test of suricata-8.0.0-rc1 in a 196 build so was also able to test out this patch set for DRM.
> 
> My vm console terminal worked and was shown at a higher resolution than previously.
> 
> So everything worked fine from my simple test.
> 
> Regards,
> 
> Adolf.
> 
> 
> On 27/04/2025 19:15, Michael Tremer wrote:
>> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
>> ---
>>  config/rootfiles/common/aarch64/linux |  1 -
>>  config/rootfiles/common/riscv64/linux |  1 -
>>  config/rootfiles/common/x86_64/linux  |  1 -
>>  lfs/linux                             | 13 -------------
>>  4 files changed, 16 deletions(-)
>> diff --git a/config/rootfiles/common/aarch64/linux b/config/rootfiles/common/aarch64/linux
>> index 88c528557..ffd22d7a8 100644
>> --- a/config/rootfiles/common/aarch64/linux
>> +++ b/config/rootfiles/common/aarch64/linux
>> @@ -573,7 +573,6 @@ boot/dtb-KVER
>>  #boot/dtb-KVER/synaptics/berlin4ct-stb.dtb
>>  boot/vmlinuz-KVER
>>  #etc/cpufreq-bench.conf
>> -etc/modprobe.d/framebuffer.conf
>>  etc/modprobe.d/ipv6.conf
>>  #lib/modules
>>  #lib/modules/KVER
>> diff --git a/config/rootfiles/common/riscv64/linux b/config/rootfiles/common/riscv64/linux
>> index e1b6c071c..7681cf09a 100644
>> --- a/config/rootfiles/common/riscv64/linux
>> +++ b/config/rootfiles/common/riscv64/linux
>> @@ -13,7 +13,6 @@ boot/dtb-KVER
>>  #boot/dtb-KVER/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb
>>  boot/vmlinuz-KVER
>>  #etc/cpufreq-bench.conf
>> -etc/modprobe.d/framebuffer.conf
>>  etc/modprobe.d/ipv6.conf
>>  #lib/modules
>>  #lib/modules/KVER
>> diff --git a/config/rootfiles/common/x86_64/linux b/config/rootfiles/common/x86_64/linux
>> index aeb8ce71b..7ae6bbaae 100644
>> --- a/config/rootfiles/common/x86_64/linux
>> +++ b/config/rootfiles/common/x86_64/linux
>> @@ -2,7 +2,6 @@ boot/System.map-KVER
>>  boot/config-KVER
>>  boot/vmlinuz-KVER
>>  #etc/cpufreq-bench.conf
>> -etc/modprobe.d/framebuffer.conf
>>  etc/modprobe.d/ipv6.conf
>>  #lib/modules
>>  #lib/modules/KVER
>> diff --git a/lfs/linux b/lfs/linux
>> index f1a436c03..15e279ca9 100644
>> --- a/lfs/linux
>> +++ b/lfs/linux
>> @@ -225,19 +225,6 @@ endif
>>   # Only do this once
>>   cd $(DIR_APP) && install -m 755 usr/gen_init_cpio /sbin/
>>  - # disable drm by install drm to /bin/false because i915 ignore blacklisting
>> - echo install drm /bin/false > /etc/modprobe.d/framebuffer.conf
>> -
>> - # Blacklist old framebuffer modules
>> - for f in $$(find /lib/modules/$(KVER)/kernel/drivers/video/fbdev/ -name *.ko.xz); do \
>> - echo "blacklist $$(basename $$f)" >> /etc/modprobe.d/framebuffer.conf ; \
>> - done
>> - # Blacklist new drm framebuffer modules
>> - for f in $$(find /lib/modules/$(KVER)/kernel/drivers/gpu/drm -name *.ko.xz); do \
>> - echo "blacklist $$(basename $$f)" >> /etc/modprobe.d/framebuffer.conf ; \
>> - done
>> - sed -i -e "s|.ko.xz||g" /etc/modprobe.d/framebuffer.conf
>> -
>>   # Disable ipv6 at runtime
>>   echo "options ipv6 disable_ipv6=1" > /etc/modprobe.d/ipv6.conf
>>  
> 
>
  
Adolf Belka June 16, 2025, 11:28 a.m. UTC | #3
Hi Michael,

On 16/06/2025 10:52, Michael Tremer wrote:
> Good morning Adolf,
> 
> The DRM feedback is very valuable. I don’t think we should be breaking anything, but it would be important to get as much information in as soon as possible.

To help with that I have also tested out CU196 Unstable on my Prime physical system.

Everything worked as normal. No problems at all.

In this case the size of the console did not change as it was already taking the whole height of my widescreen monitor with CU195 Testing.

Regards,

Adolf.

> 
> -Michael
> 
>> On 15 Jun 2025, at 19:53, Adolf Belka <adolf.belka@ipfire.org> wrote:
>>
>> Hi Michael,
>>
>> I just did a test of suricata-8.0.0-rc1 in a 196 build so was also able to test out this patch set for DRM.
>>
>> My vm console terminal worked and was shown at a higher resolution than previously.
>>
>> So everything worked fine from my simple test.
>>
>> Regards,
>>
>> Adolf.
>>
>>
>> On 27/04/2025 19:15, Michael Tremer wrote:
>>> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
>>> ---
>>>   config/rootfiles/common/aarch64/linux |  1 -
>>>   config/rootfiles/common/riscv64/linux |  1 -
>>>   config/rootfiles/common/x86_64/linux  |  1 -
>>>   lfs/linux                             | 13 -------------
>>>   4 files changed, 16 deletions(-)
>>> diff --git a/config/rootfiles/common/aarch64/linux b/config/rootfiles/common/aarch64/linux
>>> index 88c528557..ffd22d7a8 100644
>>> --- a/config/rootfiles/common/aarch64/linux
>>> +++ b/config/rootfiles/common/aarch64/linux
>>> @@ -573,7 +573,6 @@ boot/dtb-KVER
>>>   #boot/dtb-KVER/synaptics/berlin4ct-stb.dtb
>>>   boot/vmlinuz-KVER
>>>   #etc/cpufreq-bench.conf
>>> -etc/modprobe.d/framebuffer.conf
>>>   etc/modprobe.d/ipv6.conf
>>>   #lib/modules
>>>   #lib/modules/KVER
>>> diff --git a/config/rootfiles/common/riscv64/linux b/config/rootfiles/common/riscv64/linux
>>> index e1b6c071c..7681cf09a 100644
>>> --- a/config/rootfiles/common/riscv64/linux
>>> +++ b/config/rootfiles/common/riscv64/linux
>>> @@ -13,7 +13,6 @@ boot/dtb-KVER
>>>   #boot/dtb-KVER/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb
>>>   boot/vmlinuz-KVER
>>>   #etc/cpufreq-bench.conf
>>> -etc/modprobe.d/framebuffer.conf
>>>   etc/modprobe.d/ipv6.conf
>>>   #lib/modules
>>>   #lib/modules/KVER
>>> diff --git a/config/rootfiles/common/x86_64/linux b/config/rootfiles/common/x86_64/linux
>>> index aeb8ce71b..7ae6bbaae 100644
>>> --- a/config/rootfiles/common/x86_64/linux
>>> +++ b/config/rootfiles/common/x86_64/linux
>>> @@ -2,7 +2,6 @@ boot/System.map-KVER
>>>   boot/config-KVER
>>>   boot/vmlinuz-KVER
>>>   #etc/cpufreq-bench.conf
>>> -etc/modprobe.d/framebuffer.conf
>>>   etc/modprobe.d/ipv6.conf
>>>   #lib/modules
>>>   #lib/modules/KVER
>>> diff --git a/lfs/linux b/lfs/linux
>>> index f1a436c03..15e279ca9 100644
>>> --- a/lfs/linux
>>> +++ b/lfs/linux
>>> @@ -225,19 +225,6 @@ endif
>>>    # Only do this once
>>>    cd $(DIR_APP) && install -m 755 usr/gen_init_cpio /sbin/
>>>   - # disable drm by install drm to /bin/false because i915 ignore blacklisting
>>> - echo install drm /bin/false > /etc/modprobe.d/framebuffer.conf
>>> -
>>> - # Blacklist old framebuffer modules
>>> - for f in $$(find /lib/modules/$(KVER)/kernel/drivers/video/fbdev/ -name *.ko.xz); do \
>>> - echo "blacklist $$(basename $$f)" >> /etc/modprobe.d/framebuffer.conf ; \
>>> - done
>>> - # Blacklist new drm framebuffer modules
>>> - for f in $$(find /lib/modules/$(KVER)/kernel/drivers/gpu/drm -name *.ko.xz); do \
>>> - echo "blacklist $$(basename $$f)" >> /etc/modprobe.d/framebuffer.conf ; \
>>> - done
>>> - sed -i -e "s|.ko.xz||g" /etc/modprobe.d/framebuffer.conf
>>> -
>>>    # Disable ipv6 at runtime
>>>    echo "options ipv6 disable_ipv6=1" > /etc/modprobe.d/ipv6.conf
>>>   
>>
>>
>
  
Michael Tremer June 16, 2025, 2:27 p.m. UTC | #4
Hello Adolf,

There should actually be some improvement on the Prime and the Duo Appliances at least.

They had some problems when the HDMI port got disconnected from one screen while it was running and connected to another one. Or booted without anything plugged into HDMI and then something got plugged in. They simply could not switch any resolution because of some limitations in the Intel GPU driver. DRM should now support this. I have not tested this, but I strongly hope it does.

-Michael

> On 16 Jun 2025, at 12:28, Adolf Belka <adolf.belka@ipfire.org> wrote:
> 
> Hi Michael,
> 
> On 16/06/2025 10:52, Michael Tremer wrote:
>> Good morning Adolf,
>> The DRM feedback is very valuable. I don’t think we should be breaking anything, but it would be important to get as much information in as soon as possible.
> 
> To help with that I have also tested out CU196 Unstable on my Prime physical system.
> 
> Everything worked as normal. No problems at all.
> 
> In this case the size of the console did not change as it was already taking the whole height of my widescreen monitor with CU195 Testing.
> 
> Regards,
> 
> Adolf.
> 
>> -Michael
>>> On 15 Jun 2025, at 19:53, Adolf Belka <adolf.belka@ipfire.org> wrote:
>>> 
>>> Hi Michael,
>>> 
>>> I just did a test of suricata-8.0.0-rc1 in a 196 build so was also able to test out this patch set for DRM.
>>> 
>>> My vm console terminal worked and was shown at a higher resolution than previously.
>>> 
>>> So everything worked fine from my simple test.
>>> 
>>> Regards,
>>> 
>>> Adolf.
>>> 
>>> 
>>> On 27/04/2025 19:15, Michael Tremer wrote:
>>>> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
>>>> ---
>>>>  config/rootfiles/common/aarch64/linux |  1 -
>>>>  config/rootfiles/common/riscv64/linux |  1 -
>>>>  config/rootfiles/common/x86_64/linux  |  1 -
>>>>  lfs/linux                             | 13 -------------
>>>>  4 files changed, 16 deletions(-)
>>>> diff --git a/config/rootfiles/common/aarch64/linux b/config/rootfiles/common/aarch64/linux
>>>> index 88c528557..ffd22d7a8 100644
>>>> --- a/config/rootfiles/common/aarch64/linux
>>>> +++ b/config/rootfiles/common/aarch64/linux
>>>> @@ -573,7 +573,6 @@ boot/dtb-KVER
>>>>  #boot/dtb-KVER/synaptics/berlin4ct-stb.dtb
>>>>  boot/vmlinuz-KVER
>>>>  #etc/cpufreq-bench.conf
>>>> -etc/modprobe.d/framebuffer.conf
>>>>  etc/modprobe.d/ipv6.conf
>>>>  #lib/modules
>>>>  #lib/modules/KVER
>>>> diff --git a/config/rootfiles/common/riscv64/linux b/config/rootfiles/common/riscv64/linux
>>>> index e1b6c071c..7681cf09a 100644
>>>> --- a/config/rootfiles/common/riscv64/linux
>>>> +++ b/config/rootfiles/common/riscv64/linux
>>>> @@ -13,7 +13,6 @@ boot/dtb-KVER
>>>>  #boot/dtb-KVER/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb
>>>>  boot/vmlinuz-KVER
>>>>  #etc/cpufreq-bench.conf
>>>> -etc/modprobe.d/framebuffer.conf
>>>>  etc/modprobe.d/ipv6.conf
>>>>  #lib/modules
>>>>  #lib/modules/KVER
>>>> diff --git a/config/rootfiles/common/x86_64/linux b/config/rootfiles/common/x86_64/linux
>>>> index aeb8ce71b..7ae6bbaae 100644
>>>> --- a/config/rootfiles/common/x86_64/linux
>>>> +++ b/config/rootfiles/common/x86_64/linux
>>>> @@ -2,7 +2,6 @@ boot/System.map-KVER
>>>>  boot/config-KVER
>>>>  boot/vmlinuz-KVER
>>>>  #etc/cpufreq-bench.conf
>>>> -etc/modprobe.d/framebuffer.conf
>>>>  etc/modprobe.d/ipv6.conf
>>>>  #lib/modules
>>>>  #lib/modules/KVER
>>>> diff --git a/lfs/linux b/lfs/linux
>>>> index f1a436c03..15e279ca9 100644
>>>> --- a/lfs/linux
>>>> +++ b/lfs/linux
>>>> @@ -225,19 +225,6 @@ endif
>>>>   # Only do this once
>>>>   cd $(DIR_APP) && install -m 755 usr/gen_init_cpio /sbin/
>>>>  - # disable drm by install drm to /bin/false because i915 ignore blacklisting
>>>> - echo install drm /bin/false > /etc/modprobe.d/framebuffer.conf
>>>> -
>>>> - # Blacklist old framebuffer modules
>>>> - for f in $$(find /lib/modules/$(KVER)/kernel/drivers/video/fbdev/ -name *.ko.xz); do \
>>>> - echo "blacklist $$(basename $$f)" >> /etc/modprobe.d/framebuffer.conf ; \
>>>> - done
>>>> - # Blacklist new drm framebuffer modules
>>>> - for f in $$(find /lib/modules/$(KVER)/kernel/drivers/gpu/drm -name *.ko.xz); do \
>>>> - echo "blacklist $$(basename $$f)" >> /etc/modprobe.d/framebuffer.conf ; \
>>>> - done
>>>> - sed -i -e "s|.ko.xz||g" /etc/modprobe.d/framebuffer.conf
>>>> -
>>>>   # Disable ipv6 at runtime
>>>>   echo "options ipv6 disable_ipv6=1" > /etc/modprobe.d/ipv6.conf
>>>>  
>>> 
>>> 
>
  

Patch

diff --git a/config/rootfiles/common/aarch64/linux b/config/rootfiles/common/aarch64/linux
index 88c528557..ffd22d7a8 100644
--- a/config/rootfiles/common/aarch64/linux
+++ b/config/rootfiles/common/aarch64/linux
@@ -573,7 +573,6 @@  boot/dtb-KVER
 #boot/dtb-KVER/synaptics/berlin4ct-stb.dtb
 boot/vmlinuz-KVER
 #etc/cpufreq-bench.conf
-etc/modprobe.d/framebuffer.conf
 etc/modprobe.d/ipv6.conf
 #lib/modules
 #lib/modules/KVER
diff --git a/config/rootfiles/common/riscv64/linux b/config/rootfiles/common/riscv64/linux
index e1b6c071c..7681cf09a 100644
--- a/config/rootfiles/common/riscv64/linux
+++ b/config/rootfiles/common/riscv64/linux
@@ -13,7 +13,6 @@  boot/dtb-KVER
 #boot/dtb-KVER/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb
 boot/vmlinuz-KVER
 #etc/cpufreq-bench.conf
-etc/modprobe.d/framebuffer.conf
 etc/modprobe.d/ipv6.conf
 #lib/modules
 #lib/modules/KVER
diff --git a/config/rootfiles/common/x86_64/linux b/config/rootfiles/common/x86_64/linux
index aeb8ce71b..7ae6bbaae 100644
--- a/config/rootfiles/common/x86_64/linux
+++ b/config/rootfiles/common/x86_64/linux
@@ -2,7 +2,6 @@  boot/System.map-KVER
 boot/config-KVER
 boot/vmlinuz-KVER
 #etc/cpufreq-bench.conf
-etc/modprobe.d/framebuffer.conf
 etc/modprobe.d/ipv6.conf
 #lib/modules
 #lib/modules/KVER
diff --git a/lfs/linux b/lfs/linux
index f1a436c03..15e279ca9 100644
--- a/lfs/linux
+++ b/lfs/linux
@@ -225,19 +225,6 @@  endif
 	# Only do this once
 	cd $(DIR_APP) && install -m 755 usr/gen_init_cpio /sbin/
 
-	# disable drm by install drm to /bin/false because i915 ignore blacklisting
-	echo install drm /bin/false > /etc/modprobe.d/framebuffer.conf
-
-	# Blacklist old framebuffer modules
-	for f in $$(find /lib/modules/$(KVER)/kernel/drivers/video/fbdev/ -name *.ko.xz); do \
-		echo "blacklist $$(basename $$f)" >> /etc/modprobe.d/framebuffer.conf ; \
-	done
-	# Blacklist new drm framebuffer modules
-	for f in $$(find /lib/modules/$(KVER)/kernel/drivers/gpu/drm -name *.ko.xz); do \
-		echo "blacklist $$(basename $$f)" >> /etc/modprobe.d/framebuffer.conf ; \
-	done
-	sed -i -e "s|.ko.xz||g" /etc/modprobe.d/framebuffer.conf
-
 	# Disable ipv6 at runtime
 	echo "options ipv6 disable_ipv6=1" > /etc/modprobe.d/ipv6.conf