diff mbox series

[1/2] transmission: revert version back to 4.0.5

Message ID 20250102162926.3561377-1-adolf.belka@ipfire.org
State Accepted
Commit 699abe572f8f4a56191d73d68ef1034b1174b576
Headers
Series [1/2] transmission: revert version back to 4.0.5 |

Commit Message

Adolf Belka Jan. 2, 2025, 4:29 p.m. UTC 
  - Revert back from 4.0.6 to 4.0.5 due to a bug in 4.0.6 that has resulted in a variety
   of torrent mirrors banning transmission-4.0.6
- The update from 4.0.5 to 4.0.6 did not have any security fixes in it so there is no
   issue in moving backward to 4.0.5
- A fix has been created but it is unclear when (and if) version 4.0.7 will be released.
   The fix has also been included in version 4.1.0 but this is still in beta development
   form.
- Version 4.0.6 required minupnpc for building and run time. This reversion is also
   removing miniupnpc in an associated patch in this patch set.
- No change required in the rootfile.

Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 lfs/transmission | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

Comments

Michael Tremer Jan. 2, 2025, 4:43 p.m. UTC | #1
Unaddressed 
Reviewed-by: Michael Tremer <michael.tremer@ipfire.org>

This looks perfect to me.

> On 2 Jan 2025, at 16:29, Adolf Belka <adolf.belka@ipfire.org> wrote:
> 
> - Revert back from 4.0.6 to 4.0.5 due to a bug in 4.0.6 that has resulted in a variety
>   of torrent mirrors banning transmission-4.0.6
> - The update from 4.0.5 to 4.0.6 did not have any security fixes in it so there is no
>   issue in moving backward to 4.0.5
> - A fix has been created but it is unclear when (and if) version 4.0.7 will be released.
>   The fix has also been included in version 4.1.0 but this is still in beta development
>   form.
> - Version 4.0.6 required minupnpc for building and run time. This reversion is also
>   removing miniupnpc in an associated patch in this patch set.
> - No change required in the rootfile.
> 
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
> lfs/transmission | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/lfs/transmission b/lfs/transmission
> index 49e024a13..c95c8b373 100644
> --- a/lfs/transmission
> +++ b/lfs/transmission
> @@ -26,7 +26,7 @@ include Config
> 
> SUMMARY    = A BitTorrent client with multiple UIs
> 
> -VER        = 4.0.6
> +VER        = 4.0.5
> 
> THISAPP    = transmission-$(VER)
> DL_FILE    = $(THISAPP).tar.xz
> @@ -34,9 +34,9 @@ DL_FROM    = $(URL_IPFIRE)
> DIR_APP    = $(DIR_SRC)/$(THISAPP)
> TARGET     = $(DIR_INFO)/$(THISAPP)
> PROG       = transmission
> -PAK_VER    = 24
> +PAK_VER    = 25
> 
> -DEPS       = miniupnpc
> +DEPS       =
> 
> SERVICES   = transmission
> 
> @@ -48,7 +48,7 @@ objects = $(DL_FILE)
> 
> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
> 
> -$(DL_FILE)_BLAKE2 = 3eb1d851322299cb1b79c799f431c09db5aee1be0372fa2877e16508ca6f9e78ea42ed75520ab29a3325e62efcfca63a83559db73c39c981c9e2eddb403ef65a
> +$(DL_FILE)_BLAKE2 = 60caa3bc615137b225d3ac3f25daa352c6960fcc848c91e5ea45488ae109d93b53e314e4683bd7c4ef3f9b2f364d796b6c5bb014ca647d3f44fb5c9df9f8c997
> 
> install : $(TARGET)
> 
> @@ -81,7 +81,6 @@ $(subst %,%_BLAKE2,$(objects)) :
> $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> @$(PREBUILD)
> @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE)
> - cd $(DIR_APP) && patch -Np1 -i $(DIR_SRC)/src/patches/transmission-4.0.6-fix_for_miniupnpc-2.2.8.patch
> cd $(DIR_APP) && cmake . \
> -DCMAKE_INSTALL_PREFIX=/usr \
> -DCMAKE_BUILD_TYPE=Release \
> -- 
> 2.47.1
>
diff mbox series

Patch

diff --git a/lfs/transmission b/lfs/transmission
index 49e024a13..c95c8b373 100644
--- a/lfs/transmission
+++ b/lfs/transmission
@@ -26,7 +26,7 @@  include Config
 
 SUMMARY    = A BitTorrent client with multiple UIs
 
-VER        = 4.0.6
+VER        = 4.0.5
 
 THISAPP    = transmission-$(VER)
 DL_FILE    = $(THISAPP).tar.xz
@@ -34,9 +34,9 @@  DL_FROM    = $(URL_IPFIRE)
 DIR_APP    = $(DIR_SRC)/$(THISAPP)
 TARGET     = $(DIR_INFO)/$(THISAPP)
 PROG       = transmission
-PAK_VER    = 24
+PAK_VER    = 25
 
-DEPS       = miniupnpc
+DEPS       =
 
 SERVICES   = transmission
 
@@ -48,7 +48,7 @@  objects = $(DL_FILE)
 
 $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
 
-$(DL_FILE)_BLAKE2 = 3eb1d851322299cb1b79c799f431c09db5aee1be0372fa2877e16508ca6f9e78ea42ed75520ab29a3325e62efcfca63a83559db73c39c981c9e2eddb403ef65a
+$(DL_FILE)_BLAKE2 = 60caa3bc615137b225d3ac3f25daa352c6960fcc848c91e5ea45488ae109d93b53e314e4683bd7c4ef3f9b2f364d796b6c5bb014ca647d3f44fb5c9df9f8c997
 
 install : $(TARGET)
 
@@ -81,7 +81,6 @@  $(subst %,%_BLAKE2,$(objects)) :
 $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
 	@$(PREBUILD)
 	@rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE)
-	cd $(DIR_APP) && patch -Np1 -i $(DIR_SRC)/src/patches/transmission-4.0.6-fix_for_miniupnpc-2.2.8.patch
 	cd $(DIR_APP) && cmake . \
 			-DCMAKE_INSTALL_PREFIX=/usr \
 			-DCMAKE_BUILD_TYPE=Release \