Message ID | 20210812095148.855-1-hofmann@leo-andres.de |
---|---|
State | Accepted |
Commit | 21a6d0129603f8dd2d1508c8e2d7a7c19d391bb3 |
Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4Glhmm41KQz3xGv for <patchwork@web04.haj.ipfire.org>; Thu, 12 Aug 2021 09:52:08 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4Glhml27Ynz1VW; Thu, 12 Aug 2021 09:52:07 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4Glhml0cMZz2yRy; Thu, 12 Aug 2021 09:52:07 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4Glhmj6fQ2z2xmL for <development@lists.ipfire.org>; Thu, 12 Aug 2021 09:52:05 +0000 (UTC) Received: from arche.uberspace.de (arche.uberspace.de [185.26.156.147]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail01.ipfire.org (Postfix) with ESMTPS id 4Glhmc4Zy7z15L for <development@lists.ipfire.org>; Thu, 12 Aug 2021 09:52:00 +0000 (UTC) Received: (qmail 23058 invoked from network); 12 Aug 2021 09:51:59 -0000 Received: from localhost (HELO localhost) (127.0.0.1) by arche.uberspace.de with SMTP; 12 Aug 2021 09:51:59 -0000 From: Leo-Andres Hofmann <hofmann@leo-andres.de> To: development@lists.ipfire.org Subject: [PATCH] updatexlrator.cgi: Fix max disk usage input size Date: Thu, 12 Aug 2021 11:51:48 +0200 Message-Id: <20210812095148.855-1-hofmann@leo-andres.de> X-Mailer: git-send-email 2.27.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; mail01.ipfire.org; dkim=none; spf=pass (mail01.ipfire.org: domain of hofmann@leo-andres.de designates 185.26.156.147 as permitted sender) smtp.mailfrom=hofmann@leo-andres.de ARC-Seal: i=1; s=202003rsa; d=lists.ipfire.org; t=1628761920; a=rsa-sha256; cv=none; b=Pwr8rPugiWMhpPkzC3NmKX1v1ZihE5xg3ODljv7v6t+k4GqtKB9AAk1MUIumY8nFfnzFTZ HqOlFnLbWoEmQB/pc/1u4TlwcNp6AIaucfz0c406WwLTqN3o8ZZdYWQPHYgjaUmrIt6Zao +aNNuYa6rsV7g9Oa598nD9cczGwjKDYSEBiAavRcXGlTZGZhiGdRn4zzdzVRnOrrnBNbf3 wAOJCKqzYilJKaldZ1RShsNJPi5kWzzkQ1Z+1NcZGiSEjkvCROQibGJFkC5BRt0hQFPzLt vBGOavNP9I3mLgInCp2p1A9G+BNmIdaK1solEqyeDhd5Nl2nyvuR8vid/RQJsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.ipfire.org; s=202003rsa; t=1628761920; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=8QJfwoFDL5rN8LSrGccAP/axaoaVQDBtFpZ8wPMieok=; b=J2TM5ePX4wX/nAFyLkRE61RnV/XIAkyhe+9zBBf+xTRRtq4Jz0i+Apy+oBRY6fsYerc+ag CpfQydvAP1Mik5118FL1j9vlnrI9APapkxspGFsuRnSy/7NJBkdiMaS7dMqd+L0lvh+2eK VPVZP9PqJUEs8AYUbqp1XR4P/BGGIlb/5AWZpp0giCxEOpv5CmnfeYhRjIpGwbscTMqF+8 G3lJrlTFAPYyW/3dIsz0eIf5iwYX8G4Fgy3J0hcexMGtgrqij9jI2mN43IutDTCp6znlvx Qcwr9cRXJLUdKnAxEJWW9T49YBeJhEFrneq1Yco4LzauPcRQaOtw8PZJAFWcww== X-Rspamd-Queue-Id: 4Glhmc4Zy7z15L Authentication-Results: mail01.ipfire.org; dkim=none; dmarc=none; spf=pass (mail01.ipfire.org: domain of hofmann@leo-andres.de designates 185.26.156.147 as permitted sender) smtp.mailfrom=hofmann@leo-andres.de X-Rspamd-Server: mail01.haj.ipfire.org X-Spamd-Result: default: False [1.42 / 11.00]; MX_INVALID(0.50)[]; TO_DN_SOME(0.00)[]; R_MISSING_CHARSET(2.50)[]; IP_REPUTATION_HAM(-0.01)[asn: 205766(0.00), country: DE(-0.01), ip: 185.26.156.147(0.00)]; R_SPF_ALLOW(-0.20)[+mx]; BROKEN_CONTENT_TYPE(1.50)[]; ARC_SIGNED(0.00)[lists.ipfire.org:s=202003rsa:i=1]; RCPT_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:205766, ipnet:185.26.156.0/24, country:DE]; RCVD_TLS_LAST(0.00)[]; BAYES_HAM(-3.00)[99.99%]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; SPF_REPUTATION_HAM(-0.78)[-0.77596786310219]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[leo-andres.de]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MID_CONTAINS_FROM(1.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <https://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <https://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
Series |
updatexlrator.cgi: Fix max disk usage input size
|
|
Commit Message
Leo-Andres Hofmann
Aug. 12, 2021, 9:51 a.m. UTC
Increase to 3 digits to fit a percentage number.
Fixes: #12675
Reported-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Leo-Andres Hofmann <hofmann@leo-andres.de>
---
html/cgi-bin/updatexlrator.cgi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Odd, that this was set to one. Thank you for looking into this problem. -Michael Reviewed-by: Michael Tremer <michael.tremer@ipfire.org> > On 12 Aug 2021, at 10:51, Leo-Andres Hofmann <hofmann@leo-andres.de> wrote: > > Increase to 3 digits to fit a percentage number. > > Fixes: #12675 > > Reported-by: Adolf Belka <adolf.belka@ipfire.org> > Signed-off-by: Leo-Andres Hofmann <hofmann@leo-andres.de> > --- > html/cgi-bin/updatexlrator.cgi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/html/cgi-bin/updatexlrator.cgi b/html/cgi-bin/updatexlrator.cgi > index 9cfe08f4e..4d5cc1370 100644 > --- a/html/cgi-bin/updatexlrator.cgi > +++ b/html/cgi-bin/updatexlrator.cgi > @@ -398,7 +398,7 @@ print <<END > <td class='base'>$Lang::tr{'updxlrtr passive mode'}:</td> > <td class='base'><input type='checkbox' name='PASSIVE_MODE' $checked{'PASSIVE_MODE'}{'on'} /></td> > <td class='base'>$Lang::tr{'updxlrtr max disk usage'}: <img src='/blob.gif' alt='*' /></td> > - <td class='base'><input type='text' name='MAX_DISK_USAGE' value='$xlratorsettings{'MAX_DISK_USAGE'}' size='1' /> %</td> > + <td class='base'><input type='text' name='MAX_DISK_USAGE' value='$xlratorsettings{'MAX_DISK_USAGE'}' size='3' /> %</td> > </tr> > </table> > <hr size='1'> > -- > 2.27.0.windows.1 >
Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org> Am 12.08.2021 um 11:51 schrieb Leo-Andres Hofmann: > Increase to 3 digits to fit a percentage number. > > Fixes: #12675 > > Reported-by: Adolf Belka <adolf.belka@ipfire.org> > Signed-off-by: Leo-Andres Hofmann <hofmann@leo-andres.de> > --- > html/cgi-bin/updatexlrator.cgi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/html/cgi-bin/updatexlrator.cgi b/html/cgi-bin/updatexlrator.cgi > index 9cfe08f4e..4d5cc1370 100644 > --- a/html/cgi-bin/updatexlrator.cgi > +++ b/html/cgi-bin/updatexlrator.cgi > @@ -398,7 +398,7 @@ print <<END > <td class='base'>$Lang::tr{'updxlrtr passive mode'}:</td> > <td class='base'><input type='checkbox' name='PASSIVE_MODE' $checked{'PASSIVE_MODE'}{'on'} /></td> > <td class='base'>$Lang::tr{'updxlrtr max disk usage'}: <img src='/blob.gif' alt='*' /></td> > - <td class='base'><input type='text' name='MAX_DISK_USAGE' value='$xlratorsettings{'MAX_DISK_USAGE'}' size='1' /> %</td> > + <td class='base'><input type='text' name='MAX_DISK_USAGE' value='$xlratorsettings{'MAX_DISK_USAGE'}' size='3' /> %</td> > </tr> > </table> > <hr size='1'> >
diff --git a/html/cgi-bin/updatexlrator.cgi b/html/cgi-bin/updatexlrator.cgi index 9cfe08f4e..4d5cc1370 100644 --- a/html/cgi-bin/updatexlrator.cgi +++ b/html/cgi-bin/updatexlrator.cgi @@ -398,7 +398,7 @@ print <<END <td class='base'>$Lang::tr{'updxlrtr passive mode'}:</td> <td class='base'><input type='checkbox' name='PASSIVE_MODE' $checked{'PASSIVE_MODE'}{'on'} /></td> <td class='base'>$Lang::tr{'updxlrtr max disk usage'}: <img src='/blob.gif' alt='*' /></td> - <td class='base'><input type='text' name='MAX_DISK_USAGE' value='$xlratorsettings{'MAX_DISK_USAGE'}' size='1' /> %</td> + <td class='base'><input type='text' name='MAX_DISK_USAGE' value='$xlratorsettings{'MAX_DISK_USAGE'}' size='3' /> %</td> </tr> </table> <hr size='1'>