mbox

[0/8] debian: Mitigate bulk of Lintian issues

Message ID 20210416130612.15959-1-valter.jansons@gmail.com
Headers

Message

Valters Jansons April 16, 2021, 1:06 p.m. UTC 
  This series breaks apart the previously submitted block of
debian/ changes into individual logical changes, which can
be individually reviewed and discussed, and approved.

This series is however missing the change for d/clean and
d/libloc1.symbols, which are both pending rework as discussed
in the superseded patch.

Valters Jansons (8):
  debian: Add all temporary files to Gitignore
  debian: Move libloc1 to 'libs' section
  debian: Set 'Multi-Arch: foreign' hint for Python
  debian: Update copyright format link to use HTTPS
  debian: Add examples/python/ to documentation
  debian: Drop unintended files from location-python
  debian: Add watch configuration for uscan
  systemd: Add Documentation= to location-update

 debian/.gitignore                      | 9 +++++----
 debian/control                         | 5 +++--
 debian/copyright                       | 2 +-
 debian/location-python.examples        | 1 +
 debian/rules                           | 8 ++++++++
 debian/watch                           | 3 +++
 src/systemd/location-update.service.in | 1 +
 7 files changed, 22 insertions(+), 7 deletions(-)
 create mode 100644 debian/location-python.examples
 create mode 100644 debian/watch

Comments

Valters Jansons July 11, 2021, 5:21 p.m. UTC | #1 
On Tue, May 11, 2021 at 12:41 PM Michael Tremer
<michael.tremer@ipfire.org> wrote:
> I have attached the log files of the build on my machine using the build scripts provided with the package.
>
> Hopefully they have what you are looking for.

Regarding the 'no binaries'/empty location-importer package - that
still seems to be a problem with the 0.9.7 release visible on
packages.ipfire.org. They only contain changelog.Debian.gz and
copyright for all architectures.

This doesn't feel like it should be environment specific, as it
invokes a chroot. I am not able to reproduce this (running the
debian/build.sh) on my Ubuntu Focal (20.04) installation, which runs
the buster target, and produces a location-importer package with a
usr/bin/location-importer and other files.

Is the build environment itself up-to-date? Any available updates for
sbuild, or any other tooling on the host by any chance?

Will have to spin up a Debian Buster VM to test this out then. I have
some sneaking suspicion that buster-backports might be beneficial to
enable on the host.

--Valters
Michael Tremer July 14, 2021, 4:33 p.m. UTC | #2 
Hello,

> On 11 Jul 2021, at 18:21, Valters Jansons <valter.jansons@gmail.com> wrote:
> 
> On Tue, May 11, 2021 at 12:41 PM Michael Tremer
> <michael.tremer@ipfire.org> wrote:
>> I have attached the log files of the build on my machine using the build scripts provided with the package.
>> 
>> Hopefully they have what you are looking for.
> 
> Regarding the 'no binaries'/empty location-importer package - that
> still seems to be a problem with the 0.9.7 release visible on
> packages.ipfire.org. They only contain changelog.Debian.gz and
> copyright for all architectures.

Yes, I can confirm that.

> This doesn't feel like it should be environment specific, as it
> invokes a chroot. I am not able to reproduce this (running the
> debian/build.sh) on my Ubuntu Focal (20.04) installation, which runs
> the buster target, and produces a location-importer package with a
> usr/bin/location-importer and other files.
> 
> Is the build environment itself up-to-date? Any available updates for
> sbuild, or any other tooling on the host by any chance?

I am running “make debian” and I assumed this would always use the latest set of released packages.

> Will have to spin up a Debian Buster VM to test this out then. I have
> some sneaking suspicion that buster-backports might be beneficial to
> enable on the host.

We should virtual environments for all releases and architectures, but please feel free to dig and find what is actually going wrong. I have no clue.

-Michael

> --Valters