IPsec: Remove GUI option for "Roadwarrior virtual IP"
| Message ID | 56047358.4070901@web.de |
|---|---|
| State | Accepted |
| Commit | ed1d0fbdbe0a2c7990ac984ebeed4e74c7bd3955 |
| Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (mail01.tremer.info [172.28.1.200]) by septima.ipfire.org (Postfix) with ESMTP id E137B60171 for <patchwork@ipfire.org>; Fri, 25 Sep 2015 00:04:22 +0200 (CEST) Received: from hedwig.ipfire.org (localhost [IPv6:::1]) by mail01.ipfire.org (Postfix) with ESMTP id 26FEF95F; Fri, 25 Sep 2015 00:04:22 +0200 (CEST) Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=212.227.15.3; helo=mout.web.de; envelope-from=larsen007@web.de; receiver=development@lists.ipfire.org Received: from mout.web.de (mout.web.de [212.227.15.3]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPS id B13981A1 for <development@lists.ipfire.org>; Fri, 25 Sep 2015 00:04:17 +0200 (CEST) Received: from [192.168.178.24] ([2.240.112.143]) by smtp.web.de (mrweb004) with ESMTPSA (Nemesis) id 0M7Eb0-1aZw3C1W5e-00x1E9 for <development@lists.ipfire.org>; Fri, 25 Sep 2015 00:04:16 +0200 To: "development@lists.ipfire.org" <development@lists.ipfire.org> From: Lars Schuhmacher <larsen007@web.de> Subject: [PATCH] IPsec: Remove GUI option for "Roadwarrior virtual IP" Message-ID: <56047358.4070901@web.de> Date: Fri, 25 Sep 2015 00:04:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:8mQa07zJSuvSpANoZUI3wc53Kgga65CPuPcuTkNUz+9R73ylLVd 6xA3AepP0+FbvMO+UeGyxPDLnAu11o0uAVrdzCtXGJzTji1qpcOrsYzvNIc1tZDsCYMMU4n 1vHerxecA7wl2nY+UN3pMDIUmF4qV7LE1jxPq/Q+zo/m737DpDpE+eT4Yi74ISPi0ab4s1U t5dbCZg+V09J9loIHgJqg== X-UI-Out-Filterresults: notjunk:1; V01:K0:7eA4gp1hW9c=:fjf+ydMm1Opncy2q8p9Qda yUl5hsvJ3NmEfxBIqQWCPNdm3WksNTAPGLCOi0Oqe8nscoYSKkfENGIK7zCf1Bsa3UvlQRAoy cemobckx/qeYimVabVa0+x2Oaj5AnorKha4dJBEp8SX8c382ifINKskbTALaOzRfW2mQTv+S6 INZ0FyvxcI4sI1yVsIDdZWO+/qe2/AezcXZ0/38QrD9jdGGaURsF7IrcKPkILju9c5+GDWSC5 4LuKoiA5XOBQVAQRJBKBUMLaGBucF5mhxdFXkIc6OUHPW2rieHoCdkIZATYqyrNYrK9b/qMQ4 +eY6eY/BeBWnxS5WhAEm5iS7uKjiCF5NREsOs7gs94MrkUJ67+Qb/mDLs+o1NiFzdaWlOfeAZ 8btfT3Ck8kui5dl7ZmqivsTUiw8KJCRRoQh89jZSlogPU9iG6FBBoceBtt+mUsMcPtDRJIpbj QUkr3fuhjYZtLx5v7GDDI8BhMXkGOSujjryVt/7u5/ZjMt9v8OrPl8Y3uhkFl+SliKtubYg+j doBa0t5aGj512jtXY/kUXZ0GOCFod+9emIqSi+IaZZ34D1y3ihFwmndlQlIT01GTijazOKzmN k2XwugQY5mZf35C6bWS5ZrX29JVPaPgNy2cDzmjzRbdFf6guPzrYiraaO+0azW6ohrQyohmG3 LcxwlL84vKmPZqVl8p30qm13K8X2oty5+lNm8iiz/d1xcZIln1s4azRzHqFXXGydaZW5mifzA NESgA/dfVtOkFv/9LDc42BT0FNK0/XA5Dtxl0w== X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <http://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <http://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
Message
Lars Schuhmacher
Sept. 25, 2015, 8:04 a.m. UTC
IPsec: Remove GUI option for "Roadwarrior virtual IP"
This setting stems from IPcop (and probably Openswan) and causes a problem. Fixes bug 10496.
Signed-off-by: Lars Schuhmacher <larsen007@web.de>
---
html/cgi-bin/vpnmain.cgi | 32 ++------------------------------
langs/de/cgi-bin/de.pl | 1 -
langs/en/cgi-bin/en.pl | 1 -
langs/es/cgi-bin/es.pl | 1 -
langs/fr/cgi-bin/fr.pl | 1 -
langs/it/cgi-bin/it.pl | 1 -
langs/nl/cgi-bin/nl.pl | 1 -
langs/pl/cgi-bin/pl.pl | 1 -
langs/ru/cgi-bin/ru.pl | 1 -
langs/tr/cgi-bin/tr.pl | 1 -
10 files changed, 2 insertions(+), 39 deletions(-)
Comments
Hello, this patch looks good. I agree that this option should be removed since it is not supported any more and certainly does not work since a long time ago. Could you elaborate a bit more about these problems that were caused? Best, -Michael On Fri, 2015-09-25 at 00:04 +0200, Lars Schuhmacher wrote: > IPsec: Remove GUI option for "Roadwarrior virtual IP" > > This setting stems from IPcop (and probably Openswan) and causes a > problem. Fixes bug 10496. > > Signed-off-by: Lars Schuhmacher <larsen007@web.de> > --- > html/cgi-bin/vpnmain.cgi | 32 ++------------------------------ > langs/de/cgi-bin/de.pl | 1 - > langs/en/cgi-bin/en.pl | 1 - > langs/es/cgi-bin/es.pl | 1 - > langs/fr/cgi-bin/fr.pl | 1 - > langs/it/cgi-bin/it.pl | 1 - > langs/nl/cgi-bin/nl.pl | 1 - > langs/pl/cgi-bin/pl.pl | 1 - > langs/ru/cgi-bin/ru.pl | 1 - > langs/tr/cgi-bin/tr.pl | 1 - > 10 files changed, 2 insertions(+), 39 deletions(-) > > diff --git a/html/cgi-bin/vpnmain.cgi b/html/cgi-bin/vpnmain.cgi > index 65fc80f..5658dac 100644 > --- a/html/cgi-bin/vpnmain.cgi > +++ b/html/cgi-bin/vpnmain.cgi > @@ -235,7 +235,6 @@ sub makeconnname ($) { > ### > ###Type=Host : GUI can choose the interface used (RED,GREEN,BLUE) > and > ### the side is always defined as 'left'. > -### configihash[14]: 'VHOST' is allowed > ### > > sub writeipsecfiles { > @@ -294,8 +293,6 @@ sub writeipsecfiles { > if ($lconfighash{$key}[3] eq 'net') { > my $cidr_net=&General::ipcidr($lconfighash{$key}[11]); > print CONF "\trightsubnet=$cidr_net\n"; > - } elsif ($lconfighash{$key}[10] eq '%any' && > $lconfighash{$key}[14] eq 'on') { #vhost allowed for roadwarriors? > - print CONF "\trightsubnet=vhost:%no,%priv\n"; > } > > # Local Cert and Remote Cert (unless auth is DN dn-auth) > @@ -1246,7 +1243,7 @@ END > &Header::closepage(); > exit (0); > ### > -### Adding/Editing/Saving a connection > +### Adding/Editing/Saving a connection > ### > } elsif (($cgiparams{'ACTION'} eq $Lang::tr{'add'}) || > ($cgiparams{'ACTION'} eq $Lang::tr{'edit'}) || > @@ -1289,7 +1286,6 @@ END > $cgiparams{'COMPRESSION'} = > $confighash{$cgiparams{'KEY'}}[13]; > $cgiparams{'ONLY_PROPOSED'} = > $confighash{$cgiparams{'KEY'}}[24]; > $cgiparams{'PFS'} = > $confighash{$cgiparams{'KEY'}}[28]; > - $cgiparams{'VHOST'} = > $confighash{$cgiparams{'KEY'}}[14]; > $cgiparams{'DPD_TIMEOUT'} = > $confighash{$cgiparams{'KEY'}}[30]; > $cgiparams{'DPD_DELAY'} = > $confighash{$cgiparams{'KEY'}}[31]; > $cgiparams{'FORCE_MOBIKE'} = > $confighash{$cgiparams{'KEY'}}[32]; > @@ -1814,7 +1810,6 @@ END > $confighash{$key}[13] = $cgiparams{'COMPRESSION'}; > $confighash{$key}[24] = $cgiparams{'ONLY_PROPOSED'}; > $confighash{$key}[28] = $cgiparams{'PFS'}; > - $confighash{$key}[14] = $cgiparams{'VHOST'}; > $confighash{$key}[30] = $cgiparams{'DPD_TIMEOUT'}; > $confighash{$key}[31] = $cgiparams{'DPD_DELAY'}; > $confighash{$key}[32] = $cgiparams{'FORCE_MOBIKE'}; > @@ -1891,7 +1886,6 @@ END > $cgiparams{'COMPRESSION'} = 'on'; #[13]; > $cgiparams{'ONLY_PROPOSED'} = 'off'; #[24]; > $cgiparams{'PFS'} = 'on'; #[28]; > - $cgiparams{'VHOST'} = 'on'; #[14]; > } > > VPNCONF_ERROR: > @@ -1943,7 +1937,6 @@ END > <input type='hidden' name='COMPRESSION' > value='$cgiparams{'COMPRESSION'}' /> > <input type='hidden' name='ONLY_PROPOSED' > value='$cgiparams{'ONLY_PROPOSED'}' /> > <input type='hidden' name='PFS' value='$cgiparams{'PFS'}' /> > - <input type='hidden' name='VHOST' > value='$cgiparams{'VHOST'}' /> > <input type='hidden' name='DPD_ACTION' > value='$cgiparams{'DPD_ACTION'}' /> > <input type='hidden' name='DPD_DELAY' > value='$cgiparams{'DPD_DELAY'}' /> > <input type='hidden' name='DPD_TIMEOUT' > value='$cgiparams{'DPD_TIMEOUT'}' /> > @@ -2130,11 +2123,6 @@ if(($cgiparams{'ACTION'} eq > $Lang::tr{'advanced'}) || > } > > if ($cgiparams{'ACTION'} eq $Lang::tr{'save'}) { > - # I didn't read any incompatibilities here.... > - #if ($cgiparams{'VHOST'} eq 'on' && > $cgiparams{'COMPRESSION'} eq 'on') { > - # $errormessage = $Lang::tr{'cannot enable both nat > traversal and compression'}; > - # goto ADVANCED_ERROR; > - #} > my @temp = split('\|', $cgiparams{'IKE_ENCRYPTION'}); > if ($#temp < 0) { > $errormessage = $Lang::tr{'invalid input'}; > @@ -2222,8 +2210,7 @@ if(($cgiparams{'ACTION'} eq > $Lang::tr{'advanced'}) || > ($cgiparams{'COMPRESSION'} !~ /^(|on|off)$/) || > ($cgiparams{'FORCE_MOBIKE'} !~ /^(|on|off)$/) || > ($cgiparams{'ONLY_PROPOSED'} !~ /^(|on|off)$/) || > - ($cgiparams{'PFS'} !~ /^(|on|off)$/) || > - ($cgiparams{'VHOST'} !~ /^(|on|off)$/) > + ($cgiparams{'PFS'} !~ /^(|on|off)$/) > ){ > $errormessage = $Lang::tr{'invalid input'}; > goto ADVANCED_ERROR; > @@ -2252,7 +2239,6 @@ if(($cgiparams{'ACTION'} eq > $Lang::tr{'advanced'}) || > $confighash{$cgiparams{'KEY'}}[13] = > $cgiparams{'COMPRESSION'}; > $confighash{$cgiparams{'KEY'}}[24] = > $cgiparams{'ONLY_PROPOSED'}; > $confighash{$cgiparams{'KEY'}}[28] = $cgiparams{'PFS'}; > - $confighash{$cgiparams{'KEY'}}[14] = $cgiparams{'VHOST'}; > $confighash{$cgiparams{'KEY'}}[27] = > $cgiparams{'DPD_ACTION'}; > $confighash{$cgiparams{'KEY'}}[30] = > $cgiparams{'DPD_TIMEOUT'}; > $confighash{$cgiparams{'KEY'}}[31] = > $cgiparams{'DPD_DELAY'}; > @@ -2280,7 +2266,6 @@ if(($cgiparams{'ACTION'} eq > $Lang::tr{'advanced'}) || > $cgiparams{'COMPRESSION'} = > $confighash{$cgiparams{'KEY'}}[13]; > $cgiparams{'ONLY_PROPOSED'} = > $confighash{$cgiparams{'KEY'}}[24]; > $cgiparams{'PFS'} = > $confighash{$cgiparams{'KEY'}}[28]; > - $cgiparams{'VHOST'} = > $confighash{$cgiparams{'KEY'}}[14]; > $cgiparams{'DPD_ACTION'} = > $confighash{$cgiparams{'KEY'}}[27]; > $cgiparams{'DPD_TIMEOUT'} = > $confighash{$cgiparams{'KEY'}}[30]; > $cgiparams{'DPD_DELAY'} = > $confighash{$cgiparams{'KEY'}}[31]; > @@ -2294,9 +2279,6 @@ if(($cgiparams{'ACTION'} eq > $Lang::tr{'advanced'}) || > $cgiparams{'DPD_TIMEOUT'} = 120; > } > > - if ($confighash{$cgiparams{'KEY'}}[3] eq 'net' || > $confighash{$cgiparams{'KEY'}}[10]) { > - $cgiparams{'VHOST'} = 'off'; > - } > } > > ADVANCED_ERROR: > @@ -2382,7 +2364,6 @@ if(($cgiparams{'ACTION'} eq > $Lang::tr{'advanced'}) || > $checked{'FORCE_MOBIKE'} = $cgiparams{'FORCE_MOBIKE'} eq 'on' ? > "checked='checked'" : '' ; > $checked{'ONLY_PROPOSED'} = $cgiparams{'ONLY_PROPOSED'} eq 'on' > ? "checked='checked'" : '' ; > $checked{'PFS'} = $cgiparams{'PFS'} eq 'on' ? > "checked='checked'" : '' ; > - $checked{'VHOST'} = $cgiparams{'VHOST'} eq 'on' ? > "checked='checked'" : '' ; > > $selected{'IKE_VERSION'}{'ikev1'} = ''; > $selected{'IKE_VERSION'}{'ikev2'} = ''; > @@ -2633,15 +2614,6 @@ if(($cgiparams{'ACTION'} eq > $Lang::tr{'advanced'}) || > </tr> > EOF > ; > - if ($confighash{$cgiparams{'KEY'}}[3] eq 'net') { > - print "<tr><td><input type='hidden' name='VHOST' value='off' > /></td></tr>"; > - } elsif ($confighash{$cgiparams{'KEY'}}[10]) { > - print "<tr><td><label><input type='checkbox' name='VHOST' > $checked{'VHOST'} disabled='disabled' />"; > - print " $Lang::tr{'vpn vhost'}</label></td></tr>"; > - } else { > - print "<tr><td><label><input type='checkbox' name='VHOST' > $checked{'VHOST'} />"; > - print " $Lang::tr{'vpn vhost'}</label></td></tr>"; > - } > > print <<EOF; > <tr> > diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl > index c21bac5..a3c8228 100644 > --- a/langs/de/cgi-bin/de.pl > +++ b/langs/de/cgi-bin/de.pl > @@ -2620,7 +2620,6 @@ > 'vpn statistic n2n' => 'OpenVPN-Netz-zu-Netz-Statistik', > 'vpn statistic rw' => 'OpenVPN-Roadwarrior-Statistik', > 'vpn subjectaltname' => 'Subjekt Alternativer Name', > -'vpn vhost' => 'Roadwarrior virtuelle IP (manchmal auch Inner-IP > genannt)', > 'vpn watch' => 'Netz-zu-Netz VPN neu starten, wenn sich Remote-IP > ändert (DynDNS).', > 'waiting to synchronize clock' => 'Bitte warten, die Uhr wird > synchronisiert', > 'warn when traffic reaches' => 'Warnen wenn Traffic x % erreicht', > diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl > index 783fd0f..55cf228 100644 > --- a/langs/en/cgi-bin/en.pl > +++ b/langs/en/cgi-bin/en.pl > @@ -2664,7 +2664,6 @@ > 'vpn statistic n2n' => 'OpenVPN Net-to-Net Statistics', > 'vpn statistic rw' => 'OpenVPN Roadwarrior Statistics', > 'vpn subjectaltname' => 'Subject Alt Name', > -'vpn vhost' => 'Roadwarrior virtual IP (sometimes called Inner-IP)', > 'vpn watch' => 'Restart net-to-net vpn when remote peer IP changes > (dyndns).', > 'waiting to synchronize clock' => 'Waiting to synchronize clock', > 'warn when traffic reaches' => 'Warn when traffic reaches x %', > diff --git a/langs/es/cgi-bin/es.pl b/langs/es/cgi-bin/es.pl > index c0422b1..e24e75e 100644 > --- a/langs/es/cgi-bin/es.pl > +++ b/langs/es/cgi-bin/es.pl > @@ -2107,7 +2107,6 @@ > 'vpn red name' => 'Dirección IP pública o FQDN para la interfaz RED > o<%defaultroute>', > 'vpn remote id' => 'ID Remoto', > 'vpn subjectaltname' => 'Nombre alternativo en Asunto', > -'vpn vhost' => 'IP virtual Roadwarris (también referida como ip > -interior)', > 'vpn watch' => 'Reinciar vpn net-to-net cuando la ip remota cambie > (dyndns)', > 'waiting to synchronize clock' => 'Esperando sincronización con el > reloj', > 'warn when traffic reaches' => 'Advertir cuando el tráfico alcance x > %', > diff --git a/langs/fr/cgi-bin/fr.pl b/langs/fr/cgi-bin/fr.pl > index 43e69a7..0d173ae 100644 > --- a/langs/fr/cgi-bin/fr.pl > +++ b/langs/fr/cgi-bin/fr.pl > @@ -2111,7 +2111,6 @@ > 'vpn red name' => 'IP publique ou nom de domaine complet pour > l\'interface ROUGE ou <%defaultroute>', > 'vpn remote id' => 'ID Distant', > 'vpn subjectaltname' => 'Subject Alt Name', > -'vpn vhost' => 'IP Virtuelle Roadwarrior (parfois appelée Inner > -IP)', > 'vpn watch' => 'Redémarrer net-to-net VPN si IP hôte distant change > (dyndns).', > 'waiting to synchronize clock' => 'Attendre la synchronisation de > l\'horloge', > 'warn when traffic reaches' => 'Avertir lorsque le trafic atteint x > %', > diff --git a/langs/it/cgi-bin/it.pl b/langs/it/cgi-bin/it.pl > index 0623bd5..950f700 100644 > --- a/langs/it/cgi-bin/it.pl > +++ b/langs/it/cgi-bin/it.pl > @@ -2586,7 +2586,6 @@ > 'vpn red name' => 'IP pubblico o il nome di dominio completo per > l\'interfaccia RED o <%defaultroute>', > 'vpn remote id' => 'Remote ID', > 'vpn subjectaltname' => 'Subject Alt Name', > -'vpn vhost' => 'Roadwarrior virtual IP (sometimes called Inner-IP)', > 'vpn watch' => 'Restart net-to-net vpn when remote peer IP changes > (dyndns).', > 'waiting to synchronize clock' => 'Waiting to synchronize clock', > 'warn when traffic reaches' => 'Warn when traffic reaches x %', > diff --git a/langs/nl/cgi-bin/nl.pl b/langs/nl/cgi-bin/nl.pl > index f748b74..9d90a08 100644 > --- a/langs/nl/cgi-bin/nl.pl > +++ b/langs/nl/cgi-bin/nl.pl > @@ -2529,7 +2529,6 @@ > 'vpn red name' => 'Publiek IP of FQDN voor RODE interface of > <%defaultroute>', > 'vpn remote id' => 'Remote ID', > 'vpn subjectaltname' => 'Onderwerp Alt Naam', > -'vpn vhost' => 'Roadwarrior virtual IP (Ook wel Inner-IP genoemd)', > 'vpn watch' => 'Herstart net-to-net vpn wanneer remote peer IP > verandert (dyndns).', > 'waiting to synchronize clock' => 'Wachten op synchronisatie van > klok', > 'warn when traffic reaches' => 'Waarschuw wanneer verkeer x % > bereikt', > diff --git a/langs/pl/cgi-bin/pl.pl b/langs/pl/cgi-bin/pl.pl > index 30cc81e..47abf2c 100644 > --- a/langs/pl/cgi-bin/pl.pl > +++ b/langs/pl/cgi-bin/pl.pl > @@ -2120,7 +2120,6 @@ > 'vpn red name' => 'Publiczne IP lub FQDN interfejsu RED lub > <%defaultroute>', > 'vpn remote id' => 'Zdalne ID', > 'vpn subjectaltname' => 'Subject Alt Name', > -'vpn vhost' => 'Roadwarrior virtual IP (sometimes called Inner-IP)', > 'vpn watch' => 'Uruchom ponownie vpn net-to-net kiedy zmieni się IP > zdalnej końcówki (dyndns).', > 'waiting to synchronize clock' => 'Oczekiwanie na synchronizację > zegara', > 'warn when traffic reaches' => 'Ostrzegaj kiedy ruch osiągnie x %', > diff --git a/langs/ru/cgi-bin/ru.pl b/langs/ru/cgi-bin/ru.pl > index 8cf985b..6840f81 100644 > --- a/langs/ru/cgi-bin/ru.pl > +++ b/langs/ru/cgi-bin/ru.pl > @@ -2115,7 +2115,6 @@ > 'vpn red name' => 'Внешний IP или FQDN для RED интерфейса или > <%defaultroute>', > 'vpn remote id' => 'Удалённый ID', > 'vpn subjectaltname' => 'Subject Alt Name', > -'vpn vhost' => 'Roadwarrior virtual IP (sometimes called Inner-IP)', > 'vpn watch' => 'Перезапускать net-to-net vpn когда удалённый IP > меняется (dyndns).', > 'waiting to synchronize clock' => 'Ожидается синхронизация', > 'warn when traffic reaches' => 'Предупреждать когда трафик > возрастает до x %', > diff --git a/langs/tr/cgi-bin/tr.pl b/langs/tr/cgi-bin/tr.pl > index 5426a06..782bc00 100644 > --- a/langs/tr/cgi-bin/tr.pl > +++ b/langs/tr/cgi-bin/tr.pl > @@ -2609,7 +2609,6 @@ > 'vpn red name' => 'KIRMIZI arabirim veya <%defaultroute> için gerçek > IP veya FQDN', > 'vpn remote id' => 'Uzak kimlik (ID)', > 'vpn subjectaltname' => 'Alternatif konu adı', > -'vpn vhost' => 'Roadwarrior sanal IP (bazen iç IP olarakta > adlandırılır)', > 'vpn watch' => 'Karşı eş IP değiştirdiğinde (dyndns) ağdan-ağa VPN > bağlantısını yeniden başlat. Bu DPD ye yardımcı olur.', > 'waiting to synchronize clock' => 'Saat eşleştirmesi bekleniyor', > 'warn when traffic reaches' => 'Trafik x % değere ulaştığında uyar',
On Fri, 25 Sep 2015 00:08:11 +0200, Michael Tremer <michael.tremer@ipfire.org> wrote: > > Could you elaborate a bit more about these problems that were caused? Yes, please see https://bugzilla.ipfire.org/show_bug.cgi?id=10496#c3 Lars
On Fri, 2015-09-25 at 00:20 +0200, Larsen wrote: > On Fri, 25 Sep 2015 00:08:11 +0200, Michael Tremer > <michael.tremer@ipfire.org> wrote: > > > > > Could you elaborate a bit more about these problems that were > > caused? > > Yes, please see > https://bugzilla.ipfire.org/show_bug.cgi?id=10496#c3 Thanks. This should be referenced in the patch then, or did I just overlook that? Acked-by: Michael Tremer <michael.tremer@ipfire.org> > > > Lars Best, -Michael
On Fri, 25 Sep 2015 00:23:40 +0200, Michael Tremer <michael.tremer@ipfire.org> wrote: >> Yes, please see >> https://bugzilla.ipfire.org/show_bug.cgi?id=10496#c3 > > Thanks. This should be referenced in the patch then, or did I just > overlook that? Well, I referenced the bug number, not the URL itself.
On Fri, 2015-09-25 at 00:29 +0200, Larsen wrote: > On Fri, 25 Sep 2015 00:23:40 +0200, Michael Tremer > <michael.tremer@ipfire.org> wrote: > > > > Yes, please see > > > https://bugzilla.ipfire.org/show_bug.cgi?id=10496#c3 > > > > Thanks. This should be referenced in the patch then, or did I just > > overlook that? > > Well, I referenced the bug number, not the URL itself. That is fine. I didn't see that. It is getting late... -Michael