From patchwork Thu Apr 11 15:01:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adolf Belka X-Patchwork-Id: 7725 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature ECDSA (secp384r1) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4VFjZT570zz3wwD for ; Thu, 11 Apr 2024 15:01:21 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4VFjZR14nMz1Gx; Thu, 11 Apr 2024 15:01:19 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4VFjZQ5vR3z32qd; Thu, 11 Apr 2024 15:01:18 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4VFjZP2FbJz2ytM for ; Thu, 11 Apr 2024 15:01:17 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4VFjZL1Db1zGf; Thu, 11 Apr 2024 15:01:14 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1712847675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=66YX4ivmE8elh5U7OcoyYT61bgAdyKwQSDqkC8RvJV8=; b=6m3+5vh4a9rJ9FqsSUIA5e8uSyYF1rpuEJhiuFYaNsNVv57QqyB0Mtoh8bc872+xpEQm98 M1ddOYVsx6jCvdBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1712847675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=66YX4ivmE8elh5U7OcoyYT61bgAdyKwQSDqkC8RvJV8=; b=h5j5eJ8Q6SeBoyn/1svQyD4YWnJy0/m7ZJiBPZt7PYry0QzKJ7yuabDHA6phtrOpcCWSqX wFfUX+MNQ0S8auFB7ltnsyNJu9p9njGiQzRTuinmAyv5fwN9XmUY3YRLxIY2419kgjCqQT pjXetDYtGmBePQ40HFY2kQXUNDPZkd1q4I2zFkb9lP4CXosFUZO1lC9V290htVCEBbjTK9 9UeP5pOf4p7nZrbzs6OQoHViFh22HRjgeEwF+72V2K/yNQ6aJ/6ID5QUdizH7JUZSrUBbU 1Tyrw0GS7c/XGMVX/cKNgw+TU+3WSse34brwoAV7Mw4OgPhhVcU9tNJTU0YDzw== From: Adolf Belka To: development@lists.ipfire.org Subject: [PATCH 1/9] ipsec-interfaces: Fixes bug12763 Date: Thu, 11 Apr 2024 17:01:00 +0200 Message-ID: <20240411150108.21573-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Message-ID-Hash: YLD54XA555MWPWV6ZVZFEYV3353MR73A X-Message-ID-Hash: YLD54XA555MWPWV6ZVZFEYV3353MR73A X-MailFrom: adolf.belka@ipfire.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: IPFire development talk Archived-At: <> List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: - Some of the ip route commands are not redirected to null. This causes the "FIB table does not exist" message from bug12763 - This patch makes all ip route commands get redirected to null, preventing the error message from being seen at boot. - One of the ip rule commands is not redirected to null. This causes the "RTNETLINK answers: no such file or directory" message. - This patch makes all ip rule commands get redirected to null, preventing the error message from being seen at boot. - Additional patches in this set ensure that all ip route and ip rule commands in all IPFire code is redirected to null unless the output of the ip route or ip rule command is used in a variable for use elsewhere in the code. - Tested on my vm system and confirmed that the fix in ipsec-interfaces stops the "FIB table does not exist" and "RTNETLINK answers: no such file or directory" messages during boot. Fixes: Bug#12763 Tested-by: Adolf Belka Signed-off-by: Adolf Belka --- src/scripts/ipsec-interfaces | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/scripts/ipsec-interfaces b/src/scripts/ipsec-interfaces index 23512b9bd..974d3ac84 100644 --- a/src/scripts/ipsec-interfaces +++ b/src/scripts/ipsec-interfaces @@ -107,15 +107,15 @@ main() { local interfaces=() # Flush IPsec routes - ip route flush table "${ROUTE_TABLE}" + ip route flush table "${ROUTE_TABLE}" >/dev/null 2>&1 # Remove lookups - ip rule del lookup "${ROUTE_TABLE}" + ip rule del lookup "${ROUTE_TABLE}" >/dev/null 2>&1 # We are done when IPsec is not enabled if [ "${ENABLED}" = "on" ]; then # Enable route table lookup - ip rule add lookup "${ROUTE_TABLE}" prio "${ROUTE_TABLE_PRIO}" + ip rule add lookup "${ROUTE_TABLE}" prio "${ROUTE_TABLE_PRIO}" >/dev/null 2>&1 while IFS="," read -r "${VARS[@]}"; do # Check if the connection is enabled @@ -158,7 +158,7 @@ main() { log "Creating route to ${rightsubnet} (via ${address} and ${RED_INTF})" ip route add table "${ROUTE_TABLE}" "${rightsubnet}" proto static \ - dev "${RED_INTF}" src "${address}" + dev "${RED_INTF}" src "${address}" >/dev/null 2>&1 done # No interface processing required From patchwork Thu Apr 11 15:01:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adolf Belka X-Patchwork-Id: 7726 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4VFjZW50f9z3wwD for ; Thu, 11 Apr 2024 15:01:23 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4VFjZS0qcPz2VB; Thu, 11 Apr 2024 15:01:20 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4VFjZS0Hxsz32qd; Thu, 11 Apr 2024 15:01:20 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4VFjZP3QMGz2ytM for ; Thu, 11 Apr 2024 15:01:17 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4VFjZP21x6z1Jw; Thu, 11 Apr 2024 15:01:17 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1712847677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yXO51YjBgjdryLgJlnNj2wfi+EfeiELHMZyYIMzJ+TE=; b=m0HwII7ukIkSnEpwROjqgJtOxPfoRMNC88y/43QJkRS9Btna7L7X/4kq6SmGmxPDIl8/hd L8u+6QhGkFU/hBDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1712847677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yXO51YjBgjdryLgJlnNj2wfi+EfeiELHMZyYIMzJ+TE=; b=HY+idBc1L0sK3sixCjo0KkVQJQPFsfllLZW/ha2Vsp8FLpRogIKGMVKpzHDa7xe0tISzEe mBmBaasO8P77cYcjQ6cU+jPAz+dR4Ax/6J2z2owdkfda1kjBbKxiv8mA1VWAGAmq2pWlYm HXWrJOQZorf7H3DxLstGtGDUShiuFW1vfdOKd3SDXVUe/x3IRMLj9edzC+NPHJ6azw/xdH gZZ/adLX9KoxNHFjbTSwsxJNQEMizypY6bXEF/Oj5je8B3rUgcW8Gk1jx1uWOAhRJWw/cn gckeKYgV1rIE2Dsi3Z7PfPGWP7L7Q4283VsCqsCXeYZ+Y3mYj1pNpgdQJ4umqA== From: Adolf Belka To: development@lists.ipfire.org Subject: [PATCH 2/9] static-routes: Fixes bug12763 Date: Thu, 11 Apr 2024 17:01:01 +0200 Message-ID: <20240411150108.21573-2-adolf.belka@ipfire.org> In-Reply-To: <20240411150108.21573-1-adolf.belka@ipfire.org> References: <20240411150108.21573-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Message-ID-Hash: ILO4E67KVMQKMVIMZOMUB5W5BHEO535I X-Message-ID-Hash: ILO4E67KVMQKMVIMZOMUB5W5BHEO535I X-MailFrom: adolf.belka@ipfire.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: IPFire development talk Archived-At: <> List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: - This ensures that all ip route and ip rule commands are redirected to null if the output is not used to feed into a variable. - This will prevent any error messages related to empty iproute tables being displayed during boot. - Tested on my vm system and confirmed that the fix in ipsec-interfaces stops the "FIB table does not exist" and "RTNETLINK answers: no such file or directory" messages during boot. Fixes: Bug#12763 Tested-by: Adolf Belka Signed-off-by: Adolf Belka --- src/initscripts/system/static-routes | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/initscripts/system/static-routes b/src/initscripts/system/static-routes index 85785e9af..9aacc8db5 100644 --- a/src/initscripts/system/static-routes +++ b/src/initscripts/system/static-routes @@ -29,14 +29,14 @@ function init_table() { return fi - ip rule add table static + ip rule add table static >/dev/null 2>&1 } function create_all_routes() { local file=${1} shift - # Remote all routes. + # Remove all routes. ip route flush table static >/dev/null 2>&1 local status @@ -54,7 +54,7 @@ function create_all_routes() { continue fi - ip route add ${network} via ${gateway} table static proto static + ip route add ${network} via ${gateway} table static proto static >/dev/null 2>&1 done < ${file} } From patchwork Thu Apr 11 15:01:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adolf Belka X-Patchwork-Id: 7727 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4VFjZX6jCFz3wwD for ; Thu, 11 Apr 2024 15:01:24 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4VFjZT2JLqz2Cp; Thu, 11 Apr 2024 15:01:21 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4VFjZT1pslz30G4; Thu, 11 Apr 2024 15:01:21 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4VFjZP4pkQz32n0 for ; Thu, 11 Apr 2024 15:01:17 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4VFjZP3PrXzGf; Thu, 11 Apr 2024 15:01:17 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1712847677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U4/B1yywFVOa1YeQvaLI3U6yBCtBwzC97tkGp2HTtTs=; b=nXiJxdFH4tg2eBY2yOlYYNlPcrWFajPr/9BJiDt2FOLj4ODKxKoO7Qas2qFqGRkKip562U gTsOch+0W20zmRAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1712847677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U4/B1yywFVOa1YeQvaLI3U6yBCtBwzC97tkGp2HTtTs=; b=je+FNxYXKp2s5fsHoNXCIqnVjll18KTya7zFB3Q6/rtDECoEhRLRnjtCiijr4eEzZUOwuH oYhGw8hPkLwuIo2cxeS8nGI1zt8a2r8/XAG/2/ZCsnPuibCSrdMHqVwvDQlnjqCWfC91wm QT4zIVtWyv2UwXdminEEqwi/NPTpqsow88ssWDk0YJtL486UajirHZHLoFeytBrQyz/f7b WQSWOHN4d/uTAsF9ZRJQgDW6l+zADz0coAw3BEDiYTsOiVXkrYfDo8RDyhf3WXyBmjnSqt zzEj+Y8KHNGPAjcxELAFC5vZWel+KX0s03EsdKcmsumh1Cl8KeE8ayC7IiRx0w== From: Adolf Belka To: development@lists.ipfire.org Subject: [PATCH 3/9] red: Fixes bug12763 Date: Thu, 11 Apr 2024 17:01:02 +0200 Message-ID: <20240411150108.21573-3-adolf.belka@ipfire.org> In-Reply-To: <20240411150108.21573-1-adolf.belka@ipfire.org> References: <20240411150108.21573-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Message-ID-Hash: VOC2BOQKGNH43QOHU2USAGGOLNGGHZCI X-Message-ID-Hash: VOC2BOQKGNH43QOHU2USAGGOLNGGHZCI X-MailFrom: adolf.belka@ipfire.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: IPFire development talk Archived-At: <> List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: - This ensures that all ip route and ip rule commands are redirected to null if the output is not used to feed into a variable. - This will prevent any error messages related to empty iproute tables being displayed during boot if an empty table is accessed. Fixes: Bug#12763 Tested-by: Adolf Belka Signed-off-by: Adolf Belka --- src/initscripts/networking/red | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/initscripts/networking/red b/src/initscripts/networking/red index beb665e5f..51bf95a43 100644 --- a/src/initscripts/networking/red +++ b/src/initscripts/networking/red @@ -129,10 +129,10 @@ case "${1}" in touch /var/ipfire/red/active # Create route to default gateway - ip route add ${GATEWAY} dev ${DEVICE} + ip route add ${GATEWAY} dev ${DEVICE} >/dev/null 2>&1 boot_mesg "Setting up default gateway ${GATEWAY}..." - ip route add default via ${GATEWAY} dev ${DEVICE} + ip route add default via ${GATEWAY} dev ${DEVICE} >/dev/null 2>&1 evaluate_retval if [ -d "/sys/class/net/${DEVICE}" ]; then From patchwork Thu Apr 11 15:01:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adolf Belka X-Patchwork-Id: 7728 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4VFjZY6rhDz3wwq for ; Thu, 11 Apr 2024 15:01:25 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4VFjZV3TJwz4QP; Thu, 11 Apr 2024 15:01:22 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4VFjZV2ynkz30G4; Thu, 11 Apr 2024 15:01:22 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4VFjZP6CFMz32q4 for ; Thu, 11 Apr 2024 15:01:17 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4VFjZP4pPKz1Gx; Thu, 11 Apr 2024 15:01:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1712847677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6VYfav4TlGOirPOxQKpVPagLu692PZty3yfCxCIt1TE=; b=QF1aTTmUhz0ZZ0z+CRJ7GKoTuaLtkzQT/P3Cgg8lSDwHkbi3+yt/F7230lHn9cbCH0UUv+ Sv7UdyK+CYwfTe73keCpptZlOOt34zeqS7tOdPU99KwBnnbZ5l5ORjvQORJj46QfnJX8Sv GalI/qdRVJF8w4PAFbglkpxdQWkF4d3e/HHG9M5W3ns8VYgpkAyaFOjjYKvoOQSGJuoIby PFh1+VZE7tb+8Y+p6XOYwqEmRv6YvRdLIsSOGUofexnuQjUvaf4JJ9rwNxLFixMm/nAfga S8B9ZguARPx5XdTGKWUa8WxOgLS69CD3nbMY2sbxDbMp23XbAqLzeKHDjfPzTQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1712847677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6VYfav4TlGOirPOxQKpVPagLu692PZty3yfCxCIt1TE=; b=N3LZEZQvz45Y850qhtAbYikClDvYQE6ZKOmxj77uBl2zR9qZEWwNuXYEaDVnLh83/TNe4q cLbdg8DhvE0aWeCw== From: Adolf Belka To: development@lists.ipfire.org Subject: [PATCH 4/9] ip-up: Fixes bug12763 Date: Thu, 11 Apr 2024 17:01:03 +0200 Message-ID: <20240411150108.21573-4-adolf.belka@ipfire.org> In-Reply-To: <20240411150108.21573-1-adolf.belka@ipfire.org> References: <20240411150108.21573-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Message-ID-Hash: HDODW2XYXVH37YY4FFOYY4UGSYF6PYPM X-Message-ID-Hash: HDODW2XYXVH37YY4FFOYY4UGSYF6PYPM X-MailFrom: adolf.belka@ipfire.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: IPFire development talk Archived-At: <> List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: - This ensures that all ip route and ip rule commands are redirected to null if the output is not used to feed into a variable. - This will prevent any error messages related to empty iproute tables being displayed during boot if an empty table is accessed. Fixes: Bug#12763 Tested-by: Adolf Belka Signed-off-by: Adolf Belka --- src/ppp/ip-up | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ppp/ip-up b/src/ppp/ip-up index 2e636e72d..5f4ee7726 100644 --- a/src/ppp/ip-up +++ b/src/ppp/ip-up @@ -33,7 +33,7 @@ echo -n "$4" > /var/ipfire/red/local-ipaddress echo -n "$5" > /var/ipfire/red/remote-ipaddress touch /var/ipfire/red/active -/sbin/ip route replace default via ${IPREMOTE} dev ppp0 +/sbin/ip route replace default via ${IPREMOTE} dev ppp0 >/dev/null 2>&1 run_subdir ${rc_base}/init.d/networking/red.up/ #Check if gateway has answerd to ping, if not replace with ping.ipfire.org From patchwork Thu Apr 11 15:01:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adolf Belka X-Patchwork-Id: 7729 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4VFjZc6t8rz3wwD for ; Thu, 11 Apr 2024 15:01:28 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4VFjZY4fJWz5VN; Thu, 11 Apr 2024 15:01:25 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4VFjZY40yWz32qT; Thu, 11 Apr 2024 15:01:25 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4VFjZQ0Tr8z32qL for ; Thu, 11 Apr 2024 15:01:18 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4VFjZP6CJqzGf; Thu, 11 Apr 2024 15:01:17 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1712847677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uFRFoQJrXtur6OfMURUPITgYQ7mh3ZyExIUnSk7t9xs=; b=n2N2GvGsiWRYJ42iquYvF4iJ9DI7DQl12tq4cVhWRkGWSPgHqoppLIgua/TrLEstCEWcAg VzAqW9MbhOT2lJCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1712847677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uFRFoQJrXtur6OfMURUPITgYQ7mh3ZyExIUnSk7t9xs=; b=qWEI1DlwPx9fRTNxTfNbucQ77KrOsOE0Q4ziPEYp1Pm4xfhLmgARY5E9RE2DQ3fv6ODBl3 OLTltA/WAVxQojCO6iBD/XY588QY0jxRILggWcE3ZMEP3QVEHW//i79IaEHaEpZvcb52PI cTOIZ9dLWrDLMSxT0wrzZmd7Q1LMTM6zhdTRyg7NBtP2rUK+ndnMy4hoYnoHK5Oi5d/Rr6 P8PkLmDaMxw+GTf7vCGY0xk2q6aHGEG1bOwX5T7mIfONjs8OAfAskmuOTUBZ1LgKGH66re 4j3lynHky750GahM5a6pjTP7VsMTmi/lMMLFIIcl5m+KBT4bXzRDlK7ulQCPMA== From: Adolf Belka To: development@lists.ipfire.org Subject: [PATCH 5/9] aws-setup: Fixes bug12763 Date: Thu, 11 Apr 2024 17:01:04 +0200 Message-ID: <20240411150108.21573-5-adolf.belka@ipfire.org> In-Reply-To: <20240411150108.21573-1-adolf.belka@ipfire.org> References: <20240411150108.21573-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Message-ID-Hash: 4LC33CURD7M2JSRGIK56TEZQMZUP5K5J X-Message-ID-Hash: 4LC33CURD7M2JSRGIK56TEZQMZUP5K5J X-MailFrom: adolf.belka@ipfire.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: IPFire development talk Archived-At: <> List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: - This ensures that all ip route and ip rule commands are redirected to null if the output is not used to feed into a variable. - This will prevent any error messages related to empty iproute tables being displayed during boot if an empty table is accessed. Fixes: Bug#12763 Tested-by: Adolf Belka Signed-off-by: Adolf Belka --- src/initscripts/helper/aws-setup | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/initscripts/helper/aws-setup b/src/initscripts/helper/aws-setup index f14f4eb57..0bcf75572 100644 --- a/src/initscripts/helper/aws-setup +++ b/src/initscripts/helper/aws-setup @@ -278,7 +278,7 @@ case "${reason}" in ip addr add "${new_ip_address}/${new_subnet_mask}" dev "${interface}" # Add the default route - ip route add default via "${new_routers}" + ip route add default via "${new_routers}" >/dev/null 2>&1 # Setup DNS for domain_name_server in ${new_domain_name_servers}; do From patchwork Thu Apr 11 15:01:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adolf Belka X-Patchwork-Id: 7730 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4VFjZt1KHfz3wwD for ; Thu, 11 Apr 2024 15:01:42 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4VFjZc6jkJz5XX; Thu, 11 Apr 2024 15:01:28 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4VFjZZ5FtYz32qT; Thu, 11 Apr 2024 15:01:26 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4VFjZQ1tJpz32qL for ; Thu, 11 Apr 2024 15:01:18 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4VFjZQ0Tw6z1Gx; Thu, 11 Apr 2024 15:01:18 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1712847678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GHsaisqKV4CphJXmEJ3ohbNa2MiiewSeq5Ip3qOoN4s=; b=/8MP1OyFrZ94o1RM+a9ozBtpBh4uiKcxk3tt1sLa8LuSkQTon99cBS6MC9COrOWkMB9hso scH6m1F3sUbLtrDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1712847678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GHsaisqKV4CphJXmEJ3ohbNa2MiiewSeq5Ip3qOoN4s=; b=thZk7Rg+nbVnz3gzm1pVEHY+o00mn9kPCtafKozj4wNwIw/NIoc21rOAUIgRybI4lH+E37 9d7XRyFGBfvSHPi6Gvjx70XMEhv6rSPwuN08y8ytA+hGVCvqOJZA0LlBSLa55fsOef2ec8 pFSyrnRpWjJ6Nii/ZWB6de2HNUSNNyTq2j79zqX8rpNeJff09U5oZ8bd/bRIcp2Ov40PFl PrNHhr3sdpRRaANkQnDAH9gAKuHtByhjMRhJ+HW7vTwU/drlgRHRXT/hSmf6nnq0H9y+89 QSLwcnkOYuMlp7cIV4KV4ZKPcHXfGwsK8vOQfTXH2zr9yZHghOKvELE+SvbRiw== From: Adolf Belka To: development@lists.ipfire.org Subject: [PATCH 6/9] azure-setup: Fixes bug12763 Date: Thu, 11 Apr 2024 17:01:05 +0200 Message-ID: <20240411150108.21573-6-adolf.belka@ipfire.org> In-Reply-To: <20240411150108.21573-1-adolf.belka@ipfire.org> References: <20240411150108.21573-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Message-ID-Hash: 5ZLA4T2667MEVVZ4U7A52NKKVZF7QL4P X-Message-ID-Hash: 5ZLA4T2667MEVVZ4U7A52NKKVZF7QL4P X-MailFrom: adolf.belka@ipfire.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: IPFire development talk Archived-At: <> List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: - This ensures that all ip route and ip rule commands are redirected to null if the output is not used to feed into a variable. - This will prevent any error messages related to empty iproute tables being displayed during boot if an empty table is accessed. Fixes: Bug#12763 Tested-by: Adolf Belka Signed-off-by: Adolf Belka --- src/initscripts/helper/azure-setup | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/initscripts/helper/azure-setup b/src/initscripts/helper/azure-setup index 7a4422a35..eff963a4b 100644 --- a/src/initscripts/helper/azure-setup +++ b/src/initscripts/helper/azure-setup @@ -298,7 +298,7 @@ case "${reason}" in ip addr add "${new_ip_address}/${new_subnet_mask}" dev "${interface}" # Add the default route - ip route add default via "${new_routers}" + ip route add default via "${new_routers}" >/dev/null 2>&1 # Setup DNS for domain_name_server in ${new_domain_name_servers}; do From patchwork Thu Apr 11 15:01:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adolf Belka X-Patchwork-Id: 7731 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4VFjZt5KFqz3wwq for ; Thu, 11 Apr 2024 15:01:42 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4VFjZt1z2gz5Tt; Thu, 11 Apr 2024 15:01:42 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4VFjZg6lHrz32qW; Thu, 11 Apr 2024 15:01:31 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4VFjZQ3Gssz32qT for ; Thu, 11 Apr 2024 15:01:18 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4VFjZQ1tFrzGf; Thu, 11 Apr 2024 15:01:18 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1712847678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fp84PJny4sVpQUS7LFysDgWaFZ3C8I1r8+18iiA3RvI=; b=1X35O18TEYqK5d9as0j1gUoCqNO2Vo1fvWu7L5OJHiSGS0AvUI2xDIdGO+Wrd64AaQ/UWJ k0TrP473zg0nDQCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1712847678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fp84PJny4sVpQUS7LFysDgWaFZ3C8I1r8+18iiA3RvI=; b=NZGwtmADYmukJSnJmQJtJX4F+qmhAuSpxXxE+gLqkvXgLzDgPimIQCL516eJbUBgyujVDb hftix/iLd2odkoyi/M8Xnjpvvr03/boM7ao4BxLXoXzlY21IKNy/ebe2zmZIrBPAggFIms 1Kjlisl6lwMFRDMU6iLBt0n7jZ0NCNDDhakjFyrr/9nP9nojmKcEGy5EZ2r/ob+FRozRgq 1xO/4KBuEHUIRZ0aMUhxAIUVsy1e/GllfC0qg40/t3fHeCcn4K0Xo9rA4O9Dlhasm5oEDw lSspK99jkyy2Vk4F4CtuwUdeVRrLNdzOihmRLiR4/5YMESq94fdF1OXqF1qjpw== From: Adolf Belka To: development@lists.ipfire.org Subject: [PATCH 7/9] exoscale-setup: Fixes bug12763 Date: Thu, 11 Apr 2024 17:01:06 +0200 Message-ID: <20240411150108.21573-7-adolf.belka@ipfire.org> In-Reply-To: <20240411150108.21573-1-adolf.belka@ipfire.org> References: <20240411150108.21573-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Message-ID-Hash: UE2SZQRFIR437ZH476HQAFFTI7XCM7NW X-Message-ID-Hash: UE2SZQRFIR437ZH476HQAFFTI7XCM7NW X-MailFrom: adolf.belka@ipfire.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: IPFire development talk Archived-At: <> List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: - This ensures that all ip route and ip rule commands are redirected to null if the output is not used to feed into a variable. - This will prevent any error messages related to empty iproute tables being displayed during boot if an empty table is accessed. Fixes: Bug#12763 Tested-by: Adolf Belka Signed-off-by: Adolf Belka --- src/initscripts/helper/exoscale-setup | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/initscripts/helper/exoscale-setup b/src/initscripts/helper/exoscale-setup index 02fdda2a3..acf5e4e4b 100644 --- a/src/initscripts/helper/exoscale-setup +++ b/src/initscripts/helper/exoscale-setup @@ -227,7 +227,7 @@ case "${reason}" in ip addr add "${new_ip_address}/${new_subnet_mask}" dev "${interface}" # Add the default route - ip route add default via "${new_routers}" + ip route add default via "${new_routers}" >/dev/null 2>&1 # Setup DNS for domain_name_server in ${new_domain_name_servers}; do From patchwork Thu Apr 11 15:01:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adolf Belka X-Patchwork-Id: 7732 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4VFjZv1Kpdz3wyH for ; Thu, 11 Apr 2024 15:01:43 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4VFjZt4blSz5Vt; Thu, 11 Apr 2024 15:01:42 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4VFjZh0bmfz32qw; Thu, 11 Apr 2024 15:01:32 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4VFjZQ4hmLz30GW for ; Thu, 11 Apr 2024 15:01:18 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4VFjZQ3GmCz1Gx; Thu, 11 Apr 2024 15:01:18 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1712847678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mr7PFkTxMUpRXPlekSrLA9vfjSfdgIOohWxkpiPLgx0=; b=4m8TOwSs29pP9KV+35cbxLRy7oZfQMY2Dn/crnWyqj9Yse1tHwzSBt25xgnZLTeOgdTiGv eZriRHPdIeiC4qDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1712847678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mr7PFkTxMUpRXPlekSrLA9vfjSfdgIOohWxkpiPLgx0=; b=YEG6HniYgDM2yL6dVytg75oV2dFygbJ2ZE3Cp3CYrGcj6roDI0o796PB0WBuJIyPjtWnik sefLGtA3XaoX5YTQ1ahUe8c3A9XjL7aKhpcb7/OlEMov75DxFHymLLzVlm8D8RHsHw2ZpB 7P/RUXgA1TAz2xi/J1DjJyr+UR5YP6RFzq3VlZAHqZ+yWUk8htaIXehVAsl347g2YPTXRW v4FP1M5a7b7l84unahEoZMr9kLv8nsDo9khPQ4q/PeVurVyNxhjhW0cC6CHbfp1Q83qN+2 ybbpF8TVX/h8a+fsvUNH5usK1UfTmPlQVvpB2YI+d1EYx4Yul0NnqThvJZ1gzA== From: Adolf Belka To: development@lists.ipfire.org Subject: [PATCH 8/9] gcp-setup: Fixes bug12763 Date: Thu, 11 Apr 2024 17:01:07 +0200 Message-ID: <20240411150108.21573-8-adolf.belka@ipfire.org> In-Reply-To: <20240411150108.21573-1-adolf.belka@ipfire.org> References: <20240411150108.21573-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Message-ID-Hash: IA6X46A3RJVVKUELFYHH5W4S5M4F2TG6 X-Message-ID-Hash: IA6X46A3RJVVKUELFYHH5W4S5M4F2TG6 X-MailFrom: adolf.belka@ipfire.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: IPFire development talk Archived-At: <> List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: - This ensures that all ip route and ip rule commands are redirected to null if the output is not used to feed into a variable. - This will prevent any error messages related to empty iproute tables being displayed during boot if an empty table is accessed. Fixes: Bug#12763 Tested-by: Adolf Belka Signed-off-by: Adolf Belka --- src/initscripts/helper/gcp-setup | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/initscripts/helper/gcp-setup b/src/initscripts/helper/gcp-setup index 4f5148c3e..8273b70b4 100644 --- a/src/initscripts/helper/gcp-setup +++ b/src/initscripts/helper/gcp-setup @@ -268,8 +268,8 @@ case "${reason}" in ip addr add "${new_ip_address}/${new_subnet_mask}" dev "${interface}" # Add the default route - ip route add "${new_routers}" dev "${interface}" - ip route add default via "${new_routers}" + ip route add "${new_routers}" dev "${interface}" >/dev/null 2>&1 + ip route add default via "${new_routers}" >/dev/null 2>&1 # Setup DNS for domain_name_server in ${new_domain_name_servers}; do From patchwork Thu Apr 11 15:01:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adolf Belka X-Patchwork-Id: 7733 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4VFjZv5ycLz3wwD for ; Thu, 11 Apr 2024 15:01:43 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4VFjZt6T99z5VR; Thu, 11 Apr 2024 15:01:42 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4VFjZj26cbz32jQ; Thu, 11 Apr 2024 15:01:33 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4VFjZQ697Jz32ql for ; Thu, 11 Apr 2024 15:01:18 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4VFjZQ4j4XzGf; Thu, 11 Apr 2024 15:01:18 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1712847678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P6Tv9SfDn+CBKuNWCLZwem0xkZ0/CZt9ZrE0D3CncxQ=; b=KbnoQx0o3KLh+vPkhp5gvXDC6eu9r2+l5CGaEyarXXMaiCJxvrpNBz4HZ0+XVd1+h6tv0z CRyJsw0p1OvnbCBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1712847678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P6Tv9SfDn+CBKuNWCLZwem0xkZ0/CZt9ZrE0D3CncxQ=; b=ifSYgIGr2OWth6fv8hT8nQOyiKMStpyE2y+PYWXunAsBsgqikFL2mU5lF56n94lkCNGuCO MexusuRIZew8UmZ+t501Nz40LZnHmcwykg0Fs0IIblryd0DCMLp5y9MkXW/QkE0GLpfQA6 Ywde7eWGagJajYv4H1BzPdZrCtA7hgHI/fiWDbgTN9EfRW4XZW1gAIpb54jZV2fPlsMH66 8mzLR+1pQWj5XROvU5QxKQFVyMFpTWS0/qC+odor7zWSIS7O1JhCMg/8Y9GFulQ0ZWw2Zh AIpdoPeEv2qcEzxRc/7tUvV5mE23HrviN2oL5KxkUKdTJBWc6tAaIY3sRTA3EQ== From: Adolf Belka To: development@lists.ipfire.org Subject: [PATCH 9/9] oci-setup: Fixes bug12763 Date: Thu, 11 Apr 2024 17:01:08 +0200 Message-ID: <20240411150108.21573-9-adolf.belka@ipfire.org> In-Reply-To: <20240411150108.21573-1-adolf.belka@ipfire.org> References: <20240411150108.21573-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Message-ID-Hash: VPGFBI4EAI3WHPJYGB42XNX634UBIINB X-Message-ID-Hash: VPGFBI4EAI3WHPJYGB42XNX634UBIINB X-MailFrom: adolf.belka@ipfire.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: IPFire development talk Archived-At: <> List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: - This ensures that all ip route and ip rule commands are redirected to null if the output is not used to feed into a variable. - This will prevent any error messages related to empty iproute tables being displayed during boot if an empty table is accessed. Fixes: Bug#12763 Tested-by: Adolf Belka Signed-off-by: Adolf Belka --- src/initscripts/helper/oci-setup | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/initscripts/helper/oci-setup b/src/initscripts/helper/oci-setup index 312014b74..727537343 100644 --- a/src/initscripts/helper/oci-setup +++ b/src/initscripts/helper/oci-setup @@ -304,8 +304,8 @@ case "${reason}" in ip addr add "${new_ip_address}/${new_subnet_mask}" dev "${interface}" # Add the default route - ip route add "${new_routers}" dev "${interface}" - ip route add default via "${new_routers}" + ip route add "${new_routers}" dev "${interface}" >/dev/null 2>&1 + ip route add default via "${new_routers}" >/dev/null 2>&1 # Setup DNS for domain_name_server in ${new_domain_name_servers}; do