diff mbox series

zoneconf.cgi: Skip checks for non-existing zones

Message ID 20200406173838.23960-1-michael.tremer@ipfire.org
State Accepted
Commit bb90622c2cfdd7b3bbbabcdbba8a573a36d9edc1
Headers
Series zoneconf.cgi: Skip checks for non-existing zones |

Commit Message

Michael Tremer April 6, 2020, 5:38 p.m. UTC 
  On systems with RED on PPP and no BLUE or ORANGE zones,
there would always be an error when handling non-existant input.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---
 html/cgi-bin/zoneconf.cgi | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/html/cgi-bin/zoneconf.cgi b/html/cgi-bin/zoneconf.cgi
index 6b8642818..d99a3e611 100644
--- a/html/cgi-bin/zoneconf.cgi
+++ b/html/cgi-bin/zoneconf.cgi
@@ -211,6 +211,8 @@  if ($cgiparams{"ACTION"} eq $Lang::tr{"save"}) {
 			my $mac = $_->[0];
 			my $nic_access = $cgiparams{"ACCESS $uc $mac"};
 
+			next unless ($nic_access);
+
 			if ($nic_access ne "NONE") {
 				if ($VALIDATE_nic_check{"RESTRICT $mac"}) { # If this interface is already assigned to RED in PPP mode, throw an error
 					$VALIDATE_error = $Lang::tr{"zoneconf val ppp assignment error"};