BUG11177: pppoe password not required anymore
Message ID | 1473316618-18264-1-git-send-email-alexander.marx@ipfire.org |
---|---|
State | Accepted |
Commit | 3364c93e37c65ed8544066ed55afe1941b2b6f8d |
Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (hedwig.ipfire.org [172.28.1.200]) by web02.ipfire.org (Postfix) with ESMTP id 8B42B61E15 for <patchwork@ipfire.org>; Thu, 8 Sep 2016 08:37:21 +0200 (CEST) Received: from mail01.ipfire.org (localhost [IPv6:::1]) by mail01.ipfire.org (Postfix) with ESMTP id 72C46A21; Thu, 8 Sep 2016 08:37:13 +0200 (CEST) Received: from EDV.kappeln2011.lan (ip1f113d5a.dynamic.kabel-deutschland.de [31.17.61.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 0F9347DD; Thu, 8 Sep 2016 08:37:01 +0200 (CEST) From: Alexander Marx <alexander.marx@ipfire.org> To: development@lists.ipfire.org Subject: [PATCH] BUG11177: pppoe password not required anymore Date: Thu, 8 Sep 2016 08:36:58 +0200 Message-Id: <1473316618-18264-1-git-send-email-alexander.marx@ipfire.org> X-Mailer: git-send-email 2.7.4 X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <http://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <http://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
Message
Alexander Marx
Sept. 8, 2016, 4:36 p.m. UTC
fixes: #11177
There are providers which do not use passwords anymore.
For this reason the password field is no longer mandatory.
Signed-off-by: Alexander Marx <alexander.marx@ipfire.org>
---
html/cgi-bin/pppsetup.cgi | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
Comments
Thanks. That was quick. On Thu, 2016-09-08 at 08:36 +0200, Alexander Marx wrote: > fixes: #11177 > > There are providers which do not use passwords anymore. > For this reason the password field is no longer mandatory. > > Signed-off-by: Alexander Marx <alexander.marx@ipfire.org> > --- > html/cgi-bin/pppsetup.cgi | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/html/cgi-bin/pppsetup.cgi b/html/cgi-bin/pppsetup.cgi > index 36d0ced..4b45ee5 100644 > --- a/html/cgi-bin/pppsetup.cgi > +++ b/html/cgi-bin/pppsetup.cgi > @@ -103,10 +103,7 @@ elsif ($pppsettings{'ACTION'} eq $Lang::tr{'save'}) > if ($pppsettings{'USERNAME'} eq '') { > $errormessage = $Lang::tr{'username not set'}; > goto ERROR; } > - if ($pppsettings{'PASSWORD'} eq '') { > - $errormessage = $Lang::tr{'password not set'}; > - goto ERROR; } > - } > + } > > if ($pppsettings{'TIMEOUT'} eq '') { > $errormessage = $Lang::tr{'idle timeout not set'}; > @@ -927,7 +924,7 @@ print <<END > <tr> > <td width='25%'>$Lang::tr{'username'} <img src='/blob.gif' > alt='*' /></td> > <td width='25%'><input type='text' name='USERNAME' > value='$pppsettings{'USERNAME'}' /></td> > - <td width='25%'>$Lang::tr{'password'} <img src='/blob.gif' > alt='*' /></td> > + <td width='25%'>$Lang::tr{'password'} </td> > <td width='25%'><input type='password' name='PASSWORD' > value='$pppsettings{'PASSWORD'}' /></td> > </tr> > <tr>