rules.pl: fix missing blank in 'if'-condition
Message ID | 20170819113058.25195-1-matthias.fischer@ipfire.org |
---|---|
State | Deferred |
Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (unknown [172.28.1.200]) by web02.ipfire.org (Postfix) with ESMTP id 6B500627AC for <patchwork@ipfire.org>; Sat, 19 Aug 2017 13:31:05 +0200 (CEST) Received: from mail01.ipfire.org (localhost [IPv6:::1]) by mail01.ipfire.org (Postfix) with ESMTP id 2B871248B; Sat, 19 Aug 2017 13:31:04 +0200 (CEST) Received: from Devel.localdomain (p5DD82971.dip0.t-ipconnect.de [93.216.41.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 3A241248B for <development@lists.ipfire.org>; Sat, 19 Aug 2017 13:31:02 +0200 (CEST) From: Matthias Fischer <matthias.fischer@ipfire.org> To: development@lists.ipfire.org Subject: [PATCH] rules.pl: fix missing blank in 'if'-condition Date: Sat, 19 Aug 2017 13:30:58 +0200 Message-Id: <20170819113058.25195-1-matthias.fischer@ipfire.org> X-Mailer: git-send-email 2.14.1 X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <http://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <http://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
Message
Matthias Fischer
Aug. 19, 2017, 9:30 p.m. UTC
Triggered by https://forum.ipfire.org/viewtopic.php?f=22&t=19304
Best,
Matthias
Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org>
---
config/firewall/rules.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi, this has been set to deferred on Patchwork. Why? Best, -Michael On Sat, 2017-08-19 at 13:30 +0200, Matthias Fischer wrote: > Triggered by https://forum.ipfire.org/viewtopic.php?f=22&t=19304 > > Best, > Matthias > > Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org> > --- > config/firewall/rules.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/config/firewall/rules.pl b/config/firewall/rules.pl > index 8b0c6ddc8..efbe9cfef 100644 > --- a/config/firewall/rules.pl > +++ b/config/firewall/rules.pl > @@ -608,7 +608,7 @@ sub geoipblock { > # create iptables rules, if blocking this country > # is enabled. > foreach my $location (@locations) { > - if($geoipsettings{$location} eq "on") { > + if ($geoipsettings{$location} eq "on") { > run("$IPTABLES -A GEOIPBLOCK -m geoip --src-cc $location -j DROP"); > } > }
Hi, For unknown reasons I couldn't reproduce this error even with the original file. So I deferred this patch - I'm not sure anymore that this is really a bug!? The whole story (german) can be found here: https://forum.ipfire.org/viewtopic.php?f=22&t=19304 I fear I was a bit too fast... Best, Matthias On 21.08.2017 13:17, Michael Tremer wrote: > Hi, > > this has been set to deferred on Patchwork. Why? > > Best, > -Michael > > On Sat, 2017-08-19 at 13:30 +0200, Matthias Fischer wrote: >> Triggered by https://forum.ipfire.org/viewtopic.php?f=22&t=19304 >> >> Best, >> Matthias >> >> Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org> >> --- >> config/firewall/rules.pl | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/config/firewall/rules.pl b/config/firewall/rules.pl >> index 8b0c6ddc8..efbe9cfef 100644 >> --- a/config/firewall/rules.pl >> +++ b/config/firewall/rules.pl >> @@ -608,7 +608,7 @@ sub geoipblock { >> # create iptables rules, if blocking this country >> # is enabled. >> foreach my $location (@locations) { >> - if($geoipsettings{$location} eq "on") { >> + if ($geoipsettings{$location} eq "on") { >> run("$IPTABLES -A GEOIPBLOCK -m geoip --src-cc $location -j DROP"); >> } >> } >