mbox

[2/5] header-zone fix hook_config_edit()

Message ID 1500305066-12510-2-git-send-email-jonatan.schlag@ipfire.org
State Accepted
Commit 15be9d6963c91e787e25f2e9cc1defe446525470
Headers

Message

Jonatan Schlag July 18, 2017, 1:24 a.m. UTC 
  This function accepted only two arguments so new cmd coudl be passed.
We accept now more then 2 arguments.

Signed-off-by: Jonatan Schlag <jonatan.schlag@ipfire.org>
---
 src/header-zone | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Tremer July 18, 2017, 6:21 a.m. UTC | #1 
On Mon, 2017-07-17 at 17:24 +0200, Jonatan Schlag wrote:
> This function accepted only two arguments so new cmd coudl be passed.
> We accept now more then 2 arguments.
> 
> Signed-off-by: Jonatan Schlag <jonatan.schlag@ipfire.org>
> ---
>  src/header-zone | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/header-zone b/src/header-zone
> index 2e3fa09..98b0ce7 100644
> --- a/src/header-zone
> +++ b/src/header-zone
> @@ -225,7 +225,7 @@ hook_config_destroy() {
>  }
>  
>  hook_config_edit() {
> -	assert [ $# -eq 2 ]
> +	assert [ $# -ge 2 ]
>  	local zone=${1}
>  	# The id must be the id and not the hid.
>  	local id=${2}

Please have a blank line after any assertions.