From patchwork Fri Jun 9 20:17:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonatan Schlag X-Patchwork-Id: 1175 Return-Path: Received: from mail01.ipfire.org (unknown [172.28.1.200]) by web02.ipfire.org (Postfix) with ESMTP id 49C7A61C91 for ; Fri, 9 Jun 2017 12:17:50 +0200 (CEST) Received: from mail01.ipfire.org (localhost [IPv6:::1]) by mail01.ipfire.org (Postfix) with ESMTP id BCF152812; Fri, 9 Jun 2017 12:17:49 +0200 (CEST) Received: from ipfire.localdomain (dslb-088-073-203-240.088.073.pools.vodafone-ip.de [88.73.203.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 8E4D3280A; Fri, 9 Jun 2017 12:17:43 +0200 (CEST) From: Jonatan Schlag To: development@lists.ipfire.org, network@lists.ipfire.org Subject: [PATCH 2/6] ports: Change ports settings file to /etc/network/${port}/settings Date: Fri, 9 Jun 2017 12:17:28 +0200 Message-Id: <1497003452-10190-2-git-send-email-jonatan.schlag@ipfire.org> X-Mailer: git-send-email 2.6.3 In-Reply-To: <1497003452-10190-1-git-send-email-jonatan.schlag@ipfire.org> References: <1497003452-10190-1-git-send-email-jonatan.schlag@ipfire.org> X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: IPFire development talk List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: development-bounces@lists.ipfire.org Sender: "Development" The configuration of a port was stored in a file called: /etc/network/${port} This is bad because it is very hard to add further information which belong primary not to the configuration to this file. So we change the settings file to /etc/network/${port}/settings like for the zones. This make it possible to store other configurations like the color in other files in the directory /etc/network/${port}. A workaround to move the config file into the new directory scheme is: port=p1 && mv /etc/network/ports/${port} /etc/network/ports/${port}-save \ && mkdir -p /etc/network/ports/${port} \ && mv /etc/network/ports/${port}-save /etc/network/ports/${port}/settings where port is the name of the port like p1 or p0. Signed-off-by: Jonatan Schlag --- src/functions/functions.ports | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)